skip named args

Author: staabm

src/Rules/PHPUnit/AssertSameWithCountRule.php

@@ -5,6 +5,7 @@
 use Countable;
 use PhpParser\Node;
 use PhpParser\Node\Expr\CallLike;
+use PhpParser\NodeAbstract;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -40,6 +41,11 @@ public function processNode(Node $node, Scope $scope): array
 		if (!$node->name instanceof Node\Identifier	|| $node->name->toLowerString() !== 'assertsame') {
 			return [];
 		}
+		foreach ($node->getArgs() as $arg) {
+			if ($arg->name !== null) {
+				return [];
+			}
+		}
 
 		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
 			return [];
@@ -132,8 +138,9 @@ private static function isNormalCount(Node\Expr\FuncCall $countFuncCall, Type $c
 	}
 
 	/**
-	 * @param array<Node\Arg|Node\VariadicPlaceholder> $args
-	 * @return list<Node\Arg|Node\VariadicPlaceholder>
+	 * @template T of NodeAbstract
+	 * @param array<T> $args
+	 * @return list<T|Node\Arg>
 	 */
 	private static function rewriteArgs(array $args, Scope $scope): ?array
 	{

tests/Rules/PHPUnit/AssertSameWithCountRuleTest.php

@@ -4,6 +4,7 @@
 
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<AssertSameWithCountRule>
@@ -47,6 +48,15 @@ public function testFix(): void
 		$this->fix(__DIR__ . '/data/assert-same-count-fixable.php', __DIR__ . '/data/assert-same-count-fixable.php.fixed');
 	}
 
+	public function testNamedArguments(): void
+	{
+		if (PHP_VERSION_ID < 80000) {
+			self::markTestSkipped('Named arguments require PHP 8.0.');
+		}
+
+		$this->analyse([__DIR__ . '/data/assert-same-count-named-arguments.php'], []);
+	}
+
 	/**
 	 * @return string[]
 	 */

tests/Rules/PHPUnit/data/assert-same-count-named-arguments.php

@@ -0,0 +1,26 @@
+<?php // lint >= 8.0
+
+namespace ExampleTestCaseFixNamedArguments;
+
+class AssertSameWithCountTestCase extends \PHPUnit\Framework\TestCase
+{
+
+	public function skipNamedArguments(Bar $bar): void
+	{
+		$this->assertSame(expected: 5, actual: count([1, 2, 3]), message: 'message');
+		$this->assertSame(message: 'message', actual: count(value: [1, 2, 3]), expected: 5);
+		self::assertSame(actual: $bar->count(), expected: 5);
+		$this->assertSame(5, actual: count([1, 2, 3]), message: 'message');
+	}
+
+}
+
+class Bar implements \Countable
+{
+
+	public function count(): int
+	{
+		return 1;
+	}
+
+}