From 5b9b6418def5ecde0d4e4f62aae99ff7c5650df0 Mon Sep 17 00:00:00 2001 From: Pierre Brisorgueil Date: Sat, 13 Jun 2026 18:48:58 +0200 Subject: [PATCH] fix(home): mail readiness warning states the consequence MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With the admin layout banner removed on the UI side, the readiness 'mail' row is the single signal for an unconfigured mailer — its warning message now carries the consequence wording (users register without email verification) instead of relying on a separate banner. The ok-branch message and the category order are unchanged. refs pierreb-devkit/Vue#4297 --- modules/home/services/home.service.js | 2 +- modules/home/tests/home.service.unit.tests.js | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/modules/home/services/home.service.js b/modules/home/services/home.service.js index 58514b5db..d6a18475c 100644 --- a/modules/home/services/home.service.js +++ b/modules/home/services/home.service.js @@ -99,7 +99,7 @@ const getReadinessStatus = () => { checks.push({ category: 'mail', status: mailConfigured ? 'ok' : 'warning', - message: mailConfigured ? 'Mail provider configured' : 'No mail provider configured', + message: mailConfigured ? 'Mail provider configured' : 'No mail provider configured — users register without email verification', }); // billing — Stripe diff --git a/modules/home/tests/home.service.unit.tests.js b/modules/home/tests/home.service.unit.tests.js index 8f056330d..36db707b6 100644 --- a/modules/home/tests/home.service.unit.tests.js +++ b/modules/home/tests/home.service.unit.tests.js @@ -54,6 +54,25 @@ describe('HomeService.getReadinessStatus unit tests:', () => { expect(categories).not.toContain('monitoring'); }); + describe('mail row', () => { + test('warning message states the consequence when no mail provider is configured', async () => { + const HomeService = await withConfig({}); + const checks = HomeService.getReadinessStatus(); + const row = checks.find((c) => c.category === 'mail'); + expect(row.status).toBe('warning'); + expect(row.message).toBe('No mail provider configured — users register without email verification'); + }); + + test('ok message is unchanged when a mail provider is configured', async () => { + mockMailerIsConfigured.mockReturnValue(true); + const HomeService = await withConfig({}); + const checks = HomeService.getReadinessStatus(); + const row = checks.find((c) => c.category === 'mail'); + expect(row.status).toBe('ok'); + expect(row.message).toBe('Mail provider configured'); + }); + }); + describe('errorTracking row', () => { test('ok when analytics.posthog.key is set AND errorTracking=true', async () => { const HomeService = await withConfig({