Fix profiler-plugin-react entry point#16
Open
sugarmanz wants to merge 2 commits into
Open
Conversation
The package.json "main" pointed at src/index.tsx, but the source file is src/index.ts (no JSX), so the tsup build failed with "Cannot find src/index.tsx". Point main at the real .ts file, matching basic-plugin-react.
cehan-Chloe
approved these changes
Jun 29, 2026
Member
Author
|
/canary |
Package.swift declares the PlayerUIDevtoolsProfilerPlugin and PlayerUIDevtoolsBaseProfilerDevtoolsPlugin products, but assemble_ios_release never listed the profiler sources/resources, so the published devtools-ios tag (e.g. 0.14.0-next.0) declared the products while shipping no source for them — making them unbuildable for consumers. Add the missing entries (ios Sources, swiftui Sources, and the core native bundle as Resources) to spm_publish_zip, mirroring the BasicPlugin block. Verified the assembled zip now contains the profiler swift sources and the ProfilerDevtoolsPlugin.native.js resource bundle.
Member
Author
|
/canary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
Fixes a broken build entry point in
@player-devtools/profiler-plugin-react.package.jsondeclared"main": "src/index.tsx", but the source file issrc/index.ts(it contains no JSX — just a class extendingReactDevtoolsPlugin). tsup derives its entry frommain, so the build fails with:This shipped with the profiler plugin and is currently failing on
main. The fix pointsmainat the real.tsfile, matching@player-devtools/basic-plugin-react(whose entry is alsosrc/index.ts).Change Type (required)
patchminormajorTests
bazel build //devtools/plugins/profiler/react:reactcompletes successfully (previously failed withCannot find src/index.tsx).📦 Published PR as canary version:
0.13.1--canary.16.915Try this version out locally by upgrading relevant packages to 0.13.1--canary.16.915