Skip to content

Commit db89bb8

Browse files
committed
Merge remote-tracking branch 'upstream/main' into feature-hoverlabel-custom-styles
# Conflicts: # src/components/fx/hover.js # test/jasmine/bundle_tests/mathjax_test.js
2 parents 447e3e3 + 8dc3846 commit db89bb8

38 files changed

Lines changed: 553 additions & 83 deletions

‎.github/actions/setup-image-env/action.yml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,23 @@ inputs:
88
uv-version:
99
description: 'uv version to use'
1010
default: '0.11.2'
11+
chrome-version:
12+
description: 'Chrome version for Kaleido. The baselines depend on this version.'
13+
default: '154.0.8037.92'
1114

1215
runs:
1316
using: 'composite'
1417
steps:
18+
# Pin Chrome so a runner image update does not change the rendered baselines
19+
- uses: ./.github/actions/setup-chrome
20+
with:
21+
chrome-version: ${{ inputs.chrome-version }}
22+
23+
# Kaleido uses the Chrome at BROWSER_PATH instead of the Chrome of the runner
24+
- name: Point Kaleido at the pinned Chrome
25+
run: echo "BROWSER_PATH=$CHROME_BIN" >> $GITHUB_ENV
26+
shell: bash
27+
1528
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
1629
with:
1730
python-version: ${{ inputs.python-version }}

‎.github/workflows/ci.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -586,6 +586,16 @@ jobs:
586586
- name: Type-check TypeScript sources
587587
run: npm run typecheck
588588

589+
test-types:
590+
needs: install-and-cibuild
591+
runs-on: ubuntu-latest
592+
steps:
593+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
594+
- uses: ./.github/actions/setup-workspace
595+
596+
- name: Test the public TypeScript types
597+
run: npm run test-types
598+
589599
generated-types-drift:
590600
needs: install-and-cibuild
591601
runs-on: ubuntu-latest

‎draftlogs/7935_fix.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix tick label format sometimes being incompatible with the labeled tick when using `ticklabelindex` [[#7935](https://github.com/plotly/plotly.js/pull/7935)], with thanks to @my-tien for the contribution!

‎draftlogs/8039_fix.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix unified hover swatch color and pattern for bar `marker.pattern` arrays [[#8039](https://github.com/plotly/plotly.js/pull/8039)], with thanks to @Dmao233 for the contribution!

‎draftlogs/8045_fix.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Keep cartesian traces aligned with their axes when an automargin title is combined with any component that expands the margins [[#8045](https://github.com/plotly/plotly.js/pull/8045)]

‎draftlogs/8051_fix.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Fix hover labels ignoring MathJax for text that is a single tex expression [[#8051](https://github.com/plotly/plotly.js/pull/8051)], with thanks to @SergeyAxiomatic
2+
- Fix XSS via `javascript:` URLs in MathJax `\href` macros by sanitizing links in MathJax-rendered text [[#8051](https://github.com/plotly/plotly.js/pull/8051)], with thanks to @SergeyAxiomatic

‎draftlogs/8069_fix.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix quiver arrow colors for a discrete `marker.color` array [[#8069](https://github.com/plotly/plotly.js/pull/8069)], with thanks to @Yahiro025 for the contribution!

‎draftlogs/8119_fix.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Convert modern CSS color formats to rgba for scattergl based traces [[#8119](https://github.com/plotly/plotly.js/pull/8119)]

‎draftlogs/8126_fix.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- Update TypeScript types so that `Plotly.relayout`, `Plotly.restyle`, `Plotly.update`, and the `plotly_relayout` event accept attribute paths such as `'xaxis.autorange'` [[#8126](https://github.com/plotly/plotly.js/pull/8126)]
2+
- Add the `LayoutUpdate` and `DataUpdate` types for these update objects
3+
- Add the `(root, attribute, value)` call form to the types of `Plotly.relayout` and `Plotly.restyle`

‎lib/index.d.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ export type * from '../src/types/generated/schema';
5555

5656
export type {
5757
ButtonClickEvent,
58+
DataUpdate,
5859
Icon,
60+
LayoutUpdate,
5961
ModeBarButton,
6062
ModeBarButtonAny,
6163
ModeBarDefaultButtons,

0 commit comments

Comments
 (0)