Repository navigation
Commit 5d7743b
Don't modify the annotation passed to add_vline and friends
axis_spanning_shape_annotation filled in the annotation it was given
(text from annotation_* kwargs, and x/y/xanchor/yanchor from the shape)
in place. When the same dict or go.layout.Annotation was passed to
several add_vline/add_hline/add_vrect/add_hrect calls, the first call
left x/y in it, and later calls only set positions that weren't set
already, so every annotation ended up at the first shape.
Work on a copy of the annotation instead.
Closes #3547
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent c6ab9c7 commit 5d7743b
3 files changed
Lines changed: 31 additions & 0 deletions
File tree
- plotly
- tests/test_optional/test_autoshapes
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
244 | 245 | | |
245 | 246 | | |
246 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
247 | 252 | | |
248 | 253 | | |
249 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
282 | 283 | | |
283 | 284 | | |
284 | 285 | | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
285 | 310 | | |
286 | 311 | | |
287 | 312 | | |
| |||
0 commit comments