Skip to content

Commit 7719805

Browse files
committed
require only 'jupyter-builder' python package for building extension, rather than the much larger 'jupyterlab'
1 parent 5dd1580 commit 7719805

6 files changed

Lines changed: 68 additions & 10 deletions

File tree

.github/workflows/check-js-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
run: |
5050
uv venv
5151
source .venv/bin/activate
52-
# Technically, we only need the `jupyterlab` package, but using the dev_build extra
52+
# Technically, we only need the `jupyter-builder` package, but using the dev_build extra
5353
# keeps build behavior consistent across all CI jobs
5454
uv sync --extra dev_build
5555
cd js

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ Two kinds of Jupyter support are included:
251251
which allows us to avoid embedding `plotly.js` in the notebook output.
252252
The JupyterLab extension source code is located at `js/src/mimeExtension.ts`
253253
and the compiled extension code is located at `plotly/labextension` in the built Python package.
254-
The command `jupyter labextension build` (which is one of the steps called by `npm run build`) compiles the extension
254+
The command `jupyter-builder build` (which is one of the steps called by `npm run build`) compiles the extension
255255
and places the build artifacts in `plotly/labextension`.
256256

257257
2. **FigureWidget**:

js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"scripts": {
1313
"build:widget": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=../plotly/package_data/widgetbundle.js src/widget.ts",
1414
"build:mimerenderer": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=lib/mimeExtension.js src/mimeExtension.ts",
15-
"build:labextension": "jupyter labextension build .",
15+
"build:labextension": "jupyter-builder build .",
1616
"build": "npm run build:widget && npm run build:mimerenderer && npm run build:labextension",
1717
"watch": "npm run build -- --watch --sourcemap=inline",
1818
"typecheck": "tsc --noEmit"

plotly/labextension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"scripts": {
1313
"build:widget": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=../plotly/package_data/widgetbundle.js src/widget.ts",
1414
"build:mimerenderer": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=lib/mimeExtension.js src/mimeExtension.ts",
15-
"build:labextension": "jupyter labextension build .",
15+
"build:labextension": "jupyter-builder build .",
1616
"build": "npm run build:widget && npm run build:mimerenderer && npm run build:labextension",
1717
"watch": "npm run build -- --watch --sourcemap=inline",
1818
"typecheck": "tsc --noEmit"

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ dev_core = [
5151
dev_build = [
5252
"plotly[dev_core]",
5353
"build",
54-
"jupyterlab"
54+
"jupyter-builder"
5555
]
5656
dev_optional = [
5757
"plotly[dev_build]",
@@ -63,6 +63,7 @@ dev_optional = [
6363
"fiona<=1.9.6;python_version<='3.8'",
6464
"geopandas",
6565
"inflect",
66+
"jupyterlab",
6667
"orjson",
6768
"pandas",
6869
"pdfrw",

0 commit comments

Comments
 (0)