Skip to content

nip55: drop orphaned unkeyed SigningAuditLog.verifyChain from keep UDL #310

@kwsantiago

Description

@kwsantiago

Context

After #306 (commit 1f24845), the Android app verifies signing history through the keyed-HMAC chain via PermissionStore.verifyAuditChain(). The previously-used SigningAuditLog.verifyChain() (the unkeyed blake2b chain in keep/keep-mobile/src/audit.rs) is no longer called anywhere in keep-android (confirmed by grep; only the generated UniFFI binding references it).

Issue

The weaker unkeyed verify path is now orphaned in this repo. It cannot be removed from keep-android because it is generated from the UDL, but leaving it exported invites future misuse (a caller wiring the verified badge back to the unkeyed chain, which is the exact bug #306 fixed).

Fix

Upstream in the keep repo: remove SigningAuditLog.verifyChain (or the unkeyed chain entirely if it has no remaining consumers) from the UDL / keep-mobile surface, then re-pin keep.version here. Verify no other consumer depends on it before removal.

This is an upstream keep change, tracked here for visibility on the keep-android side.

Metadata

Metadata

Assignees

No one assigned

    Labels

    easynip55NIP-55 signer protocolp3Lowest PriorityrefactorCode restructuring without behavior change

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions