E2E Test Coverage: Missing email verification step in signup flow

[Ayush4958]

Increasing Access

Ensuring that critical security and authentication flows, like email verification which are robustly tested prevents bugs that could lock users out of their accounts.

Feature enhancement details

The E2E test can sign up and verify email via the emailed link inside e2e/specs/signup.spec.ts currently tests the initial signup form submission and login redirect, but it stops short of actually verifying the email address.

There is an explicit TODO left in the code :-

// Successful signup logs the user in and redirects to the editor
await expect(page.locator('.editor-holder')).toBeVisible({
  timeout: 15_000
});
// TODO: on next PR, email verification

Because email verification is a critical part of the user authentication and onboarding flow, leaving this step untested means the application is vulnerable to regressions in the verification process.

[Ayush4958]

@Geethegreat @ksen0
Note :- I would like to add test suite for email verification
After the issue is assigned to me, I can raise a PR

thanks .....

[Geethegreat]

Thanks for flagging this! This is already being worked on as part of the GSoC E2E testing project. The TODO comment in signup.spec.ts was intentional email verification requires Mailpit (a local SMTP capture server) to be set up in the test environment, which is being added in a separate PR. The implementation is in progress at [#4223].

[Ayush4958]

Thanks @Geethegreat for classification
I have a small question, If I come up with another TODO comment
does that mean its already under working or can I raise the issue for it ??

[Geethegreat]

Sure! as long as there is no existing pr addressing it, you can.

[Ayush4958]

Sure! as long as there is no existing pr addressing it, you can.

ohh, Thanks for info.
I will close this issue body now