From bd82c907256908f8f18a1d7e145d205661d23032 Mon Sep 17 00:00:00 2001
From: Matthias Dellweg <mdellweg@redhat.com>
Date: Tue, 14 Jul 2026 17:57:15 +0200
Subject: [PATCH] Remove insecure default Django secret

---
 .ci/ansible/settings.py.j2                                    | 1 +
 .ci/ansible/start_container.yaml                              | 2 ++
 pulp_file/tests/functional/api/test_domains.py                | 2 +-
 pulp_file/tests/functional/api/test_filesystem_export.py      | 2 +-
 pulp_file/tests/functional/api/test_pulp_export.py            | 2 +-
 pulpcore/app/access_policy.py                                 | 2 +-
 pulpcore/app/authentication.py                                | 3 +--
 pulpcore/app/redis_connection.py                              | 3 +--
 pulpcore/app/serializers/exporter.py                          | 3 ++-
 pulpcore/app/serializers/importer.py                          | 3 ++-
 pulpcore/app/serializers/repository.py                        | 3 ++-
 pulpcore/app/settings.py                                      | 4 ++--
 pulpcore/app/views/importer.py                                | 2 +-
 pulpcore/cache/cache.py                                       | 2 +-
 pulpcore/tasking/kafka.py                                     | 2 +-
 pulpcore/tests/functional/api/test_auth.py                    | 3 +--
 pulpcore/tests/functional/api/test_tasking.py                 | 2 +-
 pulpcore/tests/functional/api/using_plugin/test_pulpimport.py | 2 +-
 pyproject.toml                                                | 1 +
 19 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/.ci/ansible/settings.py.j2 b/.ci/ansible/settings.py.j2
index ab8ebb3dce0..0b8a1a16a4d 100644
--- a/.ci/ansible/settings.py.j2
+++ b/.ci/ansible/settings.py.j2
@@ -1,3 +1,4 @@
+SECRET_KEY = "{{ django_secret }}"
 CONTENT_ORIGIN = "{{ pulp_scheme }}://pulp:{{ 443 if pulp_scheme == 'https' else 80 }}"
 ANSIBLE_API_HOSTNAME = "{{ pulp_scheme }}://pulp:{{ 443 if pulp_scheme == 'https' else 80 }}"
 ANSIBLE_CONTENT_HOSTNAME = "{{ pulp_scheme }}://pulp:{{ 443 if pulp_scheme == 'https' else 80 }}/pulp/content"
diff --git a/.ci/ansible/start_container.yaml b/.ci/ansible/start_container.yaml
index e0891b7ab5d..4ef94c861cf 100644
--- a/.ci/ansible/start_container.yaml
+++ b/.ci/ansible/start_container.yaml
@@ -18,6 +18,8 @@
       ansible.builtin.template:
         src: "settings.py.j2"
         dest: "settings/settings.py"
+      vars:
+        django_secret: "lookup('community.general.random_string', length=50, overwrite_all='abcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*(-_=+)')"
 
     - name: "Setup docker networking"
       community.docker.docker_network:
diff --git a/pulp_file/tests/functional/api/test_domains.py b/pulp_file/tests/functional/api/test_domains.py
index 51869b8114e..c88eecc0048 100644
--- a/pulp_file/tests/functional/api/test_domains.py
+++ b/pulp_file/tests/functional/api/test_domains.py
@@ -2,8 +2,8 @@
 import uuid
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.tests.functional.utils import download_file, generate_iso
 
 pytestmark = pytest.mark.skipif(not settings.DOMAIN_ENABLED, reason="Domains not enabled.")
diff --git a/pulp_file/tests/functional/api/test_filesystem_export.py b/pulp_file/tests/functional/api/test_filesystem_export.py
index 5720840ca5a..da92c1b471b 100644
--- a/pulp_file/tests/functional/api/test_filesystem_export.py
+++ b/pulp_file/tests/functional/api/test_filesystem_export.py
@@ -2,8 +2,8 @@
 import uuid
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulpcore.exceptions import ApiException, BadRequestException
 from pulpcore.constants import TASK_STATES
 
diff --git a/pulp_file/tests/functional/api/test_pulp_export.py b/pulp_file/tests/functional/api/test_pulp_export.py
index 7a1078eede1..792c15812cb 100644
--- a/pulp_file/tests/functional/api/test_pulp_export.py
+++ b/pulp_file/tests/functional/api/test_pulp_export.py
@@ -3,8 +3,8 @@
 from pathlib import Path
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulpcore.exceptions import ApiException, BadRequestException
 from pulpcore.constants import TASK_STATES
 
diff --git a/pulpcore/app/access_policy.py b/pulpcore/app/access_policy.py
index 6cb41c02b7b..6654f5259c8 100644
--- a/pulpcore/app/access_policy.py
+++ b/pulpcore/app/access_policy.py
@@ -1,9 +1,9 @@
 from copy import deepcopy
 
+from django.conf import settings
 from rest_access_policy import AccessPolicy
 from rest_framework.exceptions import APIException
 
-from pulpcore.app import settings
 from pulpcore.app.models import AccessPolicy as AccessPolicyModel
 from pulpcore.app.util import get_view_urlpattern, get_viewset_for_model
 
diff --git a/pulpcore/app/authentication.py b/pulpcore/app/authentication.py
index 0e42ec0871d..745e35e1ffa 100644
--- a/pulpcore/app/authentication.py
+++ b/pulpcore/app/authentication.py
@@ -5,6 +5,7 @@
 from gettext import gettext as _
 
 import jq
+from django.conf import settings
 from django.contrib.auth import authenticate
 from django.contrib.auth.backends import RemoteUserBackend
 from rest_framework.authentication import (
@@ -16,8 +17,6 @@
 )
 from rest_framework.exceptions import AuthenticationFailed
 
-from pulpcore.app import settings
-
 _logger = logging.getLogger(__name__)
 
 
diff --git a/pulpcore/app/redis_connection.py b/pulpcore/app/redis_connection.py
index 4c3096e9b19..81cffedeaec 100644
--- a/pulpcore/app/redis_connection.py
+++ b/pulpcore/app/redis_connection.py
@@ -1,8 +1,7 @@
+from django.conf import settings
 from redis import Redis
 from redis.asyncio import Redis as aRedis
 
-from pulpcore.app.settings import settings
-
 _conn = None
 _a_conn = None
 
diff --git a/pulpcore/app/serializers/exporter.py b/pulpcore/app/serializers/exporter.py
index 8142853d196..fd8a98964fd 100644
--- a/pulpcore/app/serializers/exporter.py
+++ b/pulpcore/app/serializers/exporter.py
@@ -2,9 +2,10 @@
 import re
 from gettext import gettext as _
 
+from django.conf import settings
 from rest_framework import serializers
 
-from pulpcore.app import models, settings
+from pulpcore.app import models
 from pulpcore.app.serializers import (
     DetailIdentityField,
     DetailRelatedField,
diff --git a/pulpcore/app/serializers/importer.py b/pulpcore/app/serializers/importer.py
index e1a28ae60a9..5985e7fc5e3 100644
--- a/pulpcore/app/serializers/importer.py
+++ b/pulpcore/app/serializers/importer.py
@@ -1,10 +1,11 @@
 import os
 from gettext import gettext as _
 
+from django.conf import settings
 from django.core.exceptions import ObjectDoesNotExist
 from rest_framework import serializers
 
-from pulpcore.app import models, settings
+from pulpcore.app import models
 from pulpcore.app.serializers import (
     DetailIdentityField,
     DomainUniqueValidator,
diff --git a/pulpcore/app/serializers/repository.py b/pulpcore/app/serializers/repository.py
index 191ed4c991a..22b30a30202 100644
--- a/pulpcore/app/serializers/repository.py
+++ b/pulpcore/app/serializers/repository.py
@@ -2,10 +2,11 @@
 from gettext import gettext as _
 from urllib.parse import urlparse
 
+from django.conf import settings
 from rest_framework import fields, serializers
 from rest_framework_nested.serializers import NestedHyperlinkedModelSerializer
 
-from pulpcore.app import models, settings
+from pulpcore.app import models
 from pulpcore.app.serializers import (
     DetailIdentityField,
     DetailRelatedField,
diff --git a/pulpcore/app/settings.py b/pulpcore/app/settings.py
index 11b05424538..a335af04890 100644
--- a/pulpcore/app/settings.py
+++ b/pulpcore/app/settings.py
@@ -88,8 +88,8 @@
 # List of upload handler classes to be applied in order.
 FILE_UPLOAD_HANDLERS = ("pulpcore.app.files.HashingFileUploadHandler",)
 
-# SECURITY WARNING: this should be set to a unique, unpredictable value
-SECRET_KEY = "SECRET"
+# SECURITY WARNING: this must be set to a unique, unpredictable value.
+# SECRET_KEY = "SECRET"
 
 # Key used to encrypt fields in the database
 DB_ENCRYPTION_KEY = "/etc/pulp/certs/database_fields.symmetric.key"
diff --git a/pulpcore/app/views/importer.py b/pulpcore/app/views/importer.py
index 5e5f104588a..e49aa43ba04 100644
--- a/pulpcore/app/views/importer.py
+++ b/pulpcore/app/views/importer.py
@@ -2,11 +2,11 @@
 import os
 from gettext import gettext as _
 
+from django.conf import settings
 from drf_spectacular.utils import extend_schema
 from rest_framework.response import Response
 from rest_framework.views import APIView
 
-from pulpcore.app import settings
 from pulpcore.app.serializers import PulpImportCheckResponseSerializer, PulpImportCheckSerializer
 
 
diff --git a/pulpcore/cache/cache.py b/pulpcore/cache/cache.py
index ec6ca80e6f6..6fcf470e14a 100644
--- a/pulpcore/cache/cache.py
+++ b/pulpcore/cache/cache.py
@@ -5,6 +5,7 @@
 
 from aiohttp.web import FileResponse, HTTPSuccessful, Request, Response, StreamResponse
 from aiohttp.web_exceptions import HTTPFound
+from django.conf import settings
 from django.http import FileResponse as ApiFileResponse
 from django.http import HttpResponse, HttpResponseRedirect
 from redis import ConnectionError
@@ -16,7 +17,6 @@
     get_async_redis_connection,
     get_redis_connection,
 )
-from pulpcore.app.settings import settings
 from pulpcore.metrics import artifacts_size_counter
 from pulpcore.responses import ArtifactResponse
 
diff --git a/pulpcore/tasking/kafka.py b/pulpcore/tasking/kafka.py
index 3f6f0fd447d..808e20d7bbf 100644
--- a/pulpcore/tasking/kafka.py
+++ b/pulpcore/tasking/kafka.py
@@ -6,7 +6,7 @@
 
 from django.conf import settings
 
-_bootstrap_servers = settings.get("KAFKA_BOOTSTRAP_SERVERS")
+_bootstrap_servers = getattr(settings, "KAFKA_BOOTSTRAP_SERVERS")
 
 
 if _bootstrap_servers is None:
diff --git a/pulpcore/tests/functional/api/test_auth.py b/pulpcore/tests/functional/api/test_auth.py
index 4bf6478b7c8..3eeb616d6c8 100644
--- a/pulpcore/tests/functional/api/test_auth.py
+++ b/pulpcore/tests/functional/api/test_auth.py
@@ -8,8 +8,7 @@
 from base64 import b64encode
 
 import pytest
-
-from pulpcore.app import settings
+from django.conf import settings
 
 
 @pytest.mark.parallel
diff --git a/pulpcore/tests/functional/api/test_tasking.py b/pulpcore/tests/functional/api/test_tasking.py
index 92b9afe7381..d9e95a56a0c 100644
--- a/pulpcore/tests/functional/api/test_tasking.py
+++ b/pulpcore/tests/functional/api/test_tasking.py
@@ -9,8 +9,8 @@
 
 import pytest
 from aiohttp import BasicAuth
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulpcore import ApiException
 from pulpcore.constants import IMMEDIATE_TIMEOUT
 from pulpcore.tests.functional.utils import PulpTaskError, download_file
diff --git a/pulpcore/tests/functional/api/using_plugin/test_pulpimport.py b/pulpcore/tests/functional/api/using_plugin/test_pulpimport.py
index a605f0ff0eb..349d6781375 100644
--- a/pulpcore/tests/functional/api/using_plugin/test_pulpimport.py
+++ b/pulpcore/tests/functional/api/using_plugin/test_pulpimport.py
@@ -11,8 +11,8 @@
 from pathlib import Path
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulp_file import FileRepositorySyncURL
 from pulpcore.client.pulpcore.exceptions import ApiException
 
diff --git a/pyproject.toml b/pyproject.toml
index 469d3660f16..20a6d01d9a3 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -289,6 +289,7 @@ extend-select = [
 [tool.ruff.lint.flake8-tidy-imports.banned-api]
 # This section is managed by the plugin template. Do not edit manually.
 "distutils".msg = "The 'distutils' module has been deprecated since Python 3.9."
+"pulpcore.app.settings".msg = "Always import 'settings' from 'django.conf' instead."
 
 [tool.ruff.lint.isort]
 # This section is managed by the plugin template. Do not edit manually.