From 628959b178ab075c0b9af833511e53b4f5640fcb Mon Sep 17 00:00:00 2001 From: Ran Benita Date: Wed, 14 Oct 2026 17:45:17 +0300 Subject: [PATCH] docs: remove outdated hookimpl default args paragraph No longer correct, replaced by the "Hookimpl argument defaults" section. Reverts 8da58915b3554b396e06695bb80ec1819c30f9ff --- changelog/522.doc.rst | 1 - docs/index.rst | 6 ------ 2 files changed, 7 deletions(-) delete mode 100644 changelog/522.doc.rst diff --git a/changelog/522.doc.rst b/changelog/522.doc.rst deleted file mode 100644 index cdadfa8d..00000000 --- a/changelog/522.doc.rst +++ /dev/null @@ -1 +0,0 @@ -Document that hook implementation arguments with default values are not passed by pluggy. diff --git a/docs/index.rst b/docs/index.rst index 6a67265e..f2aaf957 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -595,12 +595,6 @@ To allow for *hookspecs* to evolve over the lifetime of a project, This allows for extending hook arguments (and thus semantics) without breaking existing *hookimpls*. -Only arguments without default values are considered for this opt-in -matching. Arguments with defaults in a *hookimpl* are treated as optional -keyword arguments and are not passed by pluggy, even when the hook caller -provides a value with the same name. If a *hookimpl* needs a value from the -hook call, declare it without a default value. - In other words this is ok: .. code-block:: python