Test test_writer_bad_message fails with ujson #6

Activity

1. jelly

   added a commit that references this issue on Aug 27, 2021

   Adjust test_writer_bad_message for ujson

   ...

   This issue will close once commit d8f6524 is merged into the 'develop' branch.

   d8f6524
2. itsbenweeks

   added a commit that references this issue on Feb 1, 2022

   Merge pull request python-lsp#6 from xiaoxiae/develop

   ...

   1833875
3. papoteur-mga commented on Sep 19, 2023

   

   papoteur-mga

   on Sep 19, 2023

   More actions

   I still get the same error with the 1.1.1 release.
4. lcheylus commented on Oct 3, 2023

   

   lcheylus

   on Oct 3, 2023

   More actions

   Same error with release 1.1.2 on OpenBSD with Python 3.10 and ujson-5.8.0

   ===>  Regression tests for py3-python-lsp-jsonrpc-1.1.2
   ============================= test session starts ==============================
   platform openbsd7 -- Python 3.10.13, pytest-7.1.3, pluggy-1.2.0
   rootdir: /usr/obj/ports/py-python-lsp-jsonrpc-1.1.2-python3/python-lsp-jsonrpc-1.1.2, configfile: pyproject.toml, testpaths: test
   plugins: mock-3.10.0, cov-4.0.0
   collected 27 items
   
   test/test_endpoint.py ......................                             [ 81%]
   test/test_streams.py ....F                                               [100%]
   
   =================================== FAILURES ===================================
   ___________________________ test_writer_bad_message ____________________________
   
   wfile = <_io.BytesIO object at 0xe55f47a36a0>
   writer = <pylsp_jsonrpc.streams.JsonRpcStreamWriter object at 0xe55f475a350>
   
       def test_writer_bad_message(wfile, writer):
           # A datetime isn't serializable(or poorly serializable),
           # ensure the write method doesn't throw, but the result could be empty
           # or the correct datetime
           datetime.datetime = JsonDatetime
           writer.write(datetime.datetime(
               year=2019,
               month=1,
               day=1,
               hour=1,
               minute=1,
               second=1,
           ))
   
   >       assert wfile.getvalue() in [
               b'',
               b'Content-Length: 10\r\n'
               b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
               b'\r\n'
               b'1546304461',
               b'Content-Length: 10\r\n'
               b'Content-Type: application/vscode-jsonrpc; charset=utf8\r\n'
               b'\r\n'
               b'1546322461'
           ]
   E       AssertionError: assert b'Content-Length: 10\r\nContent-Type: application/vscode-jsonrpc; charset=utf8\r\n\r\n1546300861' in [b'', b'Content-Length: 10\r\nContent-Type: application/vscode-jsonrpc; charset=utf8\r\n\r\n1546304461', b'Content-Length: 10\r\nContent-Type:
    application/vscode-jsonrpc; charset=utf8\r\n\r\n1546322461']
   E        +  where b'Content-Length: 10\r\nContent-Type: application/vscode-jsonrpc; charset=utf8\r\n\r\n1546300861' = <built-in method getvalue of _io.BytesIO object at 0xe55f47a36a0>()
   E        +    where <built-in method getvalue of _io.BytesIO object at 0xe55f47a36a0> = <_io.BytesIO object at 0xe55f47a36a0>.getvalue
   
   test/test_streams.py:125: AssertionError
   - generated xml file: /usr/obj/ports/py-python-lsp-jsonrpc-1.1.2-python3/python-lsp-jsonrpc-1.1.2/pytest.xml -
   - (...)
   - =========================== short test summary info ============================
   FAILED test/test_streams.py::test_writer_bad_message - AssertionError: assert...
   ========================= 1 failed, 26 passed in 0.52s =========================
   - ```