gh-149110: Fix race in _PyFrame_IsIncomplete for FRAME_OWNED_BY_FRAME_OBJECT frames

Author: BHUVANSH855

Include/internal/pycore_code.h

@@ -566,8 +566,11 @@ _PyCode_GetTLBCFast(PyThreadState *tstate, PyCodeObject *co)
 {
     _PyCodeArray *code = _PyCode_GetTLBCArray(co);
     int32_t idx = ((_PyThreadStateImpl*) tstate)->tlbc_index;
-    if (idx < code->size && code->entries[idx] != NULL) {
-        return (_Py_CODEUNIT *) code->entries[idx];
+    if (idx < code->size) {
+        void *entry = _Py_atomic_load_ptr_acquire(&code->entries[idx]);
+        if (entry != NULL) {
+            return (_Py_CODEUNIT *) entry;
+        }
     }
     return NULL;
 }

Include/internal/pycore_interpframe.h

@@ -61,7 +61,7 @@ _PyFrame_GetBytecode(_PyInterpreterFrame *f)
     PyCodeObject *co = _PyFrame_GetCode(f);
     _PyCodeArray *tlbc = _PyCode_GetTLBCArray(co);
     assert(f->tlbc_index >= 0 && f->tlbc_index < tlbc->size);
-    return (_Py_CODEUNIT *)tlbc->entries[f->tlbc_index];
+    return (_Py_CODEUNIT *)_Py_atomic_load_ptr_acquire(&tlbc->entries[f->tlbc_index]);
 #else
     return _PyCode_CODE(_PyFrame_GetCode(f));
 #endif
@@ -294,6 +294,12 @@ _PyFrame_IsIncomplete(_PyInterpreterFrame *frame)
     if (frame->owner >= FRAME_OWNED_BY_INTERPRETER) {
         return true;
     }
+    /* Frames owned by a frame object are guaranteed complete by take_ownership().
+     * Checking instr_ptr here would race with take_ownership() when called from
+     * another thread (e.g. pdb walking frame->f_back cross-thread). */
+    if (frame->owner == FRAME_OWNED_BY_FRAME_OBJECT) {
+        return false;
+    }
     return frame->owner != FRAME_OWNED_BY_GENERATOR &&
            frame->instr_ptr < _PyFrame_GetBytecode(frame) +
                                   _PyFrame_GetCode(frame)->_co_firsttraceable;

Lib/test/test_free_threading/test_frame.py

@@ -146,6 +146,40 @@ def clearer():
 
         threading_helper.run_concurrently([reader, reader, clearer])
 
+    def test_f_back_after_thread_return(self):
+        # gh-149110: Accessing frame.f_back cross-thread while the owning
+        # thread is returning caused a spurious assertion failure in
+        # PyFrame_GetBack on free-threaded builds.
+        frames = []
+        lock = threading.Lock()
+
+        def target():
+            frame = sys._getframe()
+            with lock:
+                frames.append(frame)
+
+        def inspector():
+            for _ in range(50):
+                frame = None
+                with lock:
+                    if frames:
+                        frame = frames[-1]
+                if frame is not None:
+                    try:
+                        _ = frame.f_back
+                    except Exception:
+                        pass
+                sys._clear_internal_caches()
+
+        threads = [threading.Thread(target=target) for _ in range(20)]
+        insp = threading.Thread(target=inspector)
+        insp.start()
+        for t in threads:
+            t.start()
+        for t in threads:
+            t.join()
+        insp.join()
+
 
 if __name__ == "__main__":
     unittest.main()

Misc/NEWS.d/next/Core_and_Builtins/2026-08-18-10-38-00.gh-issue-149110.rqYKjG.rst

@@ -0,0 +1,3 @@
+Fix a race condition in free-threaded builds where cross-thread frame
+inspection via :mod:`pdb` could cause a spurious assertion failure in
+:c:func:`PyFrame_GetBack`.

Objects/codeobject.c

@@ -3406,7 +3406,7 @@ create_tlbc_lock_held(PyInterpreterState *interp, PyCodeObject *co, Py_ssize_t i
     }
     copy_code(interp, (_Py_CODEUNIT *) bc, co);
     assert(tlbc->entries[idx] == NULL);
-    tlbc->entries[idx] = bc;
+    _Py_atomic_store_ptr_release(&tlbc->entries[idx], bc);
     return (_Py_CODEUNIT *) bc;
 }
 

Python/frame.c

@@ -55,15 +55,21 @@ take_ownership(PyFrameObject *f, _PyInterpreterFrame *frame)
     // _PyFrame_Copy takes the reference to the executable,
     // so we need to restore it.
     new_frame->f_executable = PyStackRef_DUP(new_frame->f_executable);
-    f->f_frame = new_frame;
-    new_frame->owner = FRAME_OWNED_BY_FRAME_OBJECT;
+    /* Fix instr_ptr BEFORE setting owner = FRAME_OWNED_BY_FRAME_OBJECT,
+     * since _PyFrame_IsIncomplete() short-circuits to false for that owner.
+     * The original owner (FRAME_OWNED_BY_THREAD) is used for the check. */
     if (_PyFrame_IsIncomplete(new_frame)) {
         // This may be a newly-created generator or coroutine frame. Since it's
         // dead anyways, just pretend that the first RESUME ran:
         PyCodeObject *code = _PyFrame_GetCode(new_frame);
         new_frame->instr_ptr =
             _PyFrame_GetBytecode(new_frame) + code->_co_firsttraceable + 1;
     }
+    /* Set owner BEFORE updating f->f_frame so any concurrent reader that
+     * observes the new f_frame pointer also sees owner = FRAME_OWNED_BY_FRAME_OBJECT,
+     * causing _PyFrame_IsIncomplete() to short-circuit to false. */
+    new_frame->owner = FRAME_OWNED_BY_FRAME_OBJECT;
+    f->f_frame = new_frame;
     assert(!_PyFrame_IsIncomplete(new_frame));
     assert(f->f_back == NULL);
     _PyInterpreterFrame *prev = _PyFrame_GetFirstComplete(frame->previous);