Skip to content

Wrap the error reporting function of ReadStat to provide more#80

Merged
davidanthoff merged 1 commit into
queryverse:masterfrom
andreasnoack:master
Aug 16, 2021
Merged

Wrap the error reporting function of ReadStat to provide more#80
davidanthoff merged 1 commit into
queryverse:masterfrom
andreasnoack:master

Conversation

@andreasnoack

Copy link
Copy Markdown
Contributor

informative error messages.

julia> read_sas7bdat("brokenfile.sas7bdat")
ERROR: Error parsing brokenfile.sas7bdat: Unable to convert string to the requested encoding (invalid byte sequence)
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:33
 [2] parse_data_file!(ds::ReadStatDataFrame, parser::Ptr{Nothing}, filename::String, filetype::Val{:sas7bdat})
   @ ReadStat ~/.julia/dev/ReadStat/src/ReadStat.jl:287
 [3] read_data_file(filename::String, filetype::Val{:sas7bdat})
   @ ReadStat ~/.julia/dev/ReadStat/src/ReadStat.jl:261
 [4] read_sas7bdat(filename::String)
   @ ReadStat ~/.julia/dev/ReadStat/src/ReadStat.jl:293
 [5] top-level scope
   @ REPL[5]:1

instead of just ERROR: Error parsing brokenfile.sas7bdat: 17

@davidanthoff davidanthoff merged commit d3c9958 into queryverse:master Aug 16, 2021
@davidanthoff

Copy link
Copy Markdown
Member

Thanks!

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.61%. Comparing base (7fc3249) to head (466128a).
⚠️ Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
src/ReadStat.jl 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   78.98%   78.61%   -0.37%     
==========================================
  Files           2        2              
  Lines         157      159       +2     
==========================================
+ Hits          124      125       +1     
- Misses         33       34       +1     
Flag Coverage Δ
unittests 78.61% <50.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants