Skip to content

Ambiguity on why the index property in ViewToken is marked optional #3637

Closed

Description

@jobpaardekooper

Description

On the ViewToken page in the docs it shows that the index property is optional. This is not explained in any further detail by the docs.

What is the problem?

It is unclear to me in what situation this property would be null. This object is used as a parameter for the onViewableItemsChanged callback in VirtualizedList so it is in turn also used in both FlatList and SectionList. This makes me think there wouldn't be a situation where index would be null.

How can we address it?

Update the description of the index property on ViewToken to clarify in what situation it could be null.

If anyone knows a resource like an issue in the react-native repo or a from post that discusses this or can explain it to me I can also make a PR to clarify the description on the property.

Why is it important?

It is currently ambiguous why the index property on ViewToken is marked as optional.

Who needs this?

Anyone using the onViewableItemsChanged prop and relies on the indexes of the callback.

Activity

  1. github-actions commented on Jun 21, 2023

    @github-actions

    👋 Hey there, it looks like there has been no activity on this issue in the last 90 days. Has the issue been fixed, or does it still require the community attention? This issue will be closed in the next 7 days if no further activity occurs. Thank you for your contributions.

  2. added
    StaleIssues/PR that are not getting much activity and are closer to be closed
    on Jun 21, 2023
  3. jobpaardekooper commented on Jun 21, 2023

    @jobpaardekooper
    Author

    No response yet so it would not consider this "fixed". (Just commenting so the issue will stay open, as it should)

  4. removed
    StaleIssues/PR that are not getting much activity and are closer to be closed
    on Jun 22, 2023
  5. pedropbazzo commented on Aug 26, 2023

    @pedropbazzo
  6. jobpaardekooper commented on Aug 26, 2023

    @jobpaardekooper
    Author

    @pedropbazzo please see my comment on your PR. I don't think it solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Never gets stalePrevent issues/PRs from getting stale

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions