Cover react/renderer/core with stable API guards (#58374)

Summary:
Pull Request resolved: #58374

Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export.

Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour.

Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules

Differential Revision: D119065020

Author: j-piasecki

packages/react-native/ReactAndroid/build.gradle.kts

@@ -140,6 +140,7 @@ val preparePrefab by
                       ),
                       // react_renderer_core
                       Pair("../ReactCommon/react/renderer/core/", "react/renderer/core/"),
+                      Pair("../ReactCommon/react/renderer/core/React/", "React/"),
                       // react_renderer_css
                       Pair("../ReactCommon/react/renderer/css/", "react/renderer/css/"),
                       Pair("../ReactCommon/react/renderer/css/React/", "React/"),

packages/react-native/ReactCommon/React-Fabric.podspec

@@ -108,13 +108,19 @@ Pod::Spec.new do |s|
     end
 
     ss.source_files         = podspec_sources("react/renderer/core/**/*.{m,mm,cpp,h}", "react/renderer/core/**/*.{h}")
-    ss.exclude_files        = "react/renderer/core/tests"
+    ss.exclude_files        = ["react/renderer/core/tests", "react/renderer/core/React"]
     ss.header_dir           = "react/renderer/core"
     ss.pod_target_xcconfig  = {
       "HEADER_SEARCH_PATHS" => header_search_path.join(" ")
     }
   end
 
+  s.subspec "coreUmbrella" do |ss|
+    ss.source_files         = "react/renderer/core/React/*.h"
+    ss.header_dir           = ""
+    ss.header_mappings_dir  = "react/renderer/core"
+  end
+
   s.subspec "componentregistry" do |ss|
     ss.source_files         = podspec_sources("react/renderer/componentregistry/*.{m,mm,cpp,h}", "react/renderer/componentregistry/*.{h}")
     ss.header_dir           = "react/renderer/componentregistry"

packages/react-native/ReactCommon/react/renderer/core/CMakeLists.txt

@@ -12,11 +12,13 @@ file(GLOB react_renderer_core_SRC CONFIGURE_DEPENDS *.cpp)
 add_library(react_renderer_core OBJECT ${react_renderer_core_SRC})
 
 target_include_directories(react_renderer_core PUBLIC ${REACT_COMMON_DIR})
+target_include_directories(react_renderer_core INTERFACE ${REACT_COMMON_DIR}/react/renderer/core)
 target_link_libraries(react_renderer_core
         folly_runtime
         glog
         jsi
         logger
+        react_cxxstableapi
         react_debug
         react_featureflags
         react_renderer_debug

packages/react-native/ReactCommon/react/renderer/core/ComponentDescriptor.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <react/renderer/core/EventDispatcher.h>
 #include <react/renderer/core/InstanceHandle.h>
 #include <react/renderer/core/Props.h>

packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <memory>
 #include <vector>
 

packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <react/debug/react_native_assert.h>
 #include <react/renderer/core/ConcreteState.h>
 #include <react/renderer/core/Props.h>

packages/react-native/ReactCommon/react/renderer/core/ConcreteState.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <functional>
 #include <memory>
 

packages/react-native/ReactCommon/react/renderer/core/DynamicEventPayload.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <folly/dynamic.h>
 #include <react/renderer/core/EventPayload.h>
 

packages/react-native/ReactCommon/react/renderer/core/DynamicPointerEvent.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <folly/dynamic.h>
 #include <react/renderer/core/DynamicEventPayload.h>
 #include <react/renderer/core/EventPayload.h>

packages/react-native/ReactCommon/react/renderer/core/DynamicPropsUtilities.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <react/cxxstableapi/UmbrellaGuard.h>
+
 #include <folly/dynamic.h>
 #include <react/renderer/core/RawProps.h>