Update module umbrella headers - #58533
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
Summary: Every umbrella header told the reader that React Native's own code should keep using the fine-grained includes. That is wrong for a header React Native exports to consumers: it is preprocessed in the consumer's translation unit, where the fine-grained include raises a hard error from `UmbrellaGuard.h` that `RN_ALLOW_FRAMEWORKS` does not suppress. This diff updates the comment in all 14 umbrella headers to cover that case. Changelog: [Internal] Differential Revision: D120116214
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120116214. |
|
This pull request has been merged in e0d88c4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Every umbrella header told the reader that React Native's own code should keep using the fine-grained includes. That is wrong for a header React Native exports to consumers: it is preprocessed in the consumer's translation unit, where the fine-grained include raises a hard error from
UmbrellaGuard.hthatRN_ALLOW_FRAMEWORKSdoes not suppress. This diff updates the comment in all 14 umbrella headers to cover that case.Changelog: [Internal]
Differential Revision: D120116214