Type the unstable-internals-do-not-use entry point with Flow (#58538) - #58538
Closed
rubennorte wants to merge 3 commits into
Closed
rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120124118. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Summary: The auto-fix map behind `react-native/no-deep-imports` had drifted from the exports declared in `index.js.flow`, so the rule offered fixes that do not type-check and missed fixes it could have offered. It was missing 28 modules, among them EventEmitter, CoreEventTypes, PlatformTypes, RendererProxy, usePressability, AssetRegistry and the virtual collection components. It still listed `InteractionManager`, which has been removed from the public API and whose root getter now throws in development, and `Touchable`, which is a value-only runtime re-export absent from the published types — auto-fixing either one produces broken code. It also carried a malformed `./Libraries/Utilities/PlatformTypes` key and two type names, `NativeMethods` and `NativeMethodsMixin`, that the root module does not export. The map is now generated from `index.js.flow`, so it tracks the real surface. Two groups of exports stay out of the map on purpose. The rule keeps reporting those deep imports; it simply does not offer a fix for them. Renamed re-exports such as `NativeText as unstable_NativeText`, and namespace re-exports such as `export * as Systrace`, cannot be expressed by a fixer that only rewrites same-name specifiers. Names published behind an `unstable_` or `experimental_` prefix are excluded as well. They are genuine public exports, but rewriting a deep import of `ViewNativeComponent` into `unstable_NativeView` quietly moves a call site onto an experimental API, and that is a choice the author should make rather than a lint fixer. `InitializeCore` and `RootTagTypes` remain hand-written entries, since neither is derivable from `index.js.flow`: the first has no root export at all and is replaced wholesale by the `react-native/setup-env` entry point, and the second re-exports `RootTag`, which the root does export. Changelog: [General][Fixed] - Align the `react-native/no-deep-imports` auto-fix map with the package's public API Reviewed By: javache Differential Revision: D119678373
Summary: `ViewToken` is already reachable from the package root as `ListViewToken`, but the two types that accompany it in every viewability API — `ViewabilityConfig` and `ViewabilityConfigCallbackPair` — are not exported at all. A call site configuring viewability on `FlatList`, `SectionList` or `VirtualizedList` therefore has to reach into `Libraries/Lists/ViewabilityHelper` for them, even though the props that consume them are public. Both are re-exported from `Libraries/Lists/ViewabilityHelper`, which sources them from `react-native/virtualized-lists`, so this exposes the same declarations the internal path already hands out and adds no new surface beyond the names themselves. Changelog: [General][Added] - Export the `ViewabilityConfig` and `ViewabilityConfigCallbackPair` types from the package root Reviewed By: javache Differential Revision: D120124115
…8538) Summary: `src/unstable-internals-do-not-use.js` is `noflow`, so Flow sees nothing on the other side of `react-native/unstable-internals-do-not-use` and a call site importing from it gets no types at all. TypeScript consumers already have a declaration file; Flow consumers have had nothing. This brings it in line with the sibling secondary entry point, `react-private-interface`, which is `flow strict-local` and pairs the runtime module with a `.js.flow` types entry point: - the module becomes `flow strict-local`, with each lazy getter annotated via `import typeof` and the `unsafe-getters-setters` flowlint disabled, exactly as `react-private-interface.js` and `index.js` do; - a new `unstable-internals-do-not-use.js.flow` declares the same ten exports for consumers. No exports are added or removed and the runtime shape is untouched — the getters are byte-for-byte the same beyond their return annotations. Changelog: [Internal] Reviewed By: javache Differential Revision: D120124118
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D120124118
branch
from
September 15, 2026 13:19
8a1aba7 to
651f208
Compare
|
This pull request has been merged in da03097. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
src/unstable-internals-do-not-use.jsisnoflow, so Flow sees nothing on the other side ofreact-native/unstable-internals-do-not-useand a call site importing from it gets no types at all. TypeScript consumers already have a declaration file; Flow consumers have had nothing.This brings it in line with the sibling secondary entry point,
react-private-interface, which isflow strict-localand pairs the runtime module with a.js.flowtypes entry point:flow strict-local, with each lazy getter annotated viaimport typeofand theunsafe-getters-settersflowlint disabled, exactly asreact-private-interface.jsandindex.jsdo;unstable-internals-do-not-use.js.flowdeclares the same ten exports for consumers.No exports are added or removed and the runtime shape is untouched — the getters are byte-for-byte the same beyond their return annotations.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D120124118