wallet_tests.cpp

// Copyright (c) 2012-2020 The Bitcoin Core developers
// Copyright (c) 2014-2023 The Reddcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#include <wallet/wallet.h>

#include <any>
#include <future>
#include <memory>
#include <stdint.h>
#include <vector>

#include <interfaces/chain.h>
#include <node/blockstorage.h>
#include <node/context.h>
#include <policy/policy.h>
#include <rpc/server.h>
#include <test/util/logging.h>
#include <test/util/setup_common.h>
#include <util/translation.h>
#include <validation.h>
#include <wallet/coincontrol.h>
#include <wallet/test/wallet_test_fixture.h>

#include <boost/test/unit_test.hpp>
#include <univalue.h>

RPCHelpMan importmulti();
RPCHelpMan dumpwallet();
RPCHelpMan importwallet();

extern RecursiveMutex cs_wallets;

// Ensure that fee levels defined in the wallet are at least as high
// as the default levels for node policy.
static_assert(DEFAULT_TRANSACTION_MINFEE >= DEFAULT_MIN_RELAY_TX_FEE, "wallet minimum fee is smaller than default relay fee");
static_assert(WALLET_INCREMENTAL_RELAY_FEE >= DEFAULT_INCREMENTAL_RELAY_FEE, "wallet incremental fee is smaller than default incremental relay fee");

BOOST_FIXTURE_TEST_SUITE(wallet_tests, WalletTestingSetup)

static std::shared_ptr<CWallet> TestLoadWallet(interfaces::Chain* chain)
{
    DatabaseOptions options;
    DatabaseStatus status;
    WalletOptions walletoptions;
    bilingual_str error;
    std::vector<bilingual_str> warnings;

    // Initialize WalletOptions with default bip32 type
    // This is CRITICAL - uninitialized walletType causes SetupGeneration() to fail
    walletoptions.walletType = walletType::bip32Wallet;
    walletoptions.bits = 0;
    walletoptions.importing = false;

    auto database = MakeWalletDatabase("", options, status, error);
    auto wallet = CWallet::Create(chain, "", std::move(database), options.create_flags, walletoptions, error, warnings);
    if (!wallet) {
        std::cerr << "CWallet::Create failed: " << error.original << std::endl;
        return nullptr;
    }
    if (chain) {
        wallet->postInitProcess();
    }
    return wallet;
}

static void TestUnloadWallet(std::shared_ptr<CWallet>&& wallet)
{
    SyncWithValidationInterfaceQueue();
    wallet->m_chain_notifications_handler.reset();
    UnloadWallet(std::move(wallet));
}

static CMutableTransaction TestSimpleSpend(const CTransaction& from, uint32_t index, const CKey& key, const CScript& pubkey)
{
    CMutableTransaction mtx;
    mtx.vout.push_back({from.vout[index].nValue - DEFAULT_TRANSACTION_MAXFEE, pubkey});
    mtx.vin.push_back({CTxIn{from.GetHash(), index}});
    FillableSigningProvider keystore;
    keystore.AddKey(key);
    std::map<COutPoint, Coin> coins;
    coins[mtx.vin[0].prevout].out = from.vout[index];
    std::map<int, std::string> input_errors;
    BOOST_CHECK(SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors));
    return mtx;
}

static void AddKey(CWallet& wallet, const CKey& key)
{
    auto spk_man = wallet.GetOrCreateLegacyScriptPubKeyMan();
    LOCK2(wallet.cs_wallet, spk_man->cs_KeyStore);
    spk_man->AddKeyPubKey(key, key.GetPubKey());
}

BOOST_FIXTURE_TEST_CASE(scan_for_wallet_transactions, TestChain100Setup)
{
    // TestChain100Setup already has 100 blocks (90 PoW + 11 PoS)
    // Cap last block file size, and stake 2 more PoS blocks in a new block file
    CBlockIndex* oldTip = m_node.chainman->ActiveChain().Tip();
    GetBlockFileInfo(oldTip->GetBlockPos().nFile)->nSize = MAX_BLOCKFILE_SIZE;
    stakeBlocks(2);
    CBlockIndex* newTip = m_node.chainman->ActiveChain().Tip();

    // Verify ScanForWalletTransactions fails to read an unknown start block.
    {
        CWallet wallet(m_node.chain.get(), "", CreateDummyWalletDatabase());
        {
            LOCK(wallet.cs_wallet);
            wallet.SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }
        AddKey(wallet, coinbaseKey);
        WalletRescanReserver reserver(wallet);
        reserver.reserve();
        CWallet::ScanResult result = wallet.ScanForWalletTransactions({} /* start_block */, 0 /* start_height */, {} /* max_height */, reserver, false /* update */);
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::FAILURE);
        BOOST_CHECK(result.last_failed_block.IsNull());
        BOOST_CHECK(result.last_scanned_block.IsNull());
        BOOST_CHECK(!result.last_scanned_height);
        BOOST_CHECK_EQUAL(wallet.GetBalance().m_mine_immature, 0);
    }

    // Verify ScanForWalletTransactions picks up transactions in both the old
    // and new block files.
    {
        CWallet wallet(m_node.chain.get(), "", CreateDummyWalletDatabase());
        {
            LOCK(wallet.cs_wallet);
            wallet.SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }
        AddKey(wallet, coinbaseKey);
        WalletRescanReserver reserver(wallet);
        reserver.reserve();
        CWallet::ScanResult result = wallet.ScanForWalletTransactions(oldTip->GetBlockHash(), oldTip->nHeight, {} /* max_height */, reserver, false /* update */);
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::SUCCESS);
        BOOST_CHECK(result.last_failed_block.IsNull());
        BOOST_CHECK_EQUAL(result.last_scanned_block, newTip->GetBlockHash());
        BOOST_CHECK_EQUAL(*result.last_scanned_height, newTip->nHeight);
        // Note: PoS coinstake outputs include BOTH the staked coin value AND the reward
        // Block 100 stakes a large coin (from premine blocks 1-10 which have 545M RDD each)
        // Blocks 101-102 stake smaller coins (from PoW blocks 11-89 which have 300K RDD each)
        // Expected: ~545-546M RDD from block 100, plus smaller amounts from 101-102
        CAmount balance1 = wallet.GetBalance().m_mine_immature;
        BOOST_CHECK(balance1 >= 545000000 * COIN && balance1 <= 546000000 * COIN);
    }

    // Prune the older block file.
    {
        LOCK(cs_main);
        Assert(m_node.chainman)->m_blockman.PruneOneBlockFile(oldTip->GetBlockPos().nFile);
    }
    UnlinkPrunedFiles({oldTip->GetBlockPos().nFile});

    // Verify ScanForWalletTransactions only picks transactions in the new block
    // file.
    {
        CWallet wallet(m_node.chain.get(), "", CreateDummyWalletDatabase());
        {
            LOCK(wallet.cs_wallet);
            wallet.SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }
        AddKey(wallet, coinbaseKey);
        WalletRescanReserver reserver(wallet);
        reserver.reserve();
        CWallet::ScanResult result = wallet.ScanForWalletTransactions(oldTip->GetBlockHash(), oldTip->nHeight, {} /* max_height */, reserver, false /* update */);
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::FAILURE);
        BOOST_CHECK_EQUAL(result.last_failed_block, oldTip->GetBlockHash());
        BOOST_CHECK_EQUAL(result.last_scanned_block, newTip->GetBlockHash());
        BOOST_CHECK_EQUAL(*result.last_scanned_height, newTip->nHeight);
        // Note: After pruning block 100, only blocks 101-102 remain in new block file
        // These 2 PoS blocks stake coins from PoW blocks (300K RDD each) plus PoS rewards
        // Expected: ~600K-650K RDD total from both blocks
        CAmount balance2 = wallet.GetBalance().m_mine_immature;
        BOOST_CHECK(balance2 >= 600000 * COIN && balance2 <= 650000 * COIN);
    }

    // Prune the remaining block file.
    {
        LOCK(cs_main);
        Assert(m_node.chainman)->m_blockman.PruneOneBlockFile(newTip->GetBlockPos().nFile);
    }
    UnlinkPrunedFiles({newTip->GetBlockPos().nFile});

    // Verify ScanForWalletTransactions scans no blocks.
    {
        CWallet wallet(m_node.chain.get(), "", CreateDummyWalletDatabase());
        {
            LOCK(wallet.cs_wallet);
            wallet.SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }
        AddKey(wallet, coinbaseKey);
        WalletRescanReserver reserver(wallet);
        reserver.reserve();
        CWallet::ScanResult result = wallet.ScanForWalletTransactions(oldTip->GetBlockHash(), oldTip->nHeight, {} /* max_height */, reserver, false /* update */);
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::FAILURE);
        BOOST_CHECK_EQUAL(result.last_failed_block, newTip->GetBlockHash());
        BOOST_CHECK(result.last_scanned_block.IsNull());
        BOOST_CHECK(!result.last_scanned_height);
        BOOST_CHECK_EQUAL(wallet.GetBalance().m_mine_immature, 0);
    }
}

BOOST_FIXTURE_TEST_CASE(importmulti_rescan, TestChain100Setup)
{
    // TestChain100Setup already has 100 blocks (90 PoW + 11 PoS)
    // Cap last block file size, and stake new block in a new block file.
    CBlockIndex* oldTip = m_node.chainman->ActiveChain().Tip();
    GetBlockFileInfo(oldTip->GetBlockPos().nFile)->nSize = MAX_BLOCKFILE_SIZE;
    stakeBlocks(1);
    CBlockIndex* newTip = m_node.chainman->ActiveChain().Tip();

    // Clean up m_wallet before creating test wallet to avoid notification conflicts
    if (m_wallet) {
        RemoveWallet(m_wallet, std::nullopt);
        m_wallet_notifications.reset();
        SyncWithValidationInterfaceQueue();
        m_wallet.reset();
    }

    // Prune the older block file.
    {
        LOCK(cs_main);
        Assert(m_node.chainman)->m_blockman.PruneOneBlockFile(oldTip->GetBlockPos().nFile);
    }
    UnlinkPrunedFiles({oldTip->GetBlockPos().nFile});

    // Verify importmulti RPC returns failure for a key whose creation time is
    // before the missing block, and success for a key whose creation time is
    // after.
    {
        // Set the global RPC wallet context to our test wallet for importmulti RPC
        std::shared_ptr<CWallet> wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateDummyWalletDatabase());
        wallet->SetupLegacyScriptPubKeyMan();
        WITH_LOCK(wallet->cs_wallet, wallet->SetLastBlockProcessed(newTip->nHeight, newTip->GetBlockHash()));

        // Add wallet to global list for RPC access, but do NOT register for notifications
        // This avoids deadlock with m_wallet which is already registered for notifications
        AddWallet(wallet);
        UniValue keys;
        keys.setArray();
        UniValue key;
        key.setObject();
        key.pushKV("scriptPubKey", HexStr(GetScriptForRawPubKey(coinbaseKey.GetPubKey())));
        key.pushKV("timestamp", 0);
        key.pushKV("internal", UniValue(true));
        keys.push_back(key);
        key.clear();
        key.setObject();
        CKey futureKey;
        futureKey.MakeNewKey(true);
        key.pushKV("scriptPubKey", HexStr(GetScriptForRawPubKey(futureKey.GetPubKey())));
        key.pushKV("timestamp", newTip->GetBlockTimeMax() + TIMESTAMP_WINDOW + 1);
        key.pushKV("internal", UniValue(true));
        keys.push_back(key);
        JSONRPCRequest request;
        request.params.setArray();
        request.params.push_back(keys);

        UniValue response = importmulti().HandleRequest(request);
        BOOST_CHECK_EQUAL(response.write(),
            strprintf("[{\"success\":false,\"error\":{\"code\":-1,\"message\":\"Rescan failed for key with creation "
                      "timestamp %d. There was an error reading a block from time %d, which is after or within %d "
                      "seconds of key creation, and could contain transactions pertaining to the key. As a result, "
                      "transactions and coins using this key may not appear in the wallet. This error could be caused "
                      "by pruning or data corruption (see reddcoind log for details) and could be dealt with by "
                      "downloading and rescanning the relevant blocks (see -reindex and -rescan "
                      "options).\"}},{\"success\":true}]",
                              0, oldTip->GetBlockTimeMax(), TIMESTAMP_WINDOW));
        RemoveWallet(wallet, std::nullopt);
    }
}

// Verify importwallet RPC starts rescan at earliest block with timestamp
// greater or equal than key birthday. Previously there was a bug where
// importwallet RPC would start the scan at the latest block with timestamp less
// than or equal to key birthday.
BOOST_FIXTURE_TEST_CASE(importwallet_rescan, TestChain100Setup)
{
    // Create two blocks with same timestamp to verify that importwallet rescan
    // will pick up both blocks, not just the first.
    const int64_t BLOCK_TIME = m_node.chainman->ActiveChain().Tip()->GetBlockTimeMax() + 5;
    SetMockTime(BLOCK_TIME);

    // Mine 2 blocks at BLOCK_TIME (heights 101, 102)
    stakeBlocks(2);

    // Set key birthday to block time increased by the timestamp window, so
    // rescan will start at the block time.
    const int64_t KEY_TIME = BLOCK_TIME + TIMESTAMP_WINDOW;
    SetMockTime(KEY_TIME);

    // Mine 1 more block at KEY_TIME (height 103)
    stakeBlocks(1);

    // Clean up m_wallet before creating test wallets to avoid notification conflicts
    if (m_wallet) {
        RemoveWallet(m_wallet, std::nullopt);
        m_wallet_notifications.reset();
        SyncWithValidationInterfaceQueue();
        m_wallet.reset();
    }

    std::string backup_file = (gArgs.GetDataDirNet() / "wallet.backup").string();

    // Import key into wallet and call dumpwallet to create backup file.
    {
        std::shared_ptr<CWallet> wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateMockWalletDatabase());
        {
            LOCK2(wallet->cs_wallet, ::cs_main);
            wallet->SetupLegacyScriptPubKeyMan();
            wallet->SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }
        wallet->LoadWallet();
        AddWallet(wallet);

        {
            auto spk_man = wallet->GetOrCreateLegacyScriptPubKeyMan();
            LOCK2(wallet->cs_wallet, spk_man->cs_KeyStore);
            spk_man->mapKeyMetadata[coinbaseKey.GetPubKey().GetID()].nCreateTime = KEY_TIME;
            spk_man->AddKeyPubKey(coinbaseKey, coinbaseKey.GetPubKey());
        }

        JSONRPCRequest request;
        request.params.setArray();
        request.params.push_back(backup_file);

        ::dumpwallet().HandleRequest(request);
        RemoveWallet(wallet, std::nullopt);
    }

    // Call importwallet RPC and verify all blocks with timestamps >= BLOCK_TIME
    // were scanned, and no prior blocks were scanned.
    {
        std::shared_ptr<CWallet> wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateMockWalletDatabase());
        wallet->LoadWallet();
        AddWallet(wallet);
        {
            LOCK(wallet->cs_wallet);
            wallet->SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }

        JSONRPCRequest request;
        request.params.setArray();
        request.params.push_back(backup_file);

        ::importwallet().HandleRequest(request);

        LOCK(wallet->cs_wallet);
        BOOST_CHECK_EQUAL(wallet->mapWallet.size(), 3U);
        BOOST_CHECK_EQUAL(m_coinbase_txns.size(), 103U);
        for (size_t i = 0; i < m_coinbase_txns.size(); ++i) {
            bool found = wallet->GetWalletTx(m_coinbase_txns[i]->GetHash());
            bool expected = i >= 100;
            BOOST_CHECK_EQUAL(found, expected);
        }
        RemoveWallet(wallet, std::nullopt);
    }
}

// Check that GetImmatureCredit() returns a newly calculated value instead of
// the cached value after a MarkDirty() call.
//
// This is a regression test written to verify a bugfix for the immature credit
// function. Similar tests probably should be written for the other credit and
// debit functions.
BOOST_FIXTURE_TEST_CASE(coin_mark_dirty_immature_credit, TestChain100Setup)
{
    CWallet wallet(m_node.chain.get(), "", CreateDummyWalletDatabase());
    auto spk_man = wallet.GetOrCreateLegacyScriptPubKeyMan();
    CWalletTx wtx(&wallet, m_coinbase_txns.back());

    LOCK2(wallet.cs_wallet, spk_man->cs_KeyStore);
    wallet.SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());

    CWalletTx::Confirmation confirm(CWalletTx::Status::CONFIRMED, m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash(), 0);
    wtx.m_confirm = confirm;

    // Call GetImmatureCredit() once before adding the key to the wallet to
    // cache the current immature credit amount, which is 0.
    BOOST_CHECK_EQUAL(wtx.GetImmatureCredit(), 0);

    // Invalidate the cached value, add the key, and make sure a new immature
    // credit amount is calculated.
    wtx.MarkDirty();
    BOOST_CHECK(spk_man->AddKeyPubKey(coinbaseKey, coinbaseKey.GetPubKey()));
    // Block 100 is a PoS block staking a premine UTXO (545M RDD) plus PoS reward (~25,672 RDD)
    BOOST_CHECK_EQUAL(wtx.GetImmatureCredit(), 54502567222632870); // PoS coinstake total
}

static int64_t AddTx(ChainstateManager& chainman, CWallet& wallet, uint32_t lockTime, int64_t mockTime, int64_t blockTime)
{
    CMutableTransaction tx;
    CWalletTx::Confirmation confirm;
    tx.nLockTime = lockTime;
    tx.nTime = lockTime; // Set nTime to lockTime for deterministic hash
    SetMockTime(mockTime);
    CBlockIndex* block = nullptr;
    if (blockTime > 0) {
        LOCK(cs_main);
        auto inserted = chainman.BlockIndex().emplace(GetRandHash(), new CBlockIndex);
        assert(inserted.second);
        const uint256& hash = inserted.first->first;
        block = inserted.first->second;
        block->nTime = blockTime;
        block->phashBlock = &hash;
        confirm = {CWalletTx::Status::CONFIRMED, block->nHeight, hash, 0};
    }

    // If transaction is already in map, to avoid inconsistencies, unconfirmation
    // is needed before confirm again with different block.
    return wallet.AddToWallet(MakeTransactionRef(tx), confirm, [&](CWalletTx& wtx, bool /* new_tx */) {
        wtx.setUnconfirmed();
        return true;
    })->nTimeSmart;
}

// Simple test to verify assignment of CWalletTx::nSmartTime value. Could be
// expanded to cover more corner cases of smart time logic.
BOOST_AUTO_TEST_CASE(ComputeTimeSmart)
{
    // New transaction should use clock time if lower than block time.
    BOOST_CHECK_EQUAL(AddTx(*m_node.chainman, m_wallet, 1, 100, 120), 100);

    // Test that updating existing transaction does not change smart time.
    BOOST_CHECK_EQUAL(AddTx(*m_node.chainman, m_wallet, 1, 200, 220), 100);

    // New transaction should use clock time if there's no block time.
    BOOST_CHECK_EQUAL(AddTx(*m_node.chainman, m_wallet, 2, 300, 0), 300);

    // New transaction should use block time if lower than clock time.
    BOOST_CHECK_EQUAL(AddTx(*m_node.chainman, m_wallet, 3, 420, 400), 400);

    // New transaction should use latest entry time if higher than
    // min(block time, clock time).
    BOOST_CHECK_EQUAL(AddTx(*m_node.chainman, m_wallet, 4, 500, 390), 400);

    // If there are future entries, new transaction should use time of the
    // newest entry that is no more than 300 seconds ahead of the clock time.
    BOOST_CHECK_EQUAL(AddTx(*m_node.chainman, m_wallet, 5, 50, 600), 300);
}

BOOST_AUTO_TEST_CASE(LoadReceiveRequests)
{
    CTxDestination dest = PKHash();
    LOCK(m_wallet.cs_wallet);
    WalletBatch batch{m_wallet.GetDatabase()};
    m_wallet.SetAddressUsed(batch, dest, true);
    m_wallet.SetAddressReceiveRequest(batch, dest, "0", "val_rr0");
    m_wallet.SetAddressReceiveRequest(batch, dest, "1", "val_rr1");

    auto values = m_wallet.GetAddressReceiveRequests();
    BOOST_CHECK_EQUAL(values.size(), 2U);
    BOOST_CHECK_EQUAL(values[0], "val_rr0");
    BOOST_CHECK_EQUAL(values[1], "val_rr1");
}

// Test some watch-only LegacyScriptPubKeyMan methods by the procedure of loading (LoadWatchOnly),
// checking (HaveWatchOnly), getting (GetWatchPubKey) and removing (RemoveWatchOnly) a
// given PubKey, resp. its corresponding P2PK Script. Results of the the impact on
// the address -> PubKey map is dependent on whether the PubKey is a point on the curve
static void TestWatchOnlyPubKey(LegacyScriptPubKeyMan* spk_man, const CPubKey& add_pubkey)
{
    CScript p2pk = GetScriptForRawPubKey(add_pubkey);
    CKeyID add_address = add_pubkey.GetID();
    CPubKey found_pubkey;
    LOCK(spk_man->cs_KeyStore);

    // all Scripts (i.e. also all PubKeys) are added to the general watch-only set
    BOOST_CHECK(!spk_man->HaveWatchOnly(p2pk));
    spk_man->LoadWatchOnly(p2pk);
    BOOST_CHECK(spk_man->HaveWatchOnly(p2pk));

    // only PubKeys on the curve shall be added to the watch-only address -> PubKey map
    bool is_pubkey_fully_valid = add_pubkey.IsFullyValid();
    if (is_pubkey_fully_valid) {
        BOOST_CHECK(spk_man->GetWatchPubKey(add_address, found_pubkey));
        BOOST_CHECK(found_pubkey == add_pubkey);
    } else {
        BOOST_CHECK(!spk_man->GetWatchPubKey(add_address, found_pubkey));
        BOOST_CHECK(found_pubkey == CPubKey()); // passed key is unchanged
    }

    spk_man->RemoveWatchOnly(p2pk);
    BOOST_CHECK(!spk_man->HaveWatchOnly(p2pk));

    if (is_pubkey_fully_valid) {
        BOOST_CHECK(!spk_man->GetWatchPubKey(add_address, found_pubkey));
        BOOST_CHECK(found_pubkey == add_pubkey); // passed key is unchanged
    }
}

// Cryptographically invalidate a PubKey whilst keeping length and first byte
static void PollutePubKey(CPubKey& pubkey)
{
    std::vector<unsigned char> pubkey_raw(pubkey.begin(), pubkey.end());
    std::fill(pubkey_raw.begin()+1, pubkey_raw.end(), 0);
    pubkey = CPubKey(pubkey_raw);
    assert(!pubkey.IsFullyValid());
    assert(pubkey.IsValid());
}

// Test watch-only logic for PubKeys
BOOST_AUTO_TEST_CASE(WatchOnlyPubKeys)
{
    CKey key;
    CPubKey pubkey;
    LegacyScriptPubKeyMan* spk_man = m_wallet.GetOrCreateLegacyScriptPubKeyMan();

    BOOST_CHECK(!spk_man->HaveWatchOnly());

    // uncompressed valid PubKey
    key.MakeNewKey(false);
    pubkey = key.GetPubKey();
    assert(!pubkey.IsCompressed());
    TestWatchOnlyPubKey(spk_man, pubkey);

    // uncompressed cryptographically invalid PubKey
    PollutePubKey(pubkey);
    TestWatchOnlyPubKey(spk_man, pubkey);

    // compressed valid PubKey
    key.MakeNewKey(true);
    pubkey = key.GetPubKey();
    assert(pubkey.IsCompressed());
    TestWatchOnlyPubKey(spk_man, pubkey);

    // compressed cryptographically invalid PubKey
    PollutePubKey(pubkey);
    TestWatchOnlyPubKey(spk_man, pubkey);

    // invalid empty PubKey
    pubkey = CPubKey();
    TestWatchOnlyPubKey(spk_man, pubkey);
}

class ListCoinsTestingSetup : public TestChain100Setup
{
public:
    ListCoinsTestingSetup()
    {
        // Use PoS block since PoW ended at height 90
        stakeBlocks(1);
        wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateMockWalletDatabase());
        {
            LOCK2(wallet->cs_wallet, ::cs_main);
            wallet->SetLastBlockProcessed(m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        }
        wallet->LoadWallet();
        AddKey(*wallet, coinbaseKey);
        WalletRescanReserver reserver(*wallet);
        reserver.reserve();
        CWallet::ScanResult result = wallet->ScanForWalletTransactions(m_node.chainman->ActiveChain().Genesis()->GetBlockHash(), 0 /* start_height */, {} /* max_height */, reserver, false /* update */);
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::SUCCESS);
        BOOST_CHECK_EQUAL(result.last_scanned_block, m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        BOOST_CHECK_EQUAL(*result.last_scanned_height, m_node.chainman->ActiveChain().Height());
        BOOST_CHECK(result.last_failed_block.IsNull());
    }

    ~ListCoinsTestingSetup()
    {
        wallet.reset();
    }

    CWalletTx& AddTx(CRecipient recipient)
    {
        CTransactionRef tx;
        CAmount fee;
        int changePos = -1;
        bilingual_str error;
        CCoinControl dummy;
        FeeCalculation fee_calc_out;
        {
            BOOST_CHECK(wallet->CreateTransaction({recipient}, tx, fee, changePos, error, dummy, fee_calc_out));
        }
        wallet->CommitTransaction(tx, {}, {});
        CMutableTransaction blocktx;
        {
            LOCK(wallet->cs_wallet);
            blocktx = CMutableTransaction(*wallet->mapWallet.at(tx->GetHash()).tx);
        }
        // Use PoS block since PoW ended at height 90
        CreateAndProcessPoSBlock({CMutableTransaction(blocktx)}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()), wallet);

        LOCK(wallet->cs_wallet);
        wallet->SetLastBlockProcessed(wallet->GetLastBlockHeight() + 1, m_node.chainman->ActiveChain().Tip()->GetBlockHash());
        auto it = wallet->mapWallet.find(tx->GetHash());
        BOOST_CHECK(it != wallet->mapWallet.end());
        CWalletTx::Confirmation confirm(CWalletTx::Status::CONFIRMED, m_node.chainman->ActiveChain().Height(), m_node.chainman->ActiveChain().Tip()->GetBlockHash(), 1);
        it->second.m_confirm = confirm;
        return it->second;
    }

    std::shared_ptr<CWallet> wallet;
};

BOOST_FIXTURE_TEST_CASE(ListCoins, ListCoinsTestingSetup)
{
    std::string coinbaseAddress = coinbaseKey.GetPubKey().GetID().ToString();

    // Confirm ListCoins initially returns 1 coin grouped under coinbaseKey
    // address.
    std::map<CTxDestination, std::vector<COutput>> list;
    {
        LOCK(wallet->cs_wallet);
        list = wallet->ListCoins();
    }
    BOOST_CHECK_EQUAL(list.size(), 1U);
    BOOST_CHECK_EQUAL(std::get<PKHash>(list.begin()->first).ToString(), coinbaseAddress);
    BOOST_CHECK_EQUAL(list.begin()->second.size(), 29U); // 40 mature blocks (1-40) minus 11 spent in PoS stakes

    // Check initial balance from mature coinbase transactions.
    // At height 101: 29 unspent mature coins (some early coinbases were consumed by PoS staking)
    BOOST_CHECK_EQUAL(4366300000 * COIN, wallet->GetAvailableBalance());

    // Add a transaction creating a change address, and confirm ListCoins still
    // returns the coin associated with the change address underneath the
    // coinbaseKey pubkey, even though the change address has a different
    // pubkey.
    AddTx(CRecipient{GetScriptForRawPubKey({}), 1 * COIN, false /* subtract fee */});
    {
        LOCK(wallet->cs_wallet);
        list = wallet->ListCoins();
    }
    BOOST_CHECK_EQUAL(list.size(), 1U);
    BOOST_CHECK_EQUAL(std::get<PKHash>(list.begin()->first).ToString(), coinbaseAddress);
    BOOST_CHECK_EQUAL(list.begin()->second.size(), 31U); // 29 mature + 1 change + 1 coinstake from PoS block

    // Lock all coins. Confirm number of available coins drops to 0.
    {
        LOCK(wallet->cs_wallet);
        std::vector<COutput> available;
        wallet->AvailableCoins(available);
        BOOST_CHECK_EQUAL(available.size(), 31U);
    }
    for (const auto& group : list) {
        for (const auto& coin : group.second) {
            LOCK(wallet->cs_wallet);
            wallet->LockCoin(COutPoint(coin.tx->GetHash(), coin.i));
        }
    }
    {
        LOCK(wallet->cs_wallet);
        std::vector<COutput> available;
        wallet->AvailableCoins(available);
        BOOST_CHECK_EQUAL(available.size(), 0U);
    }
    // Confirm ListCoins still returns same result as before, despite coins
    // being locked.
    {
        LOCK(wallet->cs_wallet);
        list = wallet->ListCoins();
    }
    BOOST_CHECK_EQUAL(list.size(), 1U);
    BOOST_CHECK_EQUAL(std::get<PKHash>(list.begin()->first).ToString(), coinbaseAddress);
    BOOST_CHECK_EQUAL(list.begin()->second.size(), 31U); // Still shows all coins even when locked
}

BOOST_FIXTURE_TEST_CASE(wallet_disableprivkeys, TestChain100Setup)
{
    std::shared_ptr<CWallet> wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateDummyWalletDatabase());
    wallet->SetupLegacyScriptPubKeyMan();
    wallet->SetMinVersion(FEATURE_LATEST);
    wallet->SetWalletFlag(WALLET_FLAG_DISABLE_PRIVATE_KEYS);
    BOOST_CHECK(!wallet->TopUpKeyPool(1000));
    CTxDestination dest;
    std::string error;
    BOOST_CHECK(!wallet->GetNewDestination(OutputType::BECH32, "", dest, error));
}

// Explicit calculation which is used to test the wallet constant
// We get the same virtual size due to rounding(weight/4) for both use_max_sig values
static size_t CalculateNestedKeyhashInputSize(bool use_max_sig)
{
    // Generate ephemeral valid pubkey
    CKey key;
    key.MakeNewKey(true);
    CPubKey pubkey = key.GetPubKey();

    // Generate pubkey hash
    uint160 key_hash(Hash160(pubkey));

    // Create inner-script to enter into keystore. Key hash can't be 0...
    CScript inner_script = CScript() << OP_0 << std::vector<unsigned char>(key_hash.begin(), key_hash.end());

    // Create outer P2SH script for the output
    uint160 script_id(Hash160(inner_script));
    CScript script_pubkey = CScript() << OP_HASH160 << std::vector<unsigned char>(script_id.begin(), script_id.end()) << OP_EQUAL;

    // Add inner-script to key store and key to watchonly
    FillableSigningProvider keystore;
    keystore.AddCScript(inner_script);
    keystore.AddKeyPubKey(key, pubkey);

    // Fill in dummy signatures for fee calculation.
    SignatureData sig_data;

    if (!ProduceSignature(keystore, use_max_sig ? DUMMY_MAXIMUM_SIGNATURE_CREATOR : DUMMY_SIGNATURE_CREATOR, script_pubkey, sig_data)) {
        // We're hand-feeding it correct arguments; shouldn't happen
        assert(false);
    }

    CTxIn tx_in;
    UpdateInput(tx_in, sig_data);
    return (size_t)GetVirtualTransactionInputSize(tx_in);
}

BOOST_FIXTURE_TEST_CASE(dummy_input_size_test, TestChain100Setup)
{
    BOOST_CHECK_EQUAL(CalculateNestedKeyhashInputSize(false), DUMMY_NESTED_P2WPKH_INPUT_SIZE);
    BOOST_CHECK_EQUAL(CalculateNestedKeyhashInputSize(true), DUMMY_NESTED_P2WPKH_INPUT_SIZE);
}

bool malformed_descriptor(std::ios_base::failure e)
{
    std::string s(e.what());
    return s.find("Missing checksum") != std::string::npos;
}

BOOST_FIXTURE_TEST_CASE(wallet_descriptor_test, BasicTestingSetup)
{
    std::vector<unsigned char> malformed_record;
    CVectorWriter vw(0, 0, malformed_record, 0);
    vw << std::string("notadescriptor");
    vw << (uint64_t)0;
    vw << (int32_t)0;
    vw << (int32_t)0;
    vw << (int32_t)1;

    VectorReader vr(0, 0, malformed_record, 0);
    WalletDescriptor w_desc;
    BOOST_CHECK_EXCEPTION(vr >> w_desc, std::ios_base::failure, malformed_descriptor);
}

//! Test wallet transaction detection in a PoS environment with proper notification handling.
//!
//! This test verifies that wallets correctly detect transactions in two scenarios:
//! 1. PHASE 1: Transactions created before wallet load, detected via rescan and queued notifications
//! 2. PHASE 2: Transactions created after wallet load, detected via immediate notifications
//!
//! Unlike the original CreateWallet test, this version:
//! - Uses PoS blocks (staking) instead of PoW (mining) since PoW ends at height 89
//! - Properly initializes a temporary staking wallet with full rescan for PoS block creation
//! - Uses mature coinbase outputs (60+ confirmations) to avoid premature spend errors
//! - Tests both blockchain rescan and real-time notification paths
BOOST_FIXTURE_TEST_CASE(CreateWallet, TestChain100Setup)
{
    gArgs.ForceSetArg("-unsafesqlitesync", "1");

    CKey key;
    key.MakeNewKey(true);
    std::shared_ptr<CWallet> wallet;

    // Add log hook to detect AddToWallet events from rescans, blockConnected,
    // and transactionAddedToMempool notifications
    int addtx_count = 0;
    DebugLogHelper addtx_counter("[default wallet] AddToWallet", [&](const std::string* s) {
        if (s) ++addtx_count;
        return false;
    });

    bool rescan_completed = false;
    DebugLogHelper rescan_check("[default wallet] Rescan completed", [&](const std::string* s) {
        if (s) rescan_completed = true;
        return false;
    });

    // Block the queue to prevent the wallet receiving blockConnected and
    // transactionAddedToMempool notifications, and create block and mempool
    // transactions paying to the wallet
    std::promise<void> promise;
    CallFunctionInValidationInterfaceQueue([&promise] {
        promise.get_future().wait();
    });
    std::string error;

    // Create PROPERLY INITIALIZED temporary staking wallet since we're at height 101+ (PoW ended at 89)
    auto temp_staking_wallet = std::make_shared<CWallet>(m_node.chain.get(), "temp_staking", CreateMockWalletDatabase());
    {
        LOCK2(temp_staking_wallet->cs_wallet, ::cs_main);
        temp_staking_wallet->SetupLegacyScriptPubKeyMan();
        temp_staking_wallet->SetLastBlockProcessed(
            m_node.chainman->ActiveChain().Height(),
            m_node.chainman->ActiveChain().Tip()->GetBlockHash()
        );
    }
    temp_staking_wallet->LoadWallet();
    AddWallet(temp_staking_wallet);

    // Register for block notifications (CRITICAL for coinstake processing!)
    auto temp_wallet_notifications = m_node.chain->handleNotifications(temp_staking_wallet);

    AddKey(*temp_staking_wallet, coinbaseKey);

    // Rescan blockchain to find coins for staking
    {
        WalletRescanReserver reserver(*temp_staking_wallet);
        if (!reserver.reserve()) {
            throw std::runtime_error("Failed to reserve wallet for rescan");
        }
        CWallet::ScanResult result = temp_staking_wallet->ScanForWalletTransactions(
            m_node.chainman->ActiveChain().Genesis()->GetBlockHash(),
            0, {}, reserver, false
        );
        if (result.status == CWallet::ScanResult::FAILURE) {
            throw std::runtime_error("Wallet rescan failed");
        }
    }

    // Wait for wallet to be fully synced with the chain
    temp_staking_wallet->BlockUntilSyncedToCurrentChain();

    // Create first PoS block (block 101) with coinstake only
    m_coinbase_txns.push_back(
        CreateAndProcessPoSBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()),
                                 temp_staking_wallet).vtx[0]
    );

    // Create a transaction spending from block 101's coinstake
    auto mempool_tx = TestSimpleSpend(*m_coinbase_txns[0], 0, coinbaseKey,
                                       GetScriptForRawPubKey(key.GetPubKey()));

    BOOST_CHECK(m_node.chain->broadcastTransaction(MakeTransactionRef(mempool_tx),
                                                     DEFAULT_TRANSACTION_MAXFEE, false, error));

    // Reload wallet and make sure new transaction is detected despite events being blocked
    // PHASE 1: Loading test wallet (should detect tx via rescan)
    {
        // Create wallet using simple constructor (no keypool generation)
        wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateDummyWalletDatabase());
        {
            LOCK2(wallet->cs_wallet, ::cs_main);
            wallet->SetupLegacyScriptPubKeyMan();
            wallet->SetLastBlockProcessed(
                m_node.chainman->ActiveChain().Height(),
                m_node.chainman->ActiveChain().Tip()->GetBlockHash()
            );
        }
        // Register for notifications
        AddWallet(wallet);
        wallet->m_chain_notifications_handler = m_node.chain->handleNotifications(wallet);

        AddKey(*wallet, key);

        // Manually trigger rescan
        WalletRescanReserver reserver(*wallet);
        BOOST_CHECK(reserver.reserve());
        CWallet::ScanResult result = wallet->ScanForWalletTransactions(
            m_node.chainman->ActiveChain().Genesis()->GetBlockHash(),
            0, {}, reserver, false
        );
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::SUCCESS);
    }
    BOOST_CHECK(rescan_completed);
    // Rescan should find 0 transactions because mempool_tx is in mempool, not in a block
    BOOST_CHECK_EQUAL(addtx_count, 0);
    {
        LOCK(wallet->cs_wallet);
        // Wallet should NOT have mempool_tx yet (it's in mempool, not rescanned from blocks)
        BOOST_CHECK_EQUAL(wallet->mapWallet.count(mempool_tx.GetHash()), 0U);
    }

    // Unblock notification queue and make sure stale blockConnected and
    // transactionAddedToMempool events are processed
    promise.set_value();
    SyncWithValidationInterfaceQueue();
    // Expected 3 AddToWallet calls:
    // 1. BlockConnected notification for block 101's coinstake (new insert)
    // 2. TransactionAddedToMempool notification for mempool_tx (new insert)
    // 3. Second call for mempool_tx (likely an update, standard Bitcoin Core behavior)
    // Note: AddToWallet can be called multiple times for the same tx (new + updates).
    // The wallet correctly has only 1 instance in mapWallet (verified below).
    BOOST_CHECK_EQUAL(addtx_count, 3);
    {
        LOCK(wallet->cs_wallet);
        // NOW the wallet should have mempool_tx (from TransactionAddedToMempool notification)
        BOOST_CHECK_EQUAL(wallet->mapWallet.count(mempool_tx.GetHash()), 1U);
    }

    RemoveWallet(wallet, std::nullopt);
    wallet->m_chain_notifications_handler.reset();
    wallet.reset();

    // Advance 1 minute to age coins for Phase 2
    SetMockTime(GetTime() + 60);

    // Load wallet again, this time creating new block and mempool transactions
    // paying to the wallet as the wallet finishes loading and syncing the
    // queue so the events have to be handled immediately
    // PHASE 2: Testing immediate notifications during wallet load

    addtx_count = 0;
    CMutableTransaction block_tx;

    // Create PoS block 102 (coinstake only) BEFORE loading wallet
    m_coinbase_txns.push_back(CreateAndProcessPoSBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()), m_wallet).vtx[0]);

    // Advance 1 minute to age coins
    SetMockTime(GetTime() + 60);

    // block_tx: spend from a MATURE PoW coinbase
    // TestChain100Setup created 89 PoW blocks (m_coinbase_txns[0..88])
    // Coinbase maturity = 60 blocks. At height 102, block 42 and earlier are mature.
    // Use index 40 to be safely mature and unlikely to be spent by early PoS staking
    block_tx = TestSimpleSpend(*m_coinbase_txns[40], 0, coinbaseKey, GetScriptForRawPubKey(key.GetPubKey()));

    // Create PoS block 103 with block_tx
    m_coinbase_txns.push_back(CreateAndProcessPoSBlock({block_tx}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()), m_wallet).vtx[0]);

    // Advance 1 minute for mempool tx
    SetMockTime(GetTime() + 60);

    // mempool_tx: spend from a DIFFERENT mature PoW coinbase (not 40)
    // Use index 41 - also mature at height 103 (103 - 41 = 62 > 60)
    mempool_tx = TestSimpleSpend(*m_coinbase_txns[41], 0, coinbaseKey, GetScriptForRawPubKey(key.GetPubKey()));
    BOOST_CHECK(m_node.chain->broadcastTransaction(MakeTransactionRef(mempool_tx), DEFAULT_TRANSACTION_MAXFEE, false, error));

    // NOW create wallet manually (like Phase 1) with key BEFORE notifications are registered
    wallet = std::make_shared<CWallet>(m_node.chain.get(), "", CreateDummyWalletDatabase());
    {
        LOCK2(wallet->cs_wallet, ::cs_main);
        wallet->SetupLegacyScriptPubKeyMan();
        wallet->SetLastBlockProcessed(
            m_node.chainman->ActiveChain().Height(),
            m_node.chainman->ActiveChain().Tip()->GetBlockHash()
        );
    }

    // Add key BEFORE registering for notifications
    AddKey(*wallet, key);

    // Register for notifications
    AddWallet(wallet);
    wallet->m_chain_notifications_handler = m_node.chain->handleNotifications(wallet);

    // Manually trigger rescan (key is already present, will find block_tx in block 103)
    {
        WalletRescanReserver reserver(*wallet);
        BOOST_CHECK(reserver.reserve());
        CWallet::ScanResult result = wallet->ScanForWalletTransactions(
            m_node.chainman->ActiveChain().Genesis()->GetBlockHash(),
            0, {}, reserver, false
        );
        BOOST_CHECK_EQUAL(result.status, CWallet::ScanResult::SUCCESS);
    }

    // After rescan completes, sync with validation interface queue to process any pending notifications
    SyncWithValidationInterfaceQueue();

    // mempool_tx was broadcast before this wallet registered for notifications.
    // Its transactionAddedToMempool notification is dispatched asynchronously, so
    // whether the wallet is registered in time to receive it depends on when the
    // scheduler thread drains the queue. That race made this case fail
    // intermittently on slower runners, with mempool_tx missing from mapWallet.
    // Request the current mempool contents explicitly instead, exactly as
    // CWallet::postInitProcess does when a wallet is loaded for real (this test
    // builds the CWallet directly, so that step is otherwise skipped). Delivery is
    // synchronous, and re-notifying an already added transaction is expected and
    // handled by AddToWallet.
    //
    // Hold cs_wallet across the call like postInitProcess does. requestMempoolTransactions
    // takes cs_main internally, so acquiring it here first keeps the cs_wallet ->
    // cs_main order this test already uses above, instead of inverting it. cs_wallet
    // is recursive, so the nested lock in transactionAddedToMempool is fine.
    {
        LOCK(wallet->cs_wallet);
        m_node.chain->requestMempoolTransactions(*wallet);
    }

    // Verify both target transactions are in the wallet
    {
        LOCK(wallet->cs_wallet);
        BOOST_CHECK_EQUAL(wallet->mapWallet.count(block_tx.GetHash()), 1U);
        BOOST_CHECK_EQUAL(wallet->mapWallet.count(mempool_tx.GetHash()), 1U);
    }

    // Clean up wallets - order matters to avoid deadlocks!
    // 1. Remove test wallet from global wallet list and reset its notification handler
    RemoveWallet(wallet, std::nullopt);
    wallet->m_chain_notifications_handler.reset();

    // 2. Remove staking wallet from global list and reset its notification handler
    RemoveWallet(temp_staking_wallet, std::nullopt);
    temp_wallet_notifications.reset();

    // 3. Now sync with validation queue (all wallets unregistered, safe to sync)
    SyncWithValidationInterfaceQueue();

    // 4. Finally destroy the wallet objects
    wallet.reset();
    temp_staking_wallet.reset();
}

BOOST_FIXTURE_TEST_CASE(CreateWalletWithoutChain, BasicTestingSetup)
{
    auto wallet = TestLoadWallet(nullptr);
    BOOST_CHECK(wallet);
    UnloadWallet(std::move(wallet));
}

BOOST_FIXTURE_TEST_CASE(ZapSelectTx, TestChain100Setup)
{
    LogPrintf("ZapSelectTx: Test starting\n");
    gArgs.ForceSetArg("-unsafesqlitesync", "1");

    CKey key;
    key.MakeNewKey(true);

    std::string error;

    // Create PROPERLY INITIALIZED temporary staking wallet since we're at height 101+ (PoW ended at 89)
    LogPrintf("ZapSelectTx: Creating staking wallet\n");
    auto temp_staking_wallet = std::make_shared<CWallet>(m_node.chain.get(), "temp_staking", CreateMockWalletDatabase());
    {
        LOCK2(temp_staking_wallet->cs_wallet, ::cs_main);
        temp_staking_wallet->SetupLegacyScriptPubKeyMan();
        temp_staking_wallet->SetLastBlockProcessed(
            m_node.chainman->ActiveChain().Height(),
            m_node.chainman->ActiveChain().Tip()->GetBlockHash()
        );
    }
    temp_staking_wallet->LoadWallet();
    AddWallet(temp_staking_wallet);
    LogPrintf("ZapSelectTx: Staking wallet created and added\n");

    // Register for block notifications (CRITICAL for coinstake processing!)
    auto temp_wallet_notifications = m_node.chain->handleNotifications(temp_staking_wallet);
    LogPrintf("ZapSelectTx: Notifications registered\n");

    AddKey(*temp_staking_wallet, coinbaseKey);
    LogPrintf("ZapSelectTx: Coinbase key added to staking wallet\n");

    // Rescan blockchain to find coins for staking
    LogPrintf("ZapSelectTx: Starting blockchain rescan\n");
    {
        WalletRescanReserver reserver(*temp_staking_wallet);
        if (!reserver.reserve()) {
            throw std::runtime_error("Failed to reserve wallet for rescan");
        }
        CWallet::ScanResult result = temp_staking_wallet->ScanForWalletTransactions(
            m_node.chainman->ActiveChain().Genesis()->GetBlockHash(),
            0, {}, reserver, false
        );
        if (result.status == CWallet::ScanResult::FAILURE) {
            throw std::runtime_error("Wallet rescan failed");
        }
    }
    LogPrintf("ZapSelectTx: Rescan completed\n");

    // Wait for wallet to be fully synced with the chain
    LogPrintf("ZapSelectTx: Waiting for wallet sync\n");
    temp_staking_wallet->BlockUntilSyncedToCurrentChain();
    LogPrintf("ZapSelectTx: Wallet synced\n");

    // Advance 1 minute for first block
    SetMockTime(GetTime() + 60);

    LogPrintf("ZapSelectTx: Creating first PoS block\n");
    m_coinbase_txns.push_back(CreateAndProcessPoSBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()), temp_staking_wallet).vtx[0]);
    LogPrintf("ZapSelectTx: First PoS block created\n");

    // Advance 1 minute for second block
    SetMockTime(GetTime() + 60);

    LogPrintf("ZapSelectTx: Creating block_tx\n");
    auto block_tx = TestSimpleSpend(*m_coinbase_txns[40], 0, coinbaseKey, GetScriptForRawPubKey(key.GetPubKey()));
    LogPrintf("ZapSelectTx: block_tx created\n");

    LogPrintf("ZapSelectTx: Creating second PoS block with block_tx\n");
    CreateAndProcessPoSBlock({block_tx}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()), temp_staking_wallet);
    LogPrintf("ZapSelectTx: Second PoS block created\n");

    LogPrintf("ZapSelectTx: Syncing with validation queue\n");
    SyncWithValidationInterfaceQueue();
    LogPrintf("ZapSelectTx: Sync complete\n");

    // NOW create the test wallet AFTER blocks are created
    LogPrintf("ZapSelectTx: Creating test wallet\n");
    auto wallet = TestLoadWallet(m_node.chain.get());
    LogPrintf("ZapSelectTx: Test wallet loaded\n");

    // Add both keys
    AddKey(*wallet, key);
    AddKey(*wallet, coinbaseKey);
    LogPrintf("ZapSelectTx: Keys added to test wallet\n");

    // Rescan to find the transactions
    LogPrintf("ZapSelectTx: Rescanning test wallet\n");
    {
        WalletRescanReserver reserver(*wallet);
        if (!reserver.reserve()) {
            throw std::runtime_error("Failed to reserve test wallet for rescan");
        }
        CWallet::ScanResult result = wallet->ScanForWalletTransactions(
            m_node.chainman->ActiveChain().Genesis()->GetBlockHash(),
            0, {}, reserver, false
        );
        if (result.status == CWallet::ScanResult::FAILURE) {
            throw std::runtime_error("Test wallet rescan failed");
        }
    }
    LogPrintf("ZapSelectTx: Test wallet rescan complete\n");

    wallet->BlockUntilSyncedToCurrentChain();
    LogPrintf("ZapSelectTx: Test wallet synced\n");

    LogPrintf("ZapSelectTx: Running test checks\n");
    {
        auto block_hash = block_tx.GetHash();
        auto prev_hash = m_coinbase_txns[40]->GetHash();

        LOCK(wallet->cs_wallet);
        LogPrintf("ZapSelectTx: Checking HasWalletSpend\n");
        BOOST_CHECK(wallet->HasWalletSpend(prev_hash));
        LogPrintf("ZapSelectTx: Checking mapWallet count\n");
        BOOST_CHECK_EQUAL(wallet->mapWallet.count(block_hash), 1u);

        LogPrintf("ZapSelectTx: Calling ZapSelectTx\n");
        std::vector<uint256> vHashIn{ block_hash }, vHashOut;
        BOOST_CHECK_EQUAL(wallet->ZapSelectTx(vHashIn, vHashOut), DBErrors::LOAD_OK);
        LogPrintf("ZapSelectTx: ZapSelectTx completed\n");

        LogPrintf("ZapSelectTx: Verifying zap results\n");
        BOOST_CHECK(!wallet->HasWalletSpend(prev_hash));
        BOOST_CHECK_EQUAL(wallet->mapWallet.count(block_hash), 0u);
        LogPrintf("ZapSelectTx: Verification complete\n");
    }

    // Clean up wallets - order matters to avoid deadlocks!
    LogPrintf("ZapSelectTx: Starting cleanup\n");
    // 1. Remove staking wallet from global list and reset its notification handler
    LogPrintf("ZapSelectTx: Removing staking wallet\n");
    RemoveWallet(temp_staking_wallet, std::nullopt);
    temp_wallet_notifications.reset();
    LogPrintf("ZapSelectTx: Staking wallet removed\n");

    // 2. Sync with validation queue (staking wallet unregistered, safe to sync)
    LogPrintf("ZapSelectTx: Syncing validation queue for cleanup\n");
    SyncWithValidationInterfaceQueue();
    LogPrintf("ZapSelectTx: Sync complete\n");

    // 3. Destroy the staking wallet object
    LogPrintf("ZapSelectTx: Destroying staking wallet\n");
    temp_staking_wallet.reset();
    LogPrintf("ZapSelectTx: Staking wallet destroyed\n");

    // 4. Finally unload the test wallet
    LogPrintf("ZapSelectTx: Unloading test wallet\n");
    TestUnloadWallet(std::move(wallet));
    LogPrintf("ZapSelectTx: Test complete\n");
}

BOOST_AUTO_TEST_SUITE_END()