Removed reset-all endpoint and related code, updated thread block delay input to seconds.

rhamlett_microsoft · rhamlett_microsoft · commit 46ce7bb9c032 · 2026-02-04T13:46:12.000-05:00
diff --git a/README.md b/README.md
@@ -159,7 +159,6 @@ The slow request simulator generates requests using three different sync-over-as
 
 | Endpoint | Method | Description |
 |----------|--------|-------------|
-| `/api/admin/reset-all` | POST | Release all memory and reset state |
 | `/api/admin/stats` | GET | Get current simulation statistics |
 
 ## ⏱️ Request Latency Monitor
diff --git a/specs/001-perf-problem-simulator/contracts/openapi.yaml b/specs/001-perf-problem-simulator/contracts/openapi.yaml
@@ -295,45 +295,6 @@ paths:
               schema:
                 $ref: '#/components/schemas/ThreadPoolMetrics'
 
-  /api/reset-all:
-    post:
-      tags:
-        - Control
-      summary: Reset all simulations
-      description: |
-        Stops all active CPU and thread blocking simulations, releases all allocated memory,
-        and optionally forces garbage collection. Use this to return the application to
-        baseline state.
-      operationId: resetAll
-      requestBody:
-        required: false
-        content:
-          application/json:
-            schema:
-              type: object
-              properties:
-                forceGarbageCollection:
-                  type: boolean
-                  default: true
-      responses:
-        '200':
-          description: All simulations reset
-          content:
-            application/json:
-              schema:
-                type: object
-                properties:
-                  message:
-                    type: string
-                    example: All simulations have been reset
-                  simulationsStopped:
-                    type: integer
-                    example: 3
-                  memoryReleasedBytes:
-                    type: integer
-                    format: int64
-                    example: 524288000
-
   /api/health:
     get:
       tags:
diff --git a/specs/001-perf-problem-simulator/data-model.md b/specs/001-perf-problem-simulator/data-model.md
@@ -79,16 +79,6 @@ Represents a request to trigger sync-over-async thread blocking.
 
 ---
 
-### ResetRequest
-
-Represents a request to reset all active simulations.
-
-| Field | Type | Required | Default | Constraints | Description |
-|-------|------|----------|---------|-------------|-------------|
-| `ForceGarbageCollection` | `bool` | No | true | N/A | Whether to force GC after releasing memory |
-
----
-
 ## Domain Models
 
 ### AllocatedMemoryBlock
@@ -105,7 +95,7 @@ Represents a chunk of memory intentionally held by the application.
 **Lifecycle:**
 1. Created when `/api/allocate-memory` is called
 2. Held in static collection (prevents GC)
-3. Released when `/api/release-memory` or `/api/reset-all` is called
+3. Released when `/api/release-memory` is called
 4. After release, GC may collect (timing not guaranteed)
 
 ---
diff --git a/specs/001-perf-problem-simulator/plan.md b/specs/001-perf-problem-simulator/plan.md
@@ -77,7 +77,7 @@ src/
     │   ├── MemoryController.cs       # POST /api/allocate-memory, POST /api/release-memory
     │   ├── ThreadBlockController.cs  # POST /api/trigger-sync-over-async
     │   ├── MetricsController.cs      # GET /api/metrics/*
-    │   └── AdminController.cs        # POST /api/reset-all
+    │   └── AdminController.cs        # GET /api/admin/stats
     │
     ├── Services/                     # Business logic
     │   ├── ICpuStressService.cs
diff --git a/specs/001-perf-problem-simulator/quickstart.md b/specs/001-perf-problem-simulator/quickstart.md
@@ -109,13 +109,6 @@ curl -X POST https://localhost:5001/api/trigger-sync-over-async `
 - Response times for ALL endpoints increase
 - CPU and memory appear normal (the key diagnostic clue!)
 
-### Reset Everything
-
-```powershell
-# Stop all simulations and release memory
-curl -X POST https://localhost:5001/api/reset-all
-```
-
 ---
 
 ## Environment Configuration
diff --git a/specs/001-perf-problem-simulator/tasks.md b/specs/001-perf-problem-simulator/tasks.md
@@ -201,14 +201,8 @@
 
 **Purpose**: Cross-cutting control features that affect multiple user stories
 
-### Tests
-
-- [ ] T063 [P] Integration test for POST /api/reset-all endpoint in tests/PerfProblemSimulator.Tests/Integration/AdminEndpointTests.cs
-
 ### Implementation
 
-- [ ] T064 Create AdminController with POST /api/reset-all endpoint in src/PerfProblemSimulator/Controllers/AdminController.cs
-- [ ] T065 Implement reset logic: cancel active simulations, release memory, optional GC
 - [ ] T066 Add request logging for admin operations
 
 ---
diff --git a/src/PerfProblemSimulator/Controllers/AdminController.cs b/src/PerfProblemSimulator/Controllers/AdminController.cs
@@ -44,63 +44,6 @@ public AdminController(
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));
     }
 
-    /// <summary>
-    /// Resets all active simulations and releases allocated memory.
-    /// </summary>
-    /// <remarks>
-    /// <para>
-    /// This endpoint performs a full reset of the simulator:
-    /// </para>
-    /// <list type="bullet">
-    /// <item>Releases all allocated memory blocks</item>
-    /// <item>Forces garbage collection</item>
-    /// <item>Clears active simulation tracking (CPU/ThreadBlock simulations will complete naturally)</item>
-    /// </list>
-    /// <para>
-    /// <strong>Note:</strong> CPU stress and thread blocking simulations cannot be instantly
-    /// cancelled - they will complete their configured duration. Only memory allocations
-    /// are immediately released.
-    /// </para>
-    /// </remarks>
-    /// <returns>Summary of the reset operation.</returns>
-    /// <response code="200">Reset completed successfully.</response>
-    [HttpPost("reset-all")]
-    [ProducesResponseType(typeof(ResetAllResponse), StatusCodes.Status200OK)]
-    public IActionResult ResetAll()
-    {
-        var clientIp = HttpContext.Connection.RemoteIpAddress?.ToString();
-        _logger.LogWarning(
-            "⚠️ Reset-all requested from {ClientIP}. Releasing all resources...",
-            clientIp);
-
-        // Get state before reset
-        var activeSimulations = _simulationTracker.GetActiveSimulations();
-        var memoryStatus = _memoryPressureService.GetMemoryStatus();
-
-        // Release memory (this also unregisters from tracker)
-        var releaseResult = _memoryPressureService.ReleaseAllMemory(forceGc: true);
-
-        _logger.LogInformation(
-            "Reset complete: Released {BlocksReleased} memory blocks ({BytesReleased} bytes), " +
-            "had {ActiveSimulations} active simulations",
-            releaseResult.ReleasedBlockCount,
-            releaseResult.ReleasedBytes,
-            activeSimulations.Count);
-
-        return Ok(new ResetAllResponse
-        {
-            Success = true,
-            Message = "Reset completed. Memory released. Note: CPU and ThreadBlock simulations will complete naturally.",
-            MemoryBlocksReleased = releaseResult.ReleasedBlockCount,
-            BytesReleased = releaseResult.ReleasedBytes,
-            ActiveSimulationsAtReset = activeSimulations.Count,
-            SimulationTypesActive = activeSimulations
-                .GroupBy(s => s.Type)
-                .ToDictionary(g => g.Key.ToString(), g => g.Count()),
-            GarbageCollectionForced = true
-        });
-    }
-
     /// <summary>
     /// Gets current simulation statistics.
     /// </summary>
@@ -149,47 +92,6 @@ public IActionResult GetStats()
     }
 }
 
-/// <summary>
-/// Response from the reset-all operation.
-/// </summary>
-public class ResetAllResponse
-{
-    /// <summary>
-    /// Whether the reset was successful.
-    /// </summary>
-    public bool Success { get; init; }
-
-    /// <summary>
-    /// Human-readable message about the reset.
-    /// </summary>
-    public required string Message { get; init; }
-
-    /// <summary>
-    /// Number of memory blocks that were released.
-    /// </summary>
-    public int MemoryBlocksReleased { get; init; }
-
-    /// <summary>
-    /// Total bytes of memory that were released.
-    /// </summary>
-    public long BytesReleased { get; init; }
-
-    /// <summary>
-    /// Number of active simulations at the time of reset.
-    /// </summary>
-    public int ActiveSimulationsAtReset { get; init; }
-
-    /// <summary>
-    /// Breakdown of active simulations by type.
-    /// </summary>
-    public Dictionary<string, int> SimulationTypesActive { get; init; } = new();
-
-    /// <summary>
-    /// Whether garbage collection was forced.
-    /// </summary>
-    public bool GarbageCollectionForced { get; init; }
-}
-
 /// <summary>
 /// Current simulation statistics.
 /// </summary>
diff --git a/src/PerfProblemSimulator/wwwroot/css/dashboard.css b/src/PerfProblemSimulator/wwwroot/css/dashboard.css
@@ -672,11 +672,6 @@ body {
     padding: 0.5rem 0.75rem;
 }
 
-.reset-group {
-    border-color: var(--color-primary);
-    background: rgba(0, 120, 212, 0.05);
-}
-
 /* --------------------------------------------------------------------------
    Latency Monitor Section
    -------------------------------------------------------------------------- */
diff --git a/src/PerfProblemSimulator/wwwroot/documentation.html b/src/PerfProblemSimulator/wwwroot/documentation.html
@@ -769,11 +769,6 @@ <h3>Admin Operations</h3>
                     </tr>
                 </thead>
                 <tbody>
-                    <tr>
-                        <td><code>/api/admin/reset-all</code></td>
-                        <td><span class="method-badge method-post">POST</span></td>
-                        <td>Release all memory and reset state</td>
-                    </tr>
                     <tr>
                         <td><code>/api/admin/stats</code></td>
                         <td><span class="method-badge method-get">GET</span></td>
diff --git a/src/PerfProblemSimulator/wwwroot/index.html b/src/PerfProblemSimulator/wwwroot/index.html
@@ -74,8 +74,8 @@ <h3>📊 Memory Pressure</h3>
                 <h3>🧵 Thread Pool Starvation</h3>
                 <p>Blocks threads using sync-over-async anti-pattern.</p>
                 <div class="control-inputs">
-                    <label>Delay (ms):
-                        <input type="number" id="threadDelay" class="wide-input" value="5000" min="100" title="How long each blocking operation delays (minimum 100ms)">
+                    <label>Delay (s):
+                        <input type="number" id="threadDelay" class="wide-input" value="10" min="0.1" step="0.1" title="How long each blocking operation delays in seconds (minimum 0.1s)">
                     </label>
                     <label>Count:
                         <input type="number" id="threadConcurrent" value="100" min="1" title="Number of concurrent blocking operations (minimum 1)">
@@ -124,11 +124,6 @@ <h3>💥 Application Crash</h3>
                 <button class="btn btn-crash" id="btnTriggerCrash">💀 Trigger Crash</button>
                 <p class="crash-warning">⚠️ This will TERMINATE the app!</p>
             </div>
-
-            <div class="control-group reset-group">
-                <h3>🔄 Reset</h3>
-                <button class="btn btn-secondary" id="btnResetAll" style="width: 100%;">🔄 Reset All Simulations</button>
-            </div>
         </div>
     </aside>
 
diff --git a/src/PerfProblemSimulator/wwwroot/js/dashboard.js b/src/PerfProblemSimulator/wwwroot/js/dashboard.js
@@ -840,11 +840,12 @@ async function releaseMemory() {
 }
 
 async function triggerThreadBlock() {
-    const delayMs = parseInt(document.getElementById('threadDelay').value) || 5000;
+    const delaySeconds = parseFloat(document.getElementById('threadDelay').value) || 10;
+    const delayMs = Math.round(delaySeconds * 1000);
     const concurrent = parseInt(document.getElementById('threadConcurrent').value) || 100;
     
     try {
-        logEvent('info', `Triggering thread blocking: ${concurrent} requests, ${delayMs}ms delay...`);
+        logEvent('info', `Triggering thread blocking: ${concurrent} requests, ${delaySeconds}s delay...`);
         const response = await fetch(`${CONFIG.apiBaseUrl}/threadblock/trigger-sync-over-async`, {
             method: 'POST',
             headers: { 'Content-Type': 'application/json' },
@@ -1218,12 +1219,6 @@ document.addEventListener('DOMContentLoaded', () => {
     // Initialize slow request Stop button as disabled
     document.getElementById('btnStopSlowRequests').disabled = true;
     
-    // Wire up Reset All button
-    const btnResetAll = document.getElementById('btnResetAll');
-    if (btnResetAll) {
-        btnResetAll.addEventListener('click', resetAll);
-    }
-    
     // Wire up side panel toggle
     initializeSidePanel();
     
@@ -1285,40 +1280,6 @@ function closeSidePanel() {
     btnToggle.classList.remove('active');
 }
 
-async function resetAll() {
-    if (!confirm('Reset all active simulations and release all memory?')) {
-        return;
-    }
-    
-    try {
-        // Also stop slow requests if running
-        await fetch(`${CONFIG.apiBaseUrl}/slowrequest/stop`, { method: 'POST' }).catch(() => {});
-        
-        // Reset slow request UI
-        const statusDiv = document.getElementById('slowRequestStatus');
-        const startBtn = document.getElementById('btnStartSlowRequests');
-        const stopBtn = document.getElementById('btnStopSlowRequests');
-        if (statusDiv) statusDiv.classList.remove('active');
-        if (startBtn) startBtn.disabled = false;
-        if (stopBtn) stopBtn.disabled = true;
-        
-        const response = await fetch(`${CONFIG.apiBaseUrl}/admin/reset-all`, {
-            method: 'POST'
-        });
-        
-        if (response.ok) {
-            const result = await response.json();
-            logEvent('success', `🔄 Reset complete: ${result.memoryBlocksReleased} memory blocks released`);
-            // Clear all active simulations from the UI
-            clearAllActiveSimulations();
-        } else {
-            logEvent('error', 'Reset failed');
-        }
-    } catch (error) {
-        logEvent('error', `Reset error: ${error.message}`);
-    }
-}
-
 /**
  * Clear all active simulations from state and UI.
  */
diff --git a/tests/PerfProblemSimulator.Tests/Integration/AdminEndpointTests.cs b/tests/PerfProblemSimulator.Tests/Integration/AdminEndpointTests.cs
@@ -15,41 +15,6 @@ public AdminEndpointTests(WebApplicationFactory<Program> factory)
         _client = factory.CreateClient();
     }
 
-    [Fact]
-    public async Task ResetAll_ReturnsOk()
-    {
-        // Act
-        var response = await _client.PostAsync("/api/admin/reset-all", null);
-
-        // Assert
-        Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-
-        var content = await response.Content.ReadAsStringAsync();
-        Assert.Contains("success", content, StringComparison.OrdinalIgnoreCase);
-        Assert.Contains("memoryBlocksReleased", content, StringComparison.OrdinalIgnoreCase);
-        Assert.Contains("bytesReleased", content, StringComparison.OrdinalIgnoreCase);
-    }
-
-    [Fact]
-    public async Task ResetAll_AfterMemoryAllocation_ReleasesMemory()
-    {
-        // Arrange - Allocate some memory first
-        var allocateRequest = new StringContent(
-            """{"sizeInMegabytes": 10}""",
-            System.Text.Encoding.UTF8,
-            "application/json");
-        await _client.PostAsync("/api/memory/allocate-memory", allocateRequest);
-
-        // Act
-        var response = await _client.PostAsync("/api/admin/reset-all", null);
-
-        // Assert
-        Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-
-        var content = await response.Content.ReadAsStringAsync();
-        Assert.Contains("success", content, StringComparison.OrdinalIgnoreCase);
-    }
-
     [Fact]
     public async Task GetStats_ReturnsOk()
     {
diff --git a/tests/PerfProblemSimulator.Tests/Unit/ProblemEndpointGuardTests.cs b/tests/PerfProblemSimulator.Tests/Unit/ProblemEndpointGuardTests.cs
@@ -68,7 +68,7 @@ public async Task InvokeAsync_WhenEndpointsDisabled_BlocksGuardedPaths(string pa
     [Theory]
     [InlineData("/api/health")]
     [InlineData("/api/metrics")]
-    [InlineData("/api/reset-all")]
+    [InlineData("/api/admin/stats")]
     [InlineData("/")]
     [InlineData("/index.html")]
     public async Task InvokeAsync_WhenEndpointsDisabled_AllowsNonGuardedPaths(string path)
