Fixes for slow request simulation and dashboard display.

Author: rhamlett_microsoft

README.md

@@ -150,9 +150,9 @@ The CPU and Memory metric tiles use dynamic color coding based on utilization pe
 ```
 
 The slow request simulator generates requests using three different sync-over-async patterns:
-- **SimpleSyncOverAsync**: Direct `.Wait()` blocking - look for `FetchDataAsync_BLOCKING_HERE` in traces
+- **SimpleSyncOverAsync**: Blocking calls - look for `FetchDataSync_BLOCKING_HERE`, `ProcessDataSync_BLOCKING_HERE`, `SaveDataSync_BLOCKING_HERE` in traces
 - **NestedSyncOverAsync**: Sync methods that block internally - look for `*_BLOCKS_INTERNALLY` methods
-- **DatabasePattern**: Realistic `GetAwaiter().GetResult()` - look for `*_SYNC_BLOCK` methods
+- **DatabasePattern**: Simulated database/HTTP blocking - look for `*Sync_SYNC_BLOCK` methods
 
 ### Admin Operations
 

docs/azure-monitoring-guide.md

@@ -218,13 +218,13 @@ This simulation is designed for **training developers to identify blocking calls
 
 The service uses three different sync-over-async patterns with **intentionally descriptive method names**:
 
-#### Scenario 1: Simple Sync-Over-Async
-Look for method: `FetchDataAsync_BLOCKING_HERE`
+#### Scenario 1: Simple Blocking
+Look for methods: `FetchDataSync_BLOCKING_HERE`, `ProcessDataSync_BLOCKING_HERE`, `SaveDataSync_BLOCKING_HERE`
 ```
-This shows a direct .Wait() call on the async method.
-In the profiler, you'll see threads blocked at:
-  → SlowRequestService.FetchDataAsync_BLOCKING_HERE
-    → Task.Wait()
+These methods use Thread.Sleep to block - clearly visible in profiler.
+In the profiler, you'll see time spent at:
+  → SlowRequestService.FetchDataSync_BLOCKING_HERE
+    → Thread.Sleep
 ```
 
 #### Scenario 2: Nested Sync Methods
@@ -238,12 +238,14 @@ These are synchronous methods that internally call .Wait():
 ```
 
 #### Scenario 3: Database/HTTP Pattern
-Look for methods ending in: `_SYNC_BLOCK`
+Look for methods ending in: `Sync_SYNC_BLOCK`
 ```
-Realistic patterns using GetAwaiter().GetResult():
-  → GetCustomerFromDatabaseAsync_SYNC_BLOCK
-  → CallExternalApiAsync_SYNC_BLOCK
-  → SaveAuditLogAsync_SYNC_BLOCK
+Simulated database and HTTP blocking calls:
+  → GetCustomerFromDatabaseSync_SYNC_BLOCK
+  → GetOrderHistoryFromDatabaseSync_SYNC_BLOCK
+  → CheckInventoryServiceSync_SYNC_BLOCK
+  → GetRecommendationsFromMLServiceSync_SYNC_BLOCK
+  → BuildResponseSync_SYNC_BLOCK
 ```
 
 ### Recommended Settings for CLR Profiler (60s trace)

src/PerfProblemSimulator/Controllers/SlowRequestController.cs

@@ -127,14 +127,14 @@ public IActionResult GetScenarios()
         {
             ["SimpleSyncOverAsync"] = new ScenarioInfo
             {
-                Name = "Simple Sync-Over-Async",
-                Description = "Direct .Result and .Wait() calls on async methods",
-                WhatProfilerShows = "Time blocked at Task.Result, Task.Wait(), and ManualResetEventSlim.Wait",
+                Name = "Simple Blocking",
+                Description = "Direct Thread.Sleep blocking calls that consume time in profiler",
+                WhatProfilerShows = "Time spent in Thread.Sleep - clearly visible as method self-time",
                 MethodsToLookFor = new[]
                 {
-                    "FetchDataAsync_BLOCKING_HERE",
-                    "ProcessDataAsync_BLOCKING_HERE",
-                    "SaveDataAsync_BLOCKING_HERE"
+                    "FetchDataSync_BLOCKING_HERE",
+                    "ProcessDataSync_BLOCKING_HERE",
+                    "SaveDataSync_BLOCKING_HERE"
                 }
             },
             ["NestedSyncOverAsync"] = new ScenarioInfo
@@ -153,15 +153,15 @@ public IActionResult GetScenarios()
             ["DatabasePattern"] = new ScenarioInfo
             {
                 Name = "Database/HTTP Pattern",
-                Description = "GetAwaiter().GetResult() pattern common in legacy code migrations",
-                WhatProfilerShows = "Multiple GetAwaiter().GetResult() calls simulating database and HTTP calls",
+                Description = "Simulated database and HTTP blocking calls",
+                WhatProfilerShows = "Time spent in methods simulating database queries and HTTP calls",
                 MethodsToLookFor = new[]
                 {
-                    "GetCustomerFromDatabaseAsync_SYNC_BLOCK",
-                    "GetOrderHistoryFromDatabaseAsync_SYNC_BLOCK",
-                    "CheckInventoryServiceAsync_SYNC_BLOCK",
-                    "GetRecommendationsFromMLServiceAsync_SYNC_BLOCK",
-                    "BuildResponseAsync_SYNC_BLOCK"
+                    "GetCustomerFromDatabaseSync_SYNC_BLOCK",
+                    "GetOrderHistoryFromDatabaseSync_SYNC_BLOCK",
+                    "CheckInventoryServiceSync_SYNC_BLOCK",
+                    "GetRecommendationsFromMLServiceSync_SYNC_BLOCK",
+                    "BuildResponseSync_SYNC_BLOCK"
                 }
             }
         };