Skip to content

[CI] publish_binaries maybe using an unset variable. #23114

Description

@pcanal

In root-ci-yml at line 625:

 publish_binaries:
...
      working-directory: ${{ env.WORKDIR }}

Claude Sonnet 5 determined (literal quote):

env.WORKDIR in publish_binaries — confirmed undefined, but likely benign today
WORKDIR is not set anywhere: not in the top-level env: block, not in the publish_binaries job. So ${{ env.WORKDIR }} at root-ci.yml:645 references an undefined property, which evaluates to null, which stringifies to '' when interpolated. An empty working-directory is equivalent to omitting it, so the step falls back to the default $GITHUB_WORKSPACE — which happens to be where actions/download-artifact@v8 places files by default (no path: given). So this likely does not currently break the job.

That said, it's still a real quality issue: it's dead/misleading code (almost certainly copy-pasted from root-rn-ci.yml:28, which does define WORKDIR explicitly), and it would silently misbehave if the artifact download default or job defaults ever changed. Worth fixing by either defining WORKDIR in the job's env: or dropping the working-directory key.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status
No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions