From 3585fc68a2ea53193d7d8bede2dcd79135f86d4f Mon Sep 17 00:00:00 2001 From: sai pranav Date: Wed, 19 Aug 2026 16:16:48 +0530 Subject: [PATCH 1/2] [tmva][sofie] Fix broken links in the SOFIE README Three links in tmva/sofie/README.md point at files that no longer exist: - tmva/pymva/src/RModelParser_Keras.cxx - tmva/pymva/src/RModelParser_PyTorch.cxx - tutorials/machine_learning/TMVA_SOFIE_Keras.C The Keras and PyTorch parsers are now implemented in Python under bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/_sofie/_parser/, and the Keras tutorial was ported from .C to .py. Point the links at their current locations. The other nine repository links in the file were checked and resolve correctly. --- tmva/sofie/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tmva/sofie/README.md b/tmva/sofie/README.md index a9b0bfed90528..a462201380e9f 100644 --- a/tmva/sofie/README.md +++ b/tmva/sofie/README.md @@ -20,7 +20,7 @@ make -j8 ``` ## Usage -SOFIE works in a parser-generator working architecture. With SOFIE, the user gets an [ONNX](https://github.com/root-project/root/tree/master/tmva/sofie_parsers), [Keras](https://github.com/root-project/root/blob/master/tmva/pymva/src/RModelParser_Keras.cxx) and a [PyTorch](https://github.com/root-project/root/blob/master/tmva/pymva/src/RModelParser_PyTorch.cxx) parser for translating models in respective formats into SOFIE's internal representation. +SOFIE works in a parser-generator working architecture. With SOFIE, the user gets an [ONNX](https://github.com/root-project/root/tree/master/tmva/sofie_parsers), [Keras](https://github.com/root-project/root/blob/master/bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/_sofie/_parser/_keras/parser.py) and a [PyTorch](https://github.com/root-project/root/blob/master/bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/_sofie/_parser/_pytorch/parser.py) parser for translating models in respective formats into SOFIE's internal representation. From ROOT command line, or in a ROOT macro, we can proceed with an ONNX model: @@ -175,7 +175,7 @@ parser.CheckModel("example_model.ONNX"); - **Tutorials** - [TMVA_SOFIE_Inference](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_Inference.py) - - [TMVA_SOFIE_Keras](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_Keras.C) + - [TMVA_SOFIE_Keras](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_Keras.py) - [TMVA_SOFIE_ONNX](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_ONNX.C) - [TMVA_SOFIE_PyTorch](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_PyTorch.py) - [TMVA_SOFIE_PyTorch_HiggsModel](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_PyTorch_HiggsModel.py) From fe861977a01b651978e943f4c5a26eb6a0021be6 Mon Sep 17 00:00:00 2001 From: R Sai Pranav Date: Thu, 20 Aug 2026 10:29:30 +0530 Subject: [PATCH 2/2] [tmva][sofie] Drop Keras and PyTorch parser references from the README Following review feedback: rather than repointing the links, remove the mentions altogether, since both parsers are being removed in #22734 in favour of going through ONNX export. - the parser-generator paragraph now names only the ONNX parser - the TMVA_SOFIE_Keras, TMVA_SOFIE_PyTorch and TMVA_SOFIE_PyTorch_HiggsModel tutorial links are dropped --- tmva/sofie/README.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tmva/sofie/README.md b/tmva/sofie/README.md index a462201380e9f..6f527b35e5b92 100644 --- a/tmva/sofie/README.md +++ b/tmva/sofie/README.md @@ -20,7 +20,7 @@ make -j8 ``` ## Usage -SOFIE works in a parser-generator working architecture. With SOFIE, the user gets an [ONNX](https://github.com/root-project/root/tree/master/tmva/sofie_parsers), [Keras](https://github.com/root-project/root/blob/master/bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/_sofie/_parser/_keras/parser.py) and a [PyTorch](https://github.com/root-project/root/blob/master/bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/_sofie/_parser/_pytorch/parser.py) parser for translating models in respective formats into SOFIE's internal representation. +SOFIE works in a parser-generator working architecture. With SOFIE, the user gets an [ONNX](https://github.com/root-project/root/tree/master/tmva/sofie_parsers) parser for translating models into SOFIE's internal representation. From ROOT command line, or in a ROOT macro, we can proceed with an ONNX model: @@ -175,12 +175,8 @@ parser.CheckModel("example_model.ONNX"); - **Tutorials** - [TMVA_SOFIE_Inference](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_Inference.py) - - [TMVA_SOFIE_Keras](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_Keras.py) - [TMVA_SOFIE_ONNX](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_ONNX.C) - - [TMVA_SOFIE_PyTorch](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_PyTorch.py) - - [TMVA_SOFIE_PyTorch_HiggsModel](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_PyTorch_HiggsModel.py) - [TMVA_SOFIE_RDataFrame](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_RDataFrame.C) - [TMVA_SOFIE_RDataFrame](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_RDataFrame.py) - [TMVA_SOFIE_RDataFrame_JIT](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_RDataFrame_JIT.C) - [TMVA_SOFIE_RSofieReader](https://github.com/root-project/root/blob/master/tutorials/machine_learning/TMVA_SOFIE_RSofieReader.C) -