fix(fmt): use ignore for pattern matching (#179)

Author: chenjiahan

packages/rstack/THIRD_PARTY_NOTICES.md

@@ -59,34 +59,6 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 
-## fast-ignore
-
-This package includes bundled code from [fast-ignore](https://github.com/fabiospampinato/fast-ignore).
-
-License: MIT
-
-The MIT License (MIT)
-
-Copyright (c) 2023-present Fabio Spampinato
-
-Permission is hereby granted, free of charge, to any person obtaining a
-copy of this software and associated documentation files (the "Software"),
-to deal in the Software without restriction, including without limitation
-the rights to use, copy, modify, merge, publish, distribute, sublicense,
-and/or sell copies of the Software, and to permit persons to whom the
-Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
-
 ## fresh-import
 
 This package includes bundled code from [fresh-import](https://github.com/sapphi-red/fresh-import).

packages/rstack/package.json

@@ -69,7 +69,6 @@
     "@rstest/adapter-rslib": "catalog:",
     "@types/micromatch": "catalog:",
     "@types/node": "catalog:",
-    "fast-ignore": "catalog:",
     "ignore": "catalog:",
     "import-meta-resolve": "catalog:",
     "is-binary-path": "catalog:",

packages/rstack/src/fmt/ignore.ts

@@ -1,6 +1,6 @@
 import { readFile } from 'node:fs/promises';
 import path from 'node:path';
-import fastIgnore from 'fast-ignore';
+import createIgnore from 'ignore';
 import type { ResolvedFmtConfig } from './types.ts';
 
 /**
@@ -21,10 +21,17 @@ interface CreateIgnoreMatcherOptions {
 }
 
 const createPatternMatcher = (rootPath: string, patterns: string): IgnoreMatcher => {
-  const matches = fastIgnore(patterns);
+  const matcher = createIgnore({ allowRelativePaths: true }).add(patterns);
 
-  return (filePath, isDirectory = false) =>
-    matches(path.relative(rootPath, filePath), { isDirectory });
+  return (filePath, isDirectory = false) => {
+    const relativePath = path.relative(rootPath, filePath);
+    if (relativePath === '') {
+      return false;
+    }
+
+    const posixPath = path.sep === '\\' ? relativePath.replaceAll('\\', '/') : relativePath;
+    return matcher.ignores(isDirectory ? `${posixPath}/` : posixPath);
+  };
 };
 
 const loadIgnoreMatcher = async (cwd: string, ignorePath: string): Promise<IgnoreMatcher> => {

packages/rstack/tests/fmt/ignore.test.ts

@@ -38,6 +38,14 @@ test('distinguishes directory-only patterns from files', async () => {
   expect(isIgnored(path.join(directoryPath, 'index.js'))).toBe(true);
 });
 
+test('does not apply negated directory patterns to files', async () => {
+  const isIgnored = await createMatcher(['fixtures/**/*', '!fixtures/**/']);
+  const directoryPath = path.join(rootPath, 'fixtures/case');
+
+  expect(isIgnored(directoryPath, true)).toBe(false);
+  expect(isIgnored(path.join(directoryPath, 'index.js'))).toBe(true);
+});
+
 test('applies negated patterns in declaration order', async () => {
   const isIgnored = await createMatcher(['*.js', '!src/keep.js']);
   const isIgnoredAgain = await createMatcher(['*.js', '!src/keep.js', 'src/keep.js']);

pnpm-lock.yaml

@@ -35,7 +35,6 @@ catalog:
   '@types/react-dom': '^19.2.4'
   '@shikijs/transformers': '^4.3.1'
   'cspell-ban-words': '^0.0.4'
-  'fast-ignore': '2.0.0'
   'happy-dom': '^20.11.1'
   'heading-case': '^1.1.4'
   ignore: 7.0.6