From 8c7ad5d7ed6cd31b969572b1f21421e6bdb7fe1d Mon Sep 17 00:00:00 2001
From: Douglas Eichelberger <doug.eichelberger@gusto.com>
Date: Mon, 17 Aug 2026 12:04:54 -0700
Subject: [PATCH] Add explicit GITHUB_TOKEN permissions to workflows

Resolves the seven open CodeQL actions/missing-workflow-permissions
alerts (#1, #3, #4, #5, #6, #7, #8) by declaring the least privilege
each job actually needs.

ci.yml: one workflow-level `contents: read` covers run_tests,
static_type_check and run_linter -- each only checks out the repo and
runs rspec / srb tc / rubocop. notify_on_failure gets a job-level
`permissions: {}`: it never checks out and posts to Slack through an
incoming webhook secret, so it needs no GitHub token scopes at all.

cd.yml: `contents: write` -- shared-config's cd.yml checks out with
persisted credentials, runs publish-rubygems-action (rake release does a
raw git push of the version tag) and then `gh release create`.

stale.yml: `issues: write` + `pull-requests: write` -- actions/stale
comments on and closes both stale issues and stale PRs.

triage.yml: `issues: write` -- the called workflow runs
`gh issue edit --add-label triage`.

A caller's permissions block is the ceiling for the reusable workflow it
calls, so these grants match what shared-config needs rather than being
clamped to read-only.
---
 .github/workflows/cd.yml     | 2 ++
 .github/workflows/ci.yml     | 4 ++++
 .github/workflows/stale.yml  | 3 +++
 .github/workflows/triage.yml | 2 ++
 4 files changed, 11 insertions(+)

diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index 8cb675f..4c9ab97 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -8,5 +8,7 @@ on:
 
 jobs:
   call-workflow-from-shared-config:
+    permissions:
+      contents: write
     uses: rubyatscale/shared-config/.github/workflows/cd.yml@main
     secrets: inherit
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7f40297..51657a6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -6,6 +6,9 @@ on:
       - main
   pull_request:
 
+permissions:
+  contents: read
+
 jobs:
   run_tests:
     runs-on: ubuntu-latest
@@ -53,6 +56,7 @@ jobs:
         run: bundle exec rubocop
   notify_on_failure:
     runs-on: ubuntu-latest
+    permissions: {}
     needs: [run_tests, static_type_check, run_linter]
     if: ${{ failure() && github.ref == 'refs/heads/main' }}
     env:
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
index 0287d52..2696450 100644
--- a/.github/workflows/stale.yml
+++ b/.github/workflows/stale.yml
@@ -5,4 +5,7 @@ on:
     - cron: '0 0 * * *'
 jobs:
   call-workflow-from-shared-config:
+    permissions:
+      issues: write
+      pull-requests: write
     uses: rubyatscale/shared-config/.github/workflows/stale.yml@main
diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml
index 74bb1d9..7c492ee 100644
--- a/.github/workflows/triage.yml
+++ b/.github/workflows/triage.yml
@@ -6,4 +6,6 @@ on:
       - opened
 jobs:
   call-workflow-from-shared-config:
+    permissions:
+      issues: write
     uses: rubyatscale/shared-config/.github/workflows/triage.yml@main