-
-
Notifications
You must be signed in to change notification settings - Fork 15k
unused_qualification breaks code for older rust versions #129306
Copy link
Copy link
Closed as not planned
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.L-unused_qualificationsLint: unused_qualificationsLint: unused_qualificationsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.L-unused_qualificationsLint: unused_qualificationsLint: unused_qualificationsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Code
Current output
Desired output
The lint should not be triggered as
core::mem::align_ofis only part of the prelude since 1.80 (see #123168)Rationale and extra context
Adding
use core::mem::align_of(orstd::…) and using it that way will not triggerunused_imports(warn-by-default) on 1.80 which is somewhat weird. Applying the fixes forunused_qualificationschanges the MSRV whileunused_importsdoesn't?I somewhat expect this to be closed as won't fix as
rustcitself doesn't care about cargo related settings?Other cases
No response
Rust Version
Anything else?
No response