fix: harden AssistSupport release gates#154
Merged
Merged
Conversation
256ef6d to
7f4ca30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pnpm test:cihost-aware so Linux CI jobs without native GTK pkg-config dependencies skip Tauri cargo tests explicitly while macOS/local runs still execute them.dialog:defaultremains needed.Why
.codex/verify.commands, and missing release runbook coverage.pnpm test:ciruns Tauricargo test, which needsdistto exist because the Tauri config pointsfrontendDistat../dist; placing it afterpnpm build:uikeeps the verifier runnable.How
pnpm test:ciimmediately afterpnpm build:uiin.codex/verify.commands.package.jsonsopnpm test:cirunscargo testwhen native Tauri dependencies are present and prints an explicit skip message on Linux runners missingglib-2.0/gobject-2.0pkg-config metadata.docs/release-runbook.mdwith release preconditions, required gates, evidence capture, signing/notarization boundaries, rollback, and blocking failures.docs/adr/0011-tauri-capabilities-audit.mdwithlocal-first-tauri-capability-reviewedand a scopeddialog:defaultrationale.Testing
/Users/d/.codex/codexkit/scripts/audit/check_local_first_tauri_app_drift.py --fail-on warning --apps AssistSupportpnpm check:workstation-preflightnode scripts/ci/require-tests-and-docs.mjspnpm check:workflow-driftpnpm check:version-paritypnpm exec prettier --check docs/adr/0011-tauri-capabilities-audit.md docs/release-runbook.mdgit diff --checkpnpm build:uipnpm test:ciPerformance impact
pnpm build:ui; no runtime code changed.Risk / Notes
pnpm exec prettier --check .codex/verify.commandsis not supported because Prettier cannot infer a parser for that command-list file, so Markdown files were checked separately.Screenshots (UI only)
Lockfile rationale (if lockfile changed)
Baseline governance (if .perf-baselines changed)
perf-baseline-updatelabel applied: not applicable.