Skip to content

Code fields save a string #12

Description

@groenroos

In the Configuration UI, the "code" field currently saves the object as a string, which is obviously not correct.

Even getting the code editor to work properly thus far took some doing. Feels like the vue-prism-editor is quite fragile, and as it can't take an object as a value, there needs to be some parsing to ensure any field with a code editor first stringifies its content for the editor, and then parses it into an object for saving. All the while making sure these transformations do not trigger reactivity. Also, only Vuex knows which fields are code fields, but the Configuration state needs to stay outside of Vuex to make sure changes aren't visible throughout the UI before they are saved. And some kind of validation might also be useful.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugUnintended behaviour and security vulnerabilitieshelp wantedIssues where help is needed from other contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions