Skip to content

Commit 4d860fc

Browse files
cyntwang99claude
andcommitted
fix(tests): narrow span.data before subscripting in commit-SHA tests
`Span.data` is `dict | list[dict] | None`, so `in` and `[]` need an isinstance guard to satisfy the project-wide pyright run in scripts/lint. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent f4d0b3e commit 4d860fc

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

tests/lib/core/tracing/processors/test_sgp_tracing_processor.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ def test_commit_sha_is_not_stamped_without_opt_in(self, monkeypatch):
6666
env = MagicMock(ACP_TYPE=None, AGENT_NAME=None, AGENT_ID=None, AGENT_VERSION=None)
6767
span = _make_span()
6868
_add_source_to_span(span, env)
69+
assert isinstance(span.data, dict)
6970
assert "__commit_sha__" not in span.data
7071

7172
def test_commit_sha_is_stamped_after_opt_in(self, monkeypatch):
@@ -79,6 +80,7 @@ def test_commit_sha_is_stamped_after_opt_in(self, monkeypatch):
7980
env = MagicMock(ACP_TYPE=None, AGENT_NAME=None, AGENT_ID=None, AGENT_VERSION=None)
8081
span = _make_span()
8182
_add_source_to_span(span, env)
83+
assert isinstance(span.data, dict)
8284
assert span.data["__commit_sha__"] == sha
8385
finally:
8486
code_revision.disable()

0 commit comments

Comments
 (0)