Add matching .fXX suffixes to generator.py - #430
Open
pkhartsk wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthrough
ChangesFedora configuration mapping
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request validationFailed🔴 Failed or pending statuses:
Success🟢 Review - Reviewed by a member Triggered by Workflow Run |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@generator.py`:
- Around line 100-101: Update the relevant function’s docstring and
unmatched-suffix diagnostic to include the newly supported .f<NUM> pattern
alongside .rhelXX, .cXs, and .fedora. Keep the existing validation behavior
unchanged; only expand the documented and reported accepted suffixes.
- Around line 100-101: Update the fedora_match branch in main() to verify that
the generated Fedora config exists in mapping[version] before assigning or
returning it; return "" when the selected multispec does not contain that
config, while preserving the existing config value for supported images.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
pkhartsk
force-pushed
the
add-fxx-to-generator
branch
from
July 13, 2026 15:21
78b0077 to
2703640
Compare
pkhartsk
force-pushed
the
add-fxx-to-generator
branch
from
July 13, 2026 15:23
2703640 to
0f47ef5
Compare
Member
|
[test] |
Member
|
@pkhartsk There is sanity error |
Testing Farm results
|
Main purpose is to enable easy distgenification of the base and core containers. Added a new statement to filename_to_distro_config()
pkhartsk
force-pushed
the
add-fxx-to-generator
branch
from
July 27, 2026 11:08
0f47ef5 to
471f95b
Compare
Member
|
[test] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main purpose is to enable easy distgenification of the base and core containers. Added a new statement to filename_to_distro_config()
Summary by CodeRabbit
*.f<NUM>format are now recognized correctly.