Skip to content

Use "omit" instead of "null" to skip compose - #326

Closed
spetrosi wants to merge 1 commit into
sclorg:mainfrom
spetrosi:compose-null-omit
Closed

spetrosi wants to merge 1 commit into
sclorg:mainfrom
spetrosi:compose-null-omit

Conversation

@spetrosi

@spetrosi spetrosi commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Using null doesn't work because

Using null as suggested by current readme fails with the following error. An example run is here: https://github.com/redhat-cop/infra.leapp/actions/runs/19141825777

Run sclorg/testing-farm-as-github-action@v4
Error: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "null",
    "path": [
      "environments",
      0,
      "os"
    ],
    "message": "Expected object, received null"
  }
]

I've tested my edits in https://github.com/spetrosi/infra.leapp/actions/runs/19170275013/job/54800766505

These changes are generated by Cursor AI

Using null doesn't work because

Using null as suggested by current readme fails with this error.
```
Run sclorg/testing-farm-as-github-action@v4
Error: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "null",
    "path": [
      "environments",
      0,
      "os"
    ],
    "message": "Expected object, received null"
  }
]
```

These changes are generated by Cursor AI
spetrosi added a commit to spetrosi/infra.leapp that referenced this pull request Nov 7, 2025
testing-farm-as-github-action has a bug that prevents from using the action
without specifying the compose.
This is our case because we specify the compose via variables.
Until the PR with the fix is merged, let's use the action from spetrosi branch.
sclorg/testing-farm-as-github-action#326
@codecov

codecov Bot commented Nov 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.20%. Comparing base (1d700fe) to head (9b055c8).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   91.58%   92.20%   +0.62%     
==========================================
  Files          14       14              
  Lines         867      911      +44     
  Branches      162      231      +69     
==========================================
+ Hits          794      840      +46     
+ Misses         73       64       -9     
- Partials        0        7       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamacku

jamacku commented Nov 11, 2025

Copy link
Copy Markdown
Member

Thank you for the PR, but this is not right. You haven't updated the dist/ files, so you are still testing the original code.

But I know where the problem is.

@spetrosi

Copy link
Copy Markdown
Contributor Author

It's shit code, sorry and thank you for looking at it.
Btw my successful run https://github.com/spetrosi/infra.leapp/actions/runs/19170275013/workflow#L199 used compose: null, not compose: omit as I thought, and It worked. So somewhat, my changes fix the issue.
My initial thought that null is a special value in yaml and it was not read as a string nor empty.

@jamacku jamacku self-assigned this Nov 20, 2025
@phracek

phracek commented Jun 16, 2026

Copy link
Copy Markdown
Member

It's shit code, sorry and thank you for looking at it.
Btw my successful run https://github.com/spetrosi/infra.leapp/actions/runs/19170275013/workflow#L199 used compose: null, not compose: omit as I thought, and It worked. So somewhat, my changes fix the issue.
My initial thought that null is a special value in yaml and it was not read as a string nor empty.

@spetrosi Is this still valid? If not please close it.

@spetrosi spetrosi closed this Jun 25, 2026
@spetrosi spetrosi reopened this Jun 25, 2026
@jamacku

jamacku commented Jun 26, 2026

Copy link
Copy Markdown
Member

Closing, since this is no longer needed.

@jamacku jamacku closed this Jun 26, 2026
@spetrosi

Copy link
Copy Markdown
Contributor Author

#326 (comment) it was pointed above that I didn't change dist files that are actually used when action is run, so my use of GH action from this branch was ignored. So this is not a real issue.
redhat-cop/infra.leapp#402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants