fix: Leave pagination params out of the at least one parameter guard (#1008)

* fix: Leave pagination params out of the at least one parameter guard

The at least one parameter guard counted every parameter, so
accessCodes.list({ limit: 10 }) satisfied the guard, and the generated
parameter type, while naming no filter at all, and a page cursor alone
satisfied it from page two onward. Pagination knobs are not filters.

Generate an explicit atLeastOneParameterNames list that excludes limit
and page_cursor, use it for the runtime check instead of scanning every
value, and constrain the generated RequireAtLeastOne parameter types to
the same names so the type level and runtime agree.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2

* docs: Drop the pagination parameter comment

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: razor-x

codegen/layouts/partials/route-class-endpoint-export.hbs

@@ -1,4 +1,4 @@
-export type {{parametersTypeName}} = {{#if requiresAtLeastOneParameter}}RequireAtLeastOne<{{/if}}{{> request-object parameters=parameters}}{{#if requiresAtLeastOneParameter}}>{{/if}}
+export type {{parametersTypeName}} = {{#if requiresAtLeastOneParameter}}RequireAtLeastOne<{{/if}}{{> request-object parameters=parameters}}{{#if requiresAtLeastOneParameter}}, {{atLeastOneParameterNamesUnion}}>{{/if}}
 
 /**
  * @deprecated Use {{requestTypeName}} instead.

codegen/layouts/partials/route-class-endpoint.hbs

@@ -9,6 +9,7 @@
     parameters,
     hasRequiredParameters: {{hasRequiredParameters}},
     requiredParameterNames: [{{#each requiredParameterNames}}{{json .}}{{#unless @last}}, {{/unless}}{{/each}}],
+    atLeastOneParameterNames: [{{#each atLeastOneParameterNames}}{{json .}}{{#unless @last}}, {{/unless}}{{/each}}],
     responseKey: {{#if returnsVoid}}undefined{{else}}'{{responseKey}}'{{/if}},
     {{#if hasPagination}}hasPagination: true,
     {{/if}}options,

codegen/lib/layouts/route.ts

@@ -40,6 +40,8 @@ export interface EndpointLayoutContext {
   hasRequiredParameters: boolean
   requiredParameterNames: string[]
   requiresAtLeastOneParameter: boolean
+  atLeastOneParameterNames: string[]
+  atLeastOneParameterNamesUnion: string
   parameters: Parameter[]
   responseIsList: boolean
   responseResourceTypeName: string
@@ -72,7 +74,9 @@ export const setRouteLayoutContext = (
   file.needsRequireAtLeastOneImport =
     node != null &&
     'endpoints' in node &&
-    node.endpoints.some(requiresAtLeastOneParameter)
+    node.endpoints.some(
+      (endpoint) => getAtLeastOneParameterNames(endpoint).length > 0,
+    )
   file.resourceTypeImports =
     node != null && 'endpoints' in node
       ? [
@@ -155,7 +159,12 @@ export const getEndpointLayoutContext = (
     requiredParameterNames: endpoint.request.parameters
       .filter(({ isRequired }) => isRequired)
       .map(({ name }) => name),
-    requiresAtLeastOneParameter: requiresAtLeastOneParameter(endpoint),
+    requiresAtLeastOneParameter:
+      getAtLeastOneParameterNames(endpoint).length > 0,
+    atLeastOneParameterNames: getAtLeastOneParameterNames(endpoint),
+    atLeastOneParameterNamesUnion: getAtLeastOneParameterNames(endpoint)
+      .map((name) => `'${name}'`)
+      .join(' | '),
     parameters: endpoint.request.parameters,
     responseIsList: endpoint.response.responseType === 'resource_list',
     responseResourceTypeName:
@@ -172,6 +181,15 @@ const requiresAtLeastOneParameter = (endpoint: Endpoint): boolean =>
   endpoint.request.hasRequiredParameters &&
   endpoint.request.parameters.every(({ isRequired }) => !isRequired)
 
+const paginationParameterNames = new Set(['limit', 'page_cursor'])
+
+const getAtLeastOneParameterNames = (endpoint: Endpoint): string[] =>
+  requiresAtLeastOneParameter(endpoint)
+    ? endpoint.request.parameters
+        .map(({ name }) => name)
+        .filter((name) => !paginationParameterNames.has(name))
+    : []
+
 const isActionAttemptEndpoint = (endpoint: Endpoint): boolean =>
   endpoint.response.responseType === 'resource' &&
   endpoint.response.resourceType === 'action_attempt'

src/lib/request-parameters.ts

@@ -10,6 +10,7 @@ export const assertValidRequestParameters = (
   path: string,
   hasRequiredParameters: boolean,
   requiredParameterNames: readonly string[],
+  atLeastOneParameterNames: readonly string[],
 ): void => {
   if (parameters === undefined) {
     if (hasRequiredParameters) {
@@ -37,8 +38,10 @@ export const assertValidRequestParameters = (
   }
 
   if (
-    hasRequiredParameters &&
-    Object.values(parameterValues).every((value) => value === undefined)
+    atLeastOneParameterNames.length > 0 &&
+    atLeastOneParameterNames.every(
+      (name) => parameterValues[name] === undefined,
+    )
   ) {
     throw new TypeError(`At least one parameter is required for ${path}`)
   }