Skip to content
This repository was archived by the owner on Nov 30, 2019. It is now read-only.
This repository was archived by the owner on Nov 30, 2019. It is now read-only.

is there an idiom for ignoring regions? #19

Description

@BurntSushi

To me, ignoring regions means that the "global IP" should always be used and the "local IP" should never be used. One sensible way to do this is to use the same region for every node (the empty string, perhaps) and always set the local and global IP addresses to be the same. However, judging by this code, the local IP ends up getting used. That's probably OK, but it does seem a little weird.

So I guess my question is: is this idiom acceptable? I think it might be cleaner to special case a zero value. For example, if the region is empty, then the global IP is always used. Or if the local IP is empty, then then global is always used.

I realize this is a small point, but I was slightly confused by it until I read the full story on what regions were.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions