`@Valid` annotation WARNs on container types

[ricardozanini]

What happened:
Every build now we can see in the logs:

[WARNING] [org.hibernate.validator.internal.metadata.aggregated.CascadingMetaDataBuilder] HV000271: Using `@Valid` on a container (java.util.Map) is deprecated. You should apply the annotation on the type argument(s). Affected element: additionalProperties
[WARNING] [org.hibernate.validator.internal.metadata.aggregated.CascadingMetaDataBuilder] HV000271: Using `@Valid` on a container (java.util.List) is deprecated. You should apply the annotation on the type argument(s). Affected element: _do
[WARNING] [org.hibernate.validator.internal.metadata.aggregated.CascadingMetaDataBuilder] HV000271: Using `@Valid` on a container (java.util.List) is deprecated. You should apply the annotation on the type argument(s). Affected element: _try

I believe this is a side effect of using Hibernate Validator on our types.

What you expected to happen:
For the build to work without annoying warnings.

How to reproduce it:

Anything else we need to know?:

Environment:

• Specification version used:

[fjtirado]

The issue is that, with the latter version of the hibernate validator, there is a "new" feature and rather than having

@Valid
List<T> list

in order to apply the validation for every element in the list, now you should have

List<@Valid T> list

So, either we move back to the previous hibernate validator (I do not see why not) or we update the generator (which code is not on this repo) in order to generate the code with the annotation in the right spot

[ricardozanini]

Is it too hard to change the generator?

[mcruzdev]

I am working on it

[mcruzdev]

Hi guys, after some discovering.

It is not possible with jsonschema2pojo library, even with the provided API SchemaRule, AbstractAnnotator or similar APIs provided by jsonschema2pojo. The problem lives on codemodel library that is used by jsonschema2pojo.

If we want to remove the warnings, we can follow the @fjtirado or to use another library. I created an issue there to see if someone can help with a workaround joelittlejohn/jsonschema2pojo#1770

[ricardozanini]

@mcruzdev nice! Once we have an answer there, we can send a PR to them upstream, perhaps? Codemodel you mean this: https://github.com/javaee/jaxb-codemodel?

[ricardozanini]

LOL, 14 years without an update. That's somewhat concerning.

[unkish]

https://github.com/javaee/jaxb-codemodel was archived, jaxb-codemodel is now part of https://github.com/eclipse-ee4j/jaxb-ri

[fjtirado]

Fixed on Pojo-generator