Change types to be serializable-friendly

[mcruzdev]

Context

It is not an issue but we need to discuss a pain from quarkiverse/quarkus-flow extension.

Trying to solve the quarkiverse/quarkus-flow#50 issue where is expected to:

1. Get the file containing a workflow descriptor from YAML
2. Create a Workflow through WorkflowReader.readWorkflow(file);
3. Create a SyntheticBean recording the Workflow:

+    public Supplier<WorkflowDefinition> workflowDefinitionSupplier(Workflow workflow) {
+        return () -> {
+            try {
+                final WorkflowApplication app = Arc.container().instance(WorkflowApplication.class).get();
+                return app.workflowDefinition(workflow);
+            } catch (Exception e) {
+                throw new RuntimeException("Failed to create WorkflowDefinition for " + workflow, e);
+            }
+        };
+    }

Problem

It is not possible to record the TaskItem object, because it is read-only and it is not possible to record the URI from UriTemplate#literalUri beacuse URI is read-only too and not serializable-friendly.

References:

• https://quarkus.io/guides/writing-extensions#bytecode-recording-2
• Add reference to the Bytecode Recording documentation quarkusio/quarkus#50967

Possible solutions

• Add setters to TaskItem at UnevaluatedPropertiesRule something like GeneratorUtils#getterMethod. And, change the String literalUri to String.

[fjtirado]

Althoug not related with this issue, we should, as good java developers, avoid this type of construct in all situations

    } catch (RuntimeException re) {
+                throw re;
+            } catch (Throwable e) {
+                throw new RuntimeException("Failed to create WorkflowDefinition for " + workflow, e);
+            }

This code should just catch all checked exception (one by one using |) and not catch runtime just to rethrow it

[mcruzdev]

Althoug not related with this issue, we should, as good java developers, avoid this type of construct in all situations

    } catch (RuntimeException re) {
+                throw re;
+            } catch (Throwable e) {
+                throw new RuntimeException("Failed to create WorkflowDefinition for " + workflow, e);
+            }

This code should just catch all checked exception (one by one using |) and not catch runtime just to rethrow it

Good catch, thanks! Probably this was added by mistake during a quick copy/paste

[mcruzdev]

Pain solved from Quarkus Flow side. I read and created the WorkflowDefinition on runtime/recorder.