Fix ansible-lint violations in existing roles

- Add changed_when: true to two tasks in get_openshift_release_binaries
- Add set -o pipefail to shell tasks with pipes in run-performance-test
- Replace ignore_errors with failed_when: false in DUT pod cleanup

Ref: OSPRH-32049
Change-Id: I7320ee163f4a2811f7dd7d535424fabb2c2e694e
Signed-off-by: Itay Matza <imatza@redhat.com>

Author: imatza-rh

collection/stages/roles/day2ops/tasks/procedures/run-performance-test.yml

@@ -90,6 +90,7 @@
 
     - name: Collect SRIOV DUT port MACs
       ansible.builtin.shell: |
+        set -o pipefail
         oc --kubeconfig {{ kubeconfig }} logs {{ perf_test.sriov.pod_name }} -n default | grep -E "^Port [0-9]" | grep -v "link state change"
       register: _sriov_macs
       retries: 10
@@ -202,6 +203,7 @@
 
     - name: Collect DPDK DUT port MACs
       ansible.builtin.shell: |
+        set -o pipefail
         oc --kubeconfig {{ kubeconfig }} logs {{ perf_test.dpdk.pod_name }} -n default | grep -E "^Port [0-9]" | grep -v "link state change"
       register: _dpdk_macs
       retries: 10
@@ -271,4 +273,4 @@
   loop:
     - "{{ perf_test.sriov.pod_name }}"
     - "{{ perf_test.dpdk.pod_name }}"
-  ignore_errors: true
+  failed_when: false

collection/tools/roles/tools_get_openshift_release/tasks/get_openshift_release_binaries.yml

@@ -27,6 +27,7 @@
       when: openshift_release_pull_spec is not defined or openshift_release_pull_spec == ''
 
     - name: Extract pull secret from host cluster via Kubernetes API
+      changed_when: true
       ansible.builtin.shell: |
         python3 << 'PYEOF'
         import yaml, json, base64, subprocess, os, sys, tempfile
@@ -127,6 +128,7 @@
         mode: u=rwx,g=rw,o=r
 
     - name: Extract OCP tools from release image {{ openshift_release_pull_spec }}
+      changed_when: true
       ansible.builtin.command:
         cmd: >-
           timeout 900