Merge pull request #18 from shiftstack/prow-onboarding

Add OWNERS, CODEOWNERS, and ansible-lint GitHub Action for Prow onboarding

Author: imatza-rh

.github/CODEOWNERS

@@ -0,0 +1,4 @@
+# Default reviewers for all files
+# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+* @arxcruz @chenwng @dlaw4608 @ekuris-redhat @eshulman2 @gryf @imatza-rh @kstrenkova @mandre @stephenfin @tusharjadhav3302 @winiciusallan

.github/workflows/ansible-lint.yml

@@ -0,0 +1,28 @@
+---
+name: Ansible Lint
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  ansible-lint:
+    runs-on: ubuntu-latest
+    container:
+      image: quay.io/shiftstack-qe/shiftstack-client
+      options: --user root
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Mark workspace as safe for git
+        run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
+
+      - name: Install Ansible collections
+        run: ansible-galaxy collection install -r requirements.yaml
+
+      - name: Run pre-commit (ansible-lint)
+        run: pre-commit run --all-files
+        env:
+          ANSIBLE_VAULT_PASSWORD_FILE: /home/cloud-admin/.vault-pass

OWNERS

@@ -0,0 +1,8 @@
+# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
+# This file just uses aliases defined in OWNERS_ALIASES.
+
+approvers:
+  - openstack-approvers
+
+reviewers:
+  - openstack-reviewers

OWNERS_ALIASES

@@ -0,0 +1,29 @@
+# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES
+
+aliases:
+  openstack-approvers:
+    - arxcruz
+    - chenwng
+    - dlaw4608
+    - ekuris-redhat
+    - eshulman2
+    - gryf
+    - imatza-rh
+    - kstrenkova
+    - mandre
+    - stephenfin
+    - tusharjadhav3302
+    - winiciusallan
+  openstack-reviewers:
+    - arxcruz
+    - chenwng
+    - dlaw4608
+    - ekuris-redhat
+    - eshulman2
+    - gryf
+    - imatza-rh
+    - kstrenkova
+    - mandre
+    - stephenfin
+    - tusharjadhav3302
+    - winiciusallan

collection/stages/roles/day2ops/tasks/procedures/run-performance-test.yml

@@ -90,6 +90,7 @@
 
     - name: Collect SRIOV DUT port MACs
       ansible.builtin.shell: |
+        set -o pipefail
         oc --kubeconfig {{ kubeconfig }} logs {{ perf_test.sriov.pod_name }} -n default | grep -E "^Port [0-9]" | grep -v "link state change"
       register: _sriov_macs
       retries: 10
@@ -202,6 +203,7 @@
 
     - name: Collect DPDK DUT port MACs
       ansible.builtin.shell: |
+        set -o pipefail
         oc --kubeconfig {{ kubeconfig }} logs {{ perf_test.dpdk.pod_name }} -n default | grep -E "^Port [0-9]" | grep -v "link state change"
       register: _dpdk_macs
       retries: 10
@@ -271,4 +273,4 @@
   loop:
     - "{{ perf_test.sriov.pod_name }}"
     - "{{ perf_test.dpdk.pod_name }}"
-  ignore_errors: true
+  failed_when: false

collection/tools/roles/tools_get_openshift_release/tasks/get_openshift_release_binaries.yml

@@ -27,6 +27,7 @@
       when: openshift_release_pull_spec is not defined or openshift_release_pull_spec == ''
 
     - name: Extract pull secret from host cluster via Kubernetes API
+      changed_when: true
       ansible.builtin.shell: |
         python3 << 'PYEOF'
         import yaml, json, base64, subprocess, os, sys, tempfile
@@ -127,6 +128,7 @@
         mode: u=rwx,g=rw,o=r
 
     - name: Extract OCP tools from release image {{ openshift_release_pull_spec }}
+      changed_when: true
       ansible.builtin.command:
         cmd: >-
           timeout 900