From ab2dcd9d4877df267976eb5e9c9f1c399f53cbe0 Mon Sep 17 00:00:00 2001 From: Shinsuke Kagawa Date: Mon, 7 Sep 2026 15:36:56 +0900 Subject: [PATCH] fix: scope workflow commits to defined commit points The build and implement recipes declared the 4-step task cycle as MANDATORY without stating its scope, and phrased the quality gate as "run quality-fixer before every commit". Together these read as "a quality-fixer pass means commit", so the post-implementation review loop generated one commit per findings round even though no rule requires it. - Scope the mandatory 4-step cycle to the Consumed Task Set, and state that corrections outside it reuse the executor-result branching and quality gate while deferring only the commit - Replace "run quality-fixer before every commit" with the positive precondition: commit only after approved or verification_incomplete - Fix-cycle handoff: keep post-implementation corrections uncommitted; reviewers read the working tree, and applied corrections are committed once at Review Resolution convergence - Fix-cycle handoff: route executor-owned corrections through the per-task cycle's step 2 so the conditional integration-test-reviewer path is not skipped - Final Cleanup: make the pre-cleanup commit an explicit step instead of an assumption - Bump plugin versions to 0.25.6 Co-Authored-By: Claude Opus 5 (1M context) --- .claude-plugin/marketplace.json | 8 ++++---- dev-skills/.claude-plugin/plugin.json | 2 +- dev-workflows-frontend/.claude-plugin/plugin.json | 2 +- dev-workflows-frontend/skills/recipe-front-build/SKILL.md | 8 ++++---- .../skills/subagents-orchestration-guide/SKILL.md | 2 +- dev-workflows-fullstack/.claude-plugin/plugin.json | 2 +- dev-workflows-fullstack/skills/recipe-build/SKILL.md | 8 ++++---- .../skills/recipe-front-build/SKILL.md | 8 ++++---- .../skills/recipe-fullstack-implement/SKILL.md | 4 ++-- dev-workflows-fullstack/skills/recipe-implement/SKILL.md | 4 ++-- .../skills/subagents-orchestration-guide/SKILL.md | 2 +- dev-workflows/.claude-plugin/plugin.json | 2 +- dev-workflows/skills/recipe-build/SKILL.md | 8 ++++---- dev-workflows/skills/recipe-implement/SKILL.md | 4 ++-- .../skills/subagents-orchestration-guide/SKILL.md | 2 +- package.json | 2 +- skills/recipe-build/SKILL.md | 8 ++++---- skills/recipe-front-build/SKILL.md | 8 ++++---- skills/recipe-fullstack-implement/SKILL.md | 4 ++-- skills/recipe-implement/SKILL.md | 4 ++-- skills/subagents-orchestration-guide/SKILL.md | 2 +- 21 files changed, 47 insertions(+), 47 deletions(-) diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 5e62c99..b8eb271 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -12,7 +12,7 @@ "name": "dev-workflows", "source": "./dev-workflows", "strict": true, - "version": "0.25.5", + "version": "0.25.6", "description": "Skills + Subagents for backend development - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents", "author": { "name": "Shinsuke Kagawa", @@ -83,7 +83,7 @@ "name": "dev-workflows-frontend", "source": "./dev-workflows-frontend", "strict": true, - "version": "0.25.5", + "version": "0.25.6", "description": "Skills + Subagents for React/TypeScript - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents", "author": { "name": "Shinsuke Kagawa", @@ -157,7 +157,7 @@ "name": "dev-workflows-fullstack", "source": "./dev-workflows-fullstack", "strict": true, - "version": "0.25.5", + "version": "0.25.6", "description": "Skills + Subagents for fullstack development (backend + React/TypeScript) - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents", "author": { "name": "Shinsuke Kagawa", @@ -247,7 +247,7 @@ "name": "dev-skills", "source": "./dev-skills", "strict": true, - "version": "0.25.5", + "version": "0.25.6", "description": "Lightweight skills for users with existing workflows - coding best practices, testing principles, and design guidelines without recipe workflows or agents", "author": { "name": "Shinsuke Kagawa", diff --git a/dev-skills/.claude-plugin/plugin.json b/dev-skills/.claude-plugin/plugin.json index 1d5d725..a0c35d6 100644 --- a/dev-skills/.claude-plugin/plugin.json +++ b/dev-skills/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "dev-skills", "description": "Lightweight skills for users with existing workflows - coding best practices, testing principles, and design guidelines without recipe workflows or agents", - "version": "0.25.5", + "version": "0.25.6", "author": { "name": "Shinsuke Kagawa", "url": "https://github.com/shinpr" diff --git a/dev-workflows-frontend/.claude-plugin/plugin.json b/dev-workflows-frontend/.claude-plugin/plugin.json index 2a5cb24..faaa8d6 100644 --- a/dev-workflows-frontend/.claude-plugin/plugin.json +++ b/dev-workflows-frontend/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "dev-workflows-frontend", "description": "Skills + Subagents for React/TypeScript - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents", - "version": "0.25.5", + "version": "0.25.6", "author": { "name": "Shinsuke Kagawa", "url": "https://github.com/shinpr" diff --git a/dev-workflows-frontend/skills/recipe-front-build/SKILL.md b/dev-workflows-frontend/skills/recipe-front-build/SKILL.md index c80441f..a5561a1 100644 --- a/dev-workflows-frontend/skills/recipe-front-build/SKILL.md +++ b/dev-workflows-frontend/skills/recipe-front-build/SKILL.md @@ -20,11 +20,11 @@ Before the first finding disposition, read `references/review-resolution.md` fro **Execution Protocol**: 1. **Invoke named specialists for deliverable production** — pass deliverable paths between them and validate their results (see subagents-orchestration-guide "Orchestrator Execution Boundary") -2. **Follow the 4-step task cycle exactly**: execute → branch on executor result → quality-fix → commit +2. **Follow the 4-step task cycle exactly for each task in the Consumed Task Set**: execute → branch on executor result → quality-fix → commit. Corrections produced outside that cycle reuse its executor-result branching and quality gate, and defer only the commit to their own phase's rule 3. **Enter autonomous mode** when the user provides execution instruction with an existing Work Plan or task files — this IS the batch approval 4. **Scope**: Complete consumed task-set execution, post-implementation verification, consumed-task cleanup, and completion reporting in order, or stop autonomous execution at the current phase for a valid user-owned escalation. Advance only when the current phase's stated transition condition is satisfied. -**CRITICAL**: Run quality-fixer-frontend before every commit. +**CRITICAL**: Commit only after quality-fixer-frontend returns `approved` or `verification_incomplete`. A quality-fixer-frontend pass authorizes a commit at a defined commit point; it does not create one. Work plan: $ARGUMENTS @@ -81,7 +81,7 @@ Recompute the Consumed Task Set using the same restricted pattern from the Consu - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues ## Task Execution Cycle (4-Step Cycle) -**MANDATORY EXECUTION CYCLE**: `execute → branch on executor result → quality-fix → commit` +**MANDATORY EXECUTION CYCLE** (per task in the Consumed Task Set): `execute → branch on executor result → quality-fix → commit` For EACH task in the Consumed Task Set, YOU MUST: 1. **EXECUTE**: invoke Agent tool (subagent_type: "dev-workflows-frontend:task-executor-frontend") → Record the current HEAD as `diffBase`, pass `task_file: [path]`, and receive the structured response @@ -117,7 +117,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ## Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file in the Consumed Task Set - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows-frontend/skills/subagents-orchestration-guide/SKILL.md b/dev-workflows-frontend/skills/subagents-orchestration-guide/SKILL.md index 28a539b..746b6c3 100644 --- a/dev-workflows-frontend/skills/subagents-orchestration-guide/SKILL.md +++ b/dev-workflows-frontend/skills/subagents-orchestration-guide/SKILL.md @@ -195,7 +195,7 @@ For Small, execute one direct-scope 4-step cycle. Complete after `approved`, or Reviewer findings are candidates. Create correction work only from the Review Resolution `apply` set. -**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. +**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then branch on the executor result through the per-task cycle's step 2, including its conditional integration-test-reviewer path, and run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. Post-implementation corrections stay uncommitted through this cycle: the reviewers read the current working tree, so run the applicable quality gate and re-run the originating reviewer on the uncommitted changes, and commit the applied corrections once through Commit Boundary Check after the complete review set reaches Review Resolution convergence. **Re-run rule**: After any applied post-implementation correction, re-run each reviewer with at least one correction applied from its latest result. Retain any other reviewer result completed by Post-Implementation Review Status Routing or Review Resolution only when repository evidence establishes that the correction preserved its review boundary; otherwise re-run that reviewer. After Specialist Result Acceptance recovers a blocked review prerequisite, re-run that reviewer. Review Resolution convergence governs acceptance and preserves resolved declines. diff --git a/dev-workflows-fullstack/.claude-plugin/plugin.json b/dev-workflows-fullstack/.claude-plugin/plugin.json index 64f6a89..737fe64 100644 --- a/dev-workflows-fullstack/.claude-plugin/plugin.json +++ b/dev-workflows-fullstack/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "dev-workflows-fullstack", "description": "Skills + Subagents for fullstack development (backend + React/TypeScript) - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents", - "version": "0.25.5", + "version": "0.25.6", "author": { "name": "Shinsuke Kagawa", "url": "https://github.com/shinpr" diff --git a/dev-workflows-fullstack/skills/recipe-build/SKILL.md b/dev-workflows-fullstack/skills/recipe-build/SKILL.md index 51a8f95..732855e 100644 --- a/dev-workflows-fullstack/skills/recipe-build/SKILL.md +++ b/dev-workflows-fullstack/skills/recipe-build/SKILL.md @@ -20,11 +20,11 @@ Before the first finding disposition, read `references/review-resolution.md` fro **Execution Protocol**: 1. **Invoke named specialists for deliverable production** — pass deliverable paths between them and validate their results (see subagents-orchestration-guide "Orchestrator Execution Boundary") -2. **Follow the 4-step task cycle exactly**: execute → branch on executor result → quality-fix → commit +2. **Follow the 4-step task cycle exactly for each task in the Consumed Task Set**: execute → branch on executor result → quality-fix → commit. Corrections produced outside that cycle reuse its executor-result branching and quality gate, and defer only the commit to their own phase's rule 3. **Enter autonomous mode** when the user provides execution instruction with an existing Work Plan or task files — this IS the batch approval 4. **Scope**: Complete consumed task-set execution, post-implementation verification, consumed-task cleanup, and completion reporting in order, or stop autonomous execution at the current phase for a valid user-owned escalation. Advance only when the current phase's stated transition condition is satisfied. -**CRITICAL**: Run quality-fixer before every commit. +**CRITICAL**: Commit only after quality-fixer returns `approved` or `verification_incomplete`. A quality-fixer pass authorizes a commit at a defined commit point; it does not create one. Work plan: $ARGUMENTS @@ -81,7 +81,7 @@ Recompute the Consumed Task Set using the same restricted pattern from the Consu - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues ## Task Execution Cycle (4-Step Cycle) -**MANDATORY EXECUTION CYCLE**: `execute → branch on executor result → quality-fix → commit` +**MANDATORY EXECUTION CYCLE** (per task in the Consumed Task Set): `execute → branch on executor result → quality-fix → commit` For EACH task in the Consumed Task Set, YOU MUST: 1. **EXECUTE**: invoke Agent tool (subagent_type: "dev-workflows-fullstack:task-executor") → Record the current HEAD as `diffBase`, pass `task_file: [path]`, and receive the structured response @@ -117,7 +117,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ## Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file in the Consumed Task Set - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows-fullstack/skills/recipe-front-build/SKILL.md b/dev-workflows-fullstack/skills/recipe-front-build/SKILL.md index a9a731d..c9ae2c7 100644 --- a/dev-workflows-fullstack/skills/recipe-front-build/SKILL.md +++ b/dev-workflows-fullstack/skills/recipe-front-build/SKILL.md @@ -20,11 +20,11 @@ Before the first finding disposition, read `references/review-resolution.md` fro **Execution Protocol**: 1. **Invoke named specialists for deliverable production** — pass deliverable paths between them and validate their results (see subagents-orchestration-guide "Orchestrator Execution Boundary") -2. **Follow the 4-step task cycle exactly**: execute → branch on executor result → quality-fix → commit +2. **Follow the 4-step task cycle exactly for each task in the Consumed Task Set**: execute → branch on executor result → quality-fix → commit. Corrections produced outside that cycle reuse its executor-result branching and quality gate, and defer only the commit to their own phase's rule 3. **Enter autonomous mode** when the user provides execution instruction with an existing Work Plan or task files — this IS the batch approval 4. **Scope**: Complete consumed task-set execution, post-implementation verification, consumed-task cleanup, and completion reporting in order, or stop autonomous execution at the current phase for a valid user-owned escalation. Advance only when the current phase's stated transition condition is satisfied. -**CRITICAL**: Run quality-fixer-frontend before every commit. +**CRITICAL**: Commit only after quality-fixer-frontend returns `approved` or `verification_incomplete`. A quality-fixer-frontend pass authorizes a commit at a defined commit point; it does not create one. Work plan: $ARGUMENTS @@ -81,7 +81,7 @@ Recompute the Consumed Task Set using the same restricted pattern from the Consu - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues ## Task Execution Cycle (4-Step Cycle) -**MANDATORY EXECUTION CYCLE**: `execute → branch on executor result → quality-fix → commit` +**MANDATORY EXECUTION CYCLE** (per task in the Consumed Task Set): `execute → branch on executor result → quality-fix → commit` For EACH task in the Consumed Task Set, YOU MUST: 1. **EXECUTE**: invoke Agent tool (subagent_type: "dev-workflows-fullstack:task-executor-frontend") → Record the current HEAD as `diffBase`, pass `task_file: [path]`, and receive the structured response @@ -117,7 +117,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ## Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file in the Consumed Task Set - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows-fullstack/skills/recipe-fullstack-implement/SKILL.md b/dev-workflows-fullstack/skills/recipe-fullstack-implement/SKILL.md index bcf3f1c..493ec95 100644 --- a/dev-workflows-fullstack/skills/recipe-fullstack-implement/SKILL.md +++ b/dev-workflows-fullstack/skills/recipe-fullstack-implement/SKILL.md @@ -100,7 +100,7 @@ When user responds to questions: - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues **Required Flow Compliance**: -- Run quality-fixer (layer-appropriate) before every commit +- Commit only after the layer-appropriate quality-fixer returns `approved` or `verification_incomplete`; a quality-fixer pass authorizes a commit at a defined commit point rather than creating one - Obtain user approval before Edit/Write/MultiEdit outside autonomous mode ## Mandatory Orchestrator Responsibilities @@ -141,7 +141,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ### Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file matching `docs/plans/tasks/{plan-name}-backend-task-*.md` and `docs/plans/tasks/{plan-name}-frontend-task-*.md` (the `{plan-name}` derived from the work plan path used in this run) - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows-fullstack/skills/recipe-implement/SKILL.md b/dev-workflows-fullstack/skills/recipe-implement/SKILL.md index e77e482..79c4cb4 100644 --- a/dev-workflows-fullstack/skills/recipe-implement/SKILL.md +++ b/dev-workflows-fullstack/skills/recipe-implement/SKILL.md @@ -91,7 +91,7 @@ After Structural Scale is determined, follow only that scale's applicable path. - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues **Required Flow Compliance**: -- Run quality-fixer before every commit +- Commit only after quality-fixer returns `approved` or `verification_incomplete`; a quality-fixer pass authorizes a commit at a defined commit point rather than creating one - Obtain user approval before Edit/Write/MultiEdit outside autonomous mode ## Mandatory Orchestrator Responsibilities @@ -130,7 +130,7 @@ For Small, skip this document-dependent review. Retry a retained verification li ### Final Cleanup -For Medium/Large, before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +For Medium/Large, before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file matching `docs/plans/tasks/{plan-name}-task-*.md` (the `{plan-name}` derived from the work plan path used in this run) - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows-fullstack/skills/subagents-orchestration-guide/SKILL.md b/dev-workflows-fullstack/skills/subagents-orchestration-guide/SKILL.md index 28a539b..746b6c3 100644 --- a/dev-workflows-fullstack/skills/subagents-orchestration-guide/SKILL.md +++ b/dev-workflows-fullstack/skills/subagents-orchestration-guide/SKILL.md @@ -195,7 +195,7 @@ For Small, execute one direct-scope 4-step cycle. Complete after `approved`, or Reviewer findings are candidates. Create correction work only from the Review Resolution `apply` set. -**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. +**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then branch on the executor result through the per-task cycle's step 2, including its conditional integration-test-reviewer path, and run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. Post-implementation corrections stay uncommitted through this cycle: the reviewers read the current working tree, so run the applicable quality gate and re-run the originating reviewer on the uncommitted changes, and commit the applied corrections once through Commit Boundary Check after the complete review set reaches Review Resolution convergence. **Re-run rule**: After any applied post-implementation correction, re-run each reviewer with at least one correction applied from its latest result. Retain any other reviewer result completed by Post-Implementation Review Status Routing or Review Resolution only when repository evidence establishes that the correction preserved its review boundary; otherwise re-run that reviewer. After Specialist Result Acceptance recovers a blocked review prerequisite, re-run that reviewer. Review Resolution convergence governs acceptance and preserves resolved declines. diff --git a/dev-workflows/.claude-plugin/plugin.json b/dev-workflows/.claude-plugin/plugin.json index 2c344e2..ee6d45b 100644 --- a/dev-workflows/.claude-plugin/plugin.json +++ b/dev-workflows/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "dev-workflows", "description": "Skills + Subagents for backend development - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents", - "version": "0.25.5", + "version": "0.25.6", "author": { "name": "Shinsuke Kagawa", "url": "https://github.com/shinpr" diff --git a/dev-workflows/skills/recipe-build/SKILL.md b/dev-workflows/skills/recipe-build/SKILL.md index ca054b0..a7f7f85 100644 --- a/dev-workflows/skills/recipe-build/SKILL.md +++ b/dev-workflows/skills/recipe-build/SKILL.md @@ -20,11 +20,11 @@ Before the first finding disposition, read `references/review-resolution.md` fro **Execution Protocol**: 1. **Invoke named specialists for deliverable production** — pass deliverable paths between them and validate their results (see subagents-orchestration-guide "Orchestrator Execution Boundary") -2. **Follow the 4-step task cycle exactly**: execute → branch on executor result → quality-fix → commit +2. **Follow the 4-step task cycle exactly for each task in the Consumed Task Set**: execute → branch on executor result → quality-fix → commit. Corrections produced outside that cycle reuse its executor-result branching and quality gate, and defer only the commit to their own phase's rule 3. **Enter autonomous mode** when the user provides execution instruction with an existing Work Plan or task files — this IS the batch approval 4. **Scope**: Complete consumed task-set execution, post-implementation verification, consumed-task cleanup, and completion reporting in order, or stop autonomous execution at the current phase for a valid user-owned escalation. Advance only when the current phase's stated transition condition is satisfied. -**CRITICAL**: Run quality-fixer before every commit. +**CRITICAL**: Commit only after quality-fixer returns `approved` or `verification_incomplete`. A quality-fixer pass authorizes a commit at a defined commit point; it does not create one. Work plan: $ARGUMENTS @@ -81,7 +81,7 @@ Recompute the Consumed Task Set using the same restricted pattern from the Consu - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues ## Task Execution Cycle (4-Step Cycle) -**MANDATORY EXECUTION CYCLE**: `execute → branch on executor result → quality-fix → commit` +**MANDATORY EXECUTION CYCLE** (per task in the Consumed Task Set): `execute → branch on executor result → quality-fix → commit` For EACH task in the Consumed Task Set, YOU MUST: 1. **EXECUTE**: invoke Agent tool (subagent_type: "dev-workflows:task-executor") → Record the current HEAD as `diffBase`, pass `task_file: [path]`, and receive the structured response @@ -117,7 +117,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ## Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file in the Consumed Task Set - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows/skills/recipe-implement/SKILL.md b/dev-workflows/skills/recipe-implement/SKILL.md index 2adc8ce..ac942a2 100644 --- a/dev-workflows/skills/recipe-implement/SKILL.md +++ b/dev-workflows/skills/recipe-implement/SKILL.md @@ -91,7 +91,7 @@ After Structural Scale is determined, follow only that scale's applicable path. - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues **Required Flow Compliance**: -- Run quality-fixer before every commit +- Commit only after quality-fixer returns `approved` or `verification_incomplete`; a quality-fixer pass authorizes a commit at a defined commit point rather than creating one - Obtain user approval before Edit/Write/MultiEdit outside autonomous mode ## Mandatory Orchestrator Responsibilities @@ -130,7 +130,7 @@ For Small, skip this document-dependent review. Retry a retained verification li ### Final Cleanup -For Medium/Large, before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +For Medium/Large, before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file matching `docs/plans/tasks/{plan-name}-task-*.md` (the `{plan-name}` derived from the work plan path used in this run) - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/dev-workflows/skills/subagents-orchestration-guide/SKILL.md b/dev-workflows/skills/subagents-orchestration-guide/SKILL.md index 28a539b..746b6c3 100644 --- a/dev-workflows/skills/subagents-orchestration-guide/SKILL.md +++ b/dev-workflows/skills/subagents-orchestration-guide/SKILL.md @@ -195,7 +195,7 @@ For Small, execute one direct-scope 4-step cycle. Complete after `approved`, or Reviewer findings are candidates. Create correction work only from the Review Resolution `apply` set. -**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. +**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then branch on the executor result through the per-task cycle's step 2, including its conditional integration-test-reviewer path, and run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. Post-implementation corrections stay uncommitted through this cycle: the reviewers read the current working tree, so run the applicable quality gate and re-run the originating reviewer on the uncommitted changes, and commit the applied corrections once through Commit Boundary Check after the complete review set reaches Review Resolution convergence. **Re-run rule**: After any applied post-implementation correction, re-run each reviewer with at least one correction applied from its latest result. Retain any other reviewer result completed by Post-Implementation Review Status Routing or Review Resolution only when repository evidence establishes that the correction preserved its review boundary; otherwise re-run that reviewer. After Specialist Result Acceptance recovers a blocked review prerequisite, re-run that reviewer. Review Resolution convergence governs acceptance and preserves resolved declines. diff --git a/package.json b/package.json index 3dc7379..055a388 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "claude-code-workflows", - "version": "0.25.5", + "version": "0.25.6", "private": true, "type": "module", "engines": { diff --git a/skills/recipe-build/SKILL.md b/skills/recipe-build/SKILL.md index ca054b0..a7f7f85 100644 --- a/skills/recipe-build/SKILL.md +++ b/skills/recipe-build/SKILL.md @@ -20,11 +20,11 @@ Before the first finding disposition, read `references/review-resolution.md` fro **Execution Protocol**: 1. **Invoke named specialists for deliverable production** — pass deliverable paths between them and validate their results (see subagents-orchestration-guide "Orchestrator Execution Boundary") -2. **Follow the 4-step task cycle exactly**: execute → branch on executor result → quality-fix → commit +2. **Follow the 4-step task cycle exactly for each task in the Consumed Task Set**: execute → branch on executor result → quality-fix → commit. Corrections produced outside that cycle reuse its executor-result branching and quality gate, and defer only the commit to their own phase's rule 3. **Enter autonomous mode** when the user provides execution instruction with an existing Work Plan or task files — this IS the batch approval 4. **Scope**: Complete consumed task-set execution, post-implementation verification, consumed-task cleanup, and completion reporting in order, or stop autonomous execution at the current phase for a valid user-owned escalation. Advance only when the current phase's stated transition condition is satisfied. -**CRITICAL**: Run quality-fixer before every commit. +**CRITICAL**: Commit only after quality-fixer returns `approved` or `verification_incomplete`. A quality-fixer pass authorizes a commit at a defined commit point; it does not create one. Work plan: $ARGUMENTS @@ -81,7 +81,7 @@ Recompute the Consumed Task Set using the same restricted pattern from the Consu - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues ## Task Execution Cycle (4-Step Cycle) -**MANDATORY EXECUTION CYCLE**: `execute → branch on executor result → quality-fix → commit` +**MANDATORY EXECUTION CYCLE** (per task in the Consumed Task Set): `execute → branch on executor result → quality-fix → commit` For EACH task in the Consumed Task Set, YOU MUST: 1. **EXECUTE**: invoke Agent tool (subagent_type: "dev-workflows:task-executor") → Record the current HEAD as `diffBase`, pass `task_file: [path]`, and receive the structured response @@ -117,7 +117,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ## Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file in the Consumed Task Set - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/skills/recipe-front-build/SKILL.md b/skills/recipe-front-build/SKILL.md index c80441f..a5561a1 100644 --- a/skills/recipe-front-build/SKILL.md +++ b/skills/recipe-front-build/SKILL.md @@ -20,11 +20,11 @@ Before the first finding disposition, read `references/review-resolution.md` fro **Execution Protocol**: 1. **Invoke named specialists for deliverable production** — pass deliverable paths between them and validate their results (see subagents-orchestration-guide "Orchestrator Execution Boundary") -2. **Follow the 4-step task cycle exactly**: execute → branch on executor result → quality-fix → commit +2. **Follow the 4-step task cycle exactly for each task in the Consumed Task Set**: execute → branch on executor result → quality-fix → commit. Corrections produced outside that cycle reuse its executor-result branching and quality gate, and defer only the commit to their own phase's rule 3. **Enter autonomous mode** when the user provides execution instruction with an existing Work Plan or task files — this IS the batch approval 4. **Scope**: Complete consumed task-set execution, post-implementation verification, consumed-task cleanup, and completion reporting in order, or stop autonomous execution at the current phase for a valid user-owned escalation. Advance only when the current phase's stated transition condition is satisfied. -**CRITICAL**: Run quality-fixer-frontend before every commit. +**CRITICAL**: Commit only after quality-fixer-frontend returns `approved` or `verification_incomplete`. A quality-fixer-frontend pass authorizes a commit at a defined commit point; it does not create one. Work plan: $ARGUMENTS @@ -81,7 +81,7 @@ Recompute the Consumed Task Set using the same restricted pattern from the Consu - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues ## Task Execution Cycle (4-Step Cycle) -**MANDATORY EXECUTION CYCLE**: `execute → branch on executor result → quality-fix → commit` +**MANDATORY EXECUTION CYCLE** (per task in the Consumed Task Set): `execute → branch on executor result → quality-fix → commit` For EACH task in the Consumed Task Set, YOU MUST: 1. **EXECUTE**: invoke Agent tool (subagent_type: "dev-workflows-frontend:task-executor-frontend") → Record the current HEAD as `diffBase`, pass `task_file: [path]`, and receive the structured response @@ -117,7 +117,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ## Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file in the Consumed Task Set - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/skills/recipe-fullstack-implement/SKILL.md b/skills/recipe-fullstack-implement/SKILL.md index 663e2e6..7495bdd 100644 --- a/skills/recipe-fullstack-implement/SKILL.md +++ b/skills/recipe-fullstack-implement/SKILL.md @@ -100,7 +100,7 @@ When user responds to questions: - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues **Required Flow Compliance**: -- Run quality-fixer (layer-appropriate) before every commit +- Commit only after the layer-appropriate quality-fixer returns `approved` or `verification_incomplete`; a quality-fixer pass authorizes a commit at a defined commit point rather than creating one - Obtain user approval before Edit/Write/MultiEdit outside autonomous mode ## Mandatory Orchestrator Responsibilities @@ -141,7 +141,7 @@ Apply subagents-orchestration-guide's Post-Implementation Review status-routing ### Final Cleanup -Before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +Before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file matching `docs/plans/tasks/{plan-name}-backend-task-*.md` and `docs/plans/tasks/{plan-name}-frontend-task-*.md` (the `{plan-name}` derived from the work plan path used in this run) - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/skills/recipe-implement/SKILL.md b/skills/recipe-implement/SKILL.md index 2adc8ce..ac942a2 100644 --- a/skills/recipe-implement/SKILL.md +++ b/skills/recipe-implement/SKILL.md @@ -91,7 +91,7 @@ After Structural Scale is determined, follow only that scale's applicable path. - Other environments (tests, quality tools) → Quality agents retain proof limitations while the task cycle continues **Required Flow Compliance**: -- Run quality-fixer before every commit +- Commit only after quality-fixer returns `approved` or `verification_incomplete`; a quality-fixer pass authorizes a commit at a defined commit point rather than creating one - Obtain user approval before Edit/Write/MultiEdit outside autonomous mode ## Mandatory Orchestrator Responsibilities @@ -130,7 +130,7 @@ For Small, skip this document-dependent review. Retry a retained verification li ### Final Cleanup -For Medium/Large, before the completion report, delete the implementation task files this recipe consumed. Their work is committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: +For Medium/Large, before the completion report, commit the post-review corrections applied at Review Resolution convergence when any remain uncommitted, applying subagents-orchestration-guide Commit Boundary Check, then delete the implementation task files this recipe consumed. Their work is then committed; `docs/plans/` is ephemeral working state and is not retained between recipe runs: - Delete every file matching `docs/plans/tasks/{plan-name}-task-*.md` (the `{plan-name}` derived from the work plan path used in this run) - Preserve the work plan itself (`docs/plans/{plan-name}.md`) — the user decides whether to delete it after final review diff --git a/skills/subagents-orchestration-guide/SKILL.md b/skills/subagents-orchestration-guide/SKILL.md index 28a539b..746b6c3 100644 --- a/skills/subagents-orchestration-guide/SKILL.md +++ b/skills/subagents-orchestration-guide/SKILL.md @@ -195,7 +195,7 @@ For Small, execute one direct-scope 4-step cycle. Complete after `approved`, or Reviewer findings are candidates. Create correction work only from the Review Resolution `apply` set. -**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. +**Fix-cycle handoff**: Apply Review Resolution and invoke each correction owner it selects. For an author-owned technical-artifact correction, invoke the layer-appropriate technical designer in update mode, run the artifact's existing document-reviewer and applicable design-sync gates, then re-run the originating reviewer. For an executor-owned correction, invoke the layer-appropriate executor with its original `task_file` or direct-scope fields plus `correction_findings` as the complete `apply` finding objects verbatim with only their dispositions added, then branch on the executor result through the per-task cycle's step 2, including its conditional integration-test-reviewer path, and run the applicable quality gate. When both owners are required, Review Resolution's author-first re-evaluation controls the order. Carry `prior_feedback` only to reconciliation reviewers. Post-implementation corrections stay uncommitted through this cycle: the reviewers read the current working tree, so run the applicable quality gate and re-run the originating reviewer on the uncommitted changes, and commit the applied corrections once through Commit Boundary Check after the complete review set reaches Review Resolution convergence. **Re-run rule**: After any applied post-implementation correction, re-run each reviewer with at least one correction applied from its latest result. Retain any other reviewer result completed by Post-Implementation Review Status Routing or Review Resolution only when repository evidence establishes that the correction preserved its review boundary; otherwise re-run that reviewer. After Specialist Result Acceptance recovers a blocked review prerequisite, re-run that reviewer. Review Resolution convergence governs acceptance and preserves resolved declines.