Keep phone metadata when titles name automatic events by simple-analytics-ai[bot] · Pull Request #122 · simpleanalytics/scripts

simple-analytics-ai · 2026-10-15T23:04:40Z

Summary

Refs #107. Targets v12 for #40.

 titled tel: click
   retain title-derived event name
+  retain phone metadata

User steering: verify unresolved CodeRabbit findings, keep one change per PR, and minimize shipped bytes. Run the existing phone extraction even when the title supplies the event name; other event types retain their behavior.

Evidence

Before: tel:+31201234567?extension=42 with title="Call sales" sends phone_Call_sales without phone metadata; the regression test fails.
After: the same event includes phone: "+31201234567"; 54 offline unit tests pass.
Rebuilt latest and unreleased v12 distributions; ES5 parsing and formatting checks pass. Auto-events grows by 14 minified bytes / 9 gzip bytes, excluding generated headers; the main and light scripts are unchanged.
Frozen dependency install and 15 deployment tests pass. BrowserStack was not run locally.

Security implications

Titled phone events now contain the same phone metadata as untitled phone events. Query suffixes are excluded. Collection settings and phone event defaults remain as accepted for v12.

Merge Danger

Door: two-way

Blast Radius: phones

Checklist

Linked to issue Preserve existing script installations when releasing v12 #107
Tested locally
Requested review from adriaandotcom

Summary by CodeRabbit

Bug Fixes
- Phone links with titles now retain the normalized phone number in event metadata while using the title as the event name.

User requested checking unresolved comments with a focus on CodeRabbit, separate reviewable changes, and minimal shipped bytes. Extract phone metadata before applying the existing title-derived event name and cover the regression. Refs #107

coderabbitai · 2026-10-15T23:05:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 9909cf1a-bd3b-4162-839c-6dd018cb9ca2

📥 Commits

Reviewing files that changed from the base of the PR and between 6b84d42 and 64c2359.

⛔ Files ignored due to path filters: 8

dist/latest/auto-events.js is excluded by !**/dist/**
dist/latest/auto-events.js.map is excluded by !**/dist/**, !**/*.map
dist/latest/custom/auto-events.js is excluded by !**/dist/**
dist/latest/custom/auto-events.js.map is excluded by !**/dist/**, !**/*.map
dist/v12/auto-events.js is excluded by !**/dist/**
dist/v12/auto-events.js.map is excluded by !**/dist/**, !**/*.map
dist/v12/custom/auto-events.js is excluded by !**/dist/**
dist/v12/custom/auto-events.js.map is excluded by !**/dist/**, !**/*.map

📒 Files selected for processing: 2

src/auto-events.js
test/unit/auto-events.test.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Titled phone links now extract the phone number into event metadata while using the title as the event name. A unit test verifies the event name and metadata.

Changes: Titled phone link metadata

Layer / File(s)	Summary
Phone extraction and validation `src/auto-events.js`, `test/unit/auto-events.test.js`	Phone links with titles now populate `metadata.phone` and use the title as the event name. The test checks the emitted event name, title, and normalized phone number.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: adriaandotcom

Merge Risk: ⚪ Minimal · up to 64c23

Titled phone links are intended to retain phone metadata while using the title as the event name; the examined untitled path is unchanged. No actionable merge risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 64c23

The change affects 2 systems.

Changed systems: src, test

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — src (service) was modified; 1 changed file maps to changed impact.
observed — test (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in src/auto-events.js: Phone links now run the type-specific extraction even when a title is present, populating metadata.phone; the title is then used as the event name. Previously, a titled phone link skipped extraction.
observed — Modified behavior in test/unit/auto-events.test.js: Added a test for a titled tel: link, asserting the emitted event name uses the title and its metadata contains the title and phone number.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preserving phone metadata when a title provides the automatic event name.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-15T23:09:45Z

-        if (useTitle) {
-          event = theTitle;
-        } else {
+        if (!useTitle || type === "phone") {


Special-casing phone leaves the same metadata loss in place for the other three types: against the built script, a titled outbound/download link still sends no url and a titled mailto: link no email. Dropping the !useTitle || guard entirely (always run the switch, then let if (useTitle) event = theTitle; rename the event) fixes all four types and builds 19 minified / 10 gzip bytes smaller, at the cost of adding url/email metadata to titled links on existing installations.

github-actions · 2026-10-15T23:09:52Z

Documentation update

`_docs/55_events/05_automated-events.md`

Location: new ## Phones section, directly after the ## Downloads section and before ## Script

Copy and paste this into the documentation repository:

## Phones

Do you have `tel:` links on your website? Then you can see how many clicks you get on your phone links. Phone clicks are part of the default `data-collect` value (`outbound,emails,downloads,phones`), so they are collected without extra configuration.

The event name is based on the phone number in the link, without any query parameters: a click on `tel:+31201234567?extension=42` is sent as `phone_31201234567`. The number is also sent as `phone` metadata, so you can see the exact number that was clicked.

When `data-use-title` is enabled (the default) and the link has a `title` attribute, that title is used for the event name instead. A click on `<a href="tel:+31201234567" title="Call sales">` is sent as `phone_Call_sales`, and the `phone` metadata still contains `+31201234567`.

github-actions · 2026-10-15T23:10:00Z

Claude review checkpoint

Reviewed commit 64c23596a59979faa1d5c079fde16cf00ebc7d67. This is used to keep later automated reviews focused on changes Claude has not checked yet.

github-actions · 2026-10-15T23:10:03Z

SDLC label: change: routine because Scoped tracker bug fix that restores the already-collected phone metadata field on titled phone events; collection settings, defaults, permissions, billing and infrastructure are unchanged

* Fix problem with solana extension It seems Solana from Phantom has this namespace for their browser extension. I added a check for prevent them being detected as bots. * Move from _phantom to phantom * Run prettier via GitHub Action * Fix bug in checking phantom.solana * Always expose sa_pageview * Check for Cloudflare under attack mode param * Run prettier via GitHub Action * Test for all Cloudflare params * Clean subdomain hostname, fix auto events for links with child elements, run prettier * Add acron and remove trailing comma * Run prettier via GitHub Action * Save local changes [no ci] * Add jsdom unit tests * Fix default test without Browserstack * Add unit test to job * Make sure all node js version are the same * Allow overwriting referrer * Rename testing file * Run prettier in dry mode [no ci] * Add AGENTS guidance * Improve AGENTS.md * Add .cursorrules [no ci] * Add modular unit tests and helpers * Run browserstack not every time, and add linting * Run browserstack not every time, for real * Require prettier for brwoserstack too * Rename prettier to linting * chore: fix eslint errors * feat(auto-events): skip automation when data-simple-event present * Add manual build step * Rename to Testing Suite * fix metadata reload in appendMetadata * Bind sendBeacon calls * Add callback support to sa_pageview * Checkout dist after test:unit * Reuse query param filter for manual pageviews * test: add metadata collector attr test * Run npm run build * Add tel link tracking to auto events * Add unit tests for auto-events * Warn when metadata collector function is not found * Run npm run build * Fix delayed phone link events * fix allowParams regex to be case insensitive * Fix merged BrowserStack test setup * Collect compact query parameter names via ignore metrics * Run BrowserStack tests on Node.js 22.16 * Use numeric BrowserStack test exit codes * Sync v12 conflict files with current main * Use querykeys for query parameter name collection * Fix v12 CI after main sync * Document tracker compatibility and size priorities for agents (#115) * Document tracker compatibility and size priorities for agents * Update AGENTS.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> Co-authored-by: Adriaan <1079135+adriaandotcom@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Support inline events in the main v12 script (#106) * Support inline event attributes in the main v12 tracker Requested: integrate documented inline events without overengineering, keep the script small and website behavior intact, and open a separate PR based on and targeting v12. Use delegated click/submit handlers and keepalive GETs with the existing image fallback. Preserve installed inline helpers and make confirmed 404 detection opt-in. Add focused tests and patch the vulnerable Handlebars build dependency. * Simplify inline events after review Requested: remove compatibility checks for the beta helper, measure repeated attribute strings, clarify the DOM alias, and shorten submit-button metadata extraction. Keep literals because sharing them increases gzip size. Prefer trimmed, capped submitter labels and scan title/body text for 404s. Address the related bot feedback by running the complete unit suite in CI. * Normalize inline submit button label whitespace Requested: address scripts PR #106 review comment 4282258759 so formatting a button across multiple lines does not fragment button_text metadata. Collapse whitespace before trimming and applying the existing 200-character limit. Add a regression for equivalent compact and indented button markup, and regenerate the affected tracker bundles. Verification: regression fails on the previous compiled tracker; all 33 unit tests pass after the fix. Build, formatting, and diff checks pass. --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Preserve distinct manual pageviews in v12 (#108) * Preserve distinct manual pageviews in v12 Requested in the compatibility review: fix query-only manual pageview loss and preserve full path-overwriter input. Keep the filtered outgoing path and review campaign attribution separately. Refs #107 * Preserve ignore-pages and hash routes for manual query paths Address automated review of item 1: normalize the manual query after the path-overwriter callback and before ignore-pages/hash handling, while keeping its query in the duplicate key. Refs #107 * Keep non-string manual paths compatible during query normalization Address review of item 1: only split string path values, preserving numeric manual paths and numeric path-overwriter results without introducing an exception into the customer page. Refs #107 * Preserve pathname-only input for path overwriters Requested during review: keep the existing path-overwriter behavior without query strings, while retaining distinct manual-query pageviews. Restore query splitting before getPath and update the callback and duplicate checks. --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Leave phone click navigation to the website and browser (#111) Requested in item 5: prevent unwanted telephone navigation from analytics callbacks while retaining default outbound, email, download, and phone collection when data-collect is omitted. Refs #107 Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Respect the configured namespace for manual pageviews (#110) * Respect the configured namespace for manual pageviews Requested in item 3: keep namespaced trackers from replacing another tracker manual pageview function. Reuse existing namespace and pageview text variables to reduce minified bytes. Refs #107 * Retain the free legacy manual pageview alias Address review of item 3: older namespaced installations still call sa_pageview. Keep that alias when free, without overwriting another tracker, and cover both function names in the regression test. Refs #107 --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Fix cmd-click for auto events (#78) * feat(auto-events): allow cmd-click to open in new tab * Preserve browser navigation for automatic link events User request: recheck whether PR #78 remains relevant, fix the current issue, and add the commits to that PR. Current v12 still cancels modified clicks and redirects from tracking callbacks. Use listeners without replacing onclick and reuse the existing keepalive transport; retain event names and metadata. Rebuild current bundles while preserving existing SRI files. Validated with 41 unit tests, 12 deployment tests, typecheck, and 48 local click/transport scenarios. --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Count Cloudflare challenge arrivals as unique (#112) * Recognize Cloudflare challenge markers only in query names Requested in the compatibility review: avoid path false positives and inspect raw query-only markers. Reuse the referrer helper without sending raw query values or adding bytes to light builds. Refs #107 * Refresh the Cloudflare compatibility fix on current v12 Requested: make issue #107 mergeable while preserving manual-query overrides, browser-query fallback, and existing filtering. Resolve the older Cloudflare branch against current v12 source and regenerate its bundles, preserving inline events and the merged phone-click fix. All 45 unit tests and 24 additional query payload checks pass. Refs #107 * Use the requested simple Cloudflare marker check on latest v12 User asked to replace the parameter-name regex with a literal ?__cf_ check, omit the extra same-URL guard, and merge current v12 into #112. Preserve the latest modified-click, namespace, manual-query, and phone-click fixes. Rebuild matching tracker bundles while retaining unrelated pinned auto-events artifacts. All 53 unit tests, 33 payload checks, changed JavaScript formatting, and diff checks pass. Manual-query overrides and location.search fallback remain intact. Refs #107 * Keep the simple Cloudflare check working after campaign parameters User requested a simple marker check and current v12 merge. Address review by accepting both ?__cf_ and appended &__cf_ with the short /[?&]__cf_/ expression, retaining the requested broad matching and omitting the declined same-URL guard. Update the existing regression and matching bundles. All 53 unit tests and 36 payload checks pass. Current v12 remains included. Refs #107 --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> Co-authored-by: simple-analytics-ai[bot] <313929673+simple-analytics-ai[bot]@users.noreply.github.com> * Accept current and legacy script deployment headers (#117) * Accept current and legacy script deployment headers Requested: make issue #107 ready to merge. Fix the proven mismatch between compile.js output and deployment header validation while retaining older pinned header support. Add tests against the real deployment manifest, legacy and malformed headers, and run the lightweight deployment suite in CI. All 15 deployment tests, type checking, and diff checks pass. Visitor-facing scripts are unchanged. Refs #107 * Check headers for the current SRI version in deployment tests Requested: make issue #107 mergeable and address review on #117. Reuse latestVersionFromNames with the dist directory so the manifest regression follows the current SRI version rather than only v12. All 15 deployment tests and type checking pass. Refs #107 --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Remove retired Cloudflare app build from v12 (#121) Requested: open a PR into v12 removing Cloudflare app options while keeping GTM settings and a working client-side guard. Preserve sa_settings and data-attribute behavior, guard browser access, and rebuild current tracker artifacts. Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * fix: retain phone metadata with titled events (#122) User requested checking unresolved comments with a focus on CodeRabbit, separate reviewable changes, and minimal shipped bytes. Extract phone metadata before applying the existing title-derived event name and cover the regression. Refs #107 Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * test: require current script version in SRI header checks (#123) User requested verifying unresolved CodeRabbit feedback with separate minimal PRs. Require the discovered SRI version to match latest.js so an obsolete version cannot make deployment validation pass. Refs #107 Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Stop ignoring screen size when scrolled is ignored (#127) The screen size check matched the "sc" prefix, which also matches "scrolled". Match "scre" so each metric can be ignored on its own. Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Set the loaded flag for custom event globals (#129) Automated events wait for window[saGlobal + "_loaded"], but the main script only set sa_event_loaded and the namespace flag. With a custom namespace or sa-global (for example ba_event), automated events never fired. Set the flag for the configured event function once it replaces the queue stub, and cover both setups in the unit tests. Rebuild the affected event-enabled distributions (+18 bytes minified, +4 to +9 bytes gzip). light.js and auto-events.js are unchanged. The rebuilt files also include the src change from #127, which had not been rebuilt into dist yet. Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Count label clicks once in inline events (#133) * Run the pageview callback when the pageview is skipped (#132) * Send visible time on page when the page gets hidden (#134) * Send visible time on page when the page gets hidden Count only visible time and send the cumulative value on every hide and on pagehide, so durations survive mobile app switches, screen locks and browser kills, back/forward cache restores no longer send increments, and Firefox tab closes are no longer lost. Every page view, including manual ones, closes the previous one. Optional data-pings sends the same value at visible-time thresholds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Keep invalid scroll readings out of later appends Don't write position() back into the scroll maximum, so a NaN reading on a zero-height layout can't stick for the rest of the page view, and drop the unobservable push branch of the sent watermark. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Send time on page only when the page gets hidden Leaving a page also makes it hidden, so the pagehide listener, the duplicate-send guard, the back/forward cache fallback and the beacon try/catch are no longer needed. Old browsers that don't fire visibilitychange on navigation lose those durations; this keeps the script small. Appends without values are not sent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Ignore huge ping values and hides before the first page view A ping value too large for setTimeout fired immediately and rescheduled itself in a loop, and ignored pages or manual mode sent an append for a page view that was never sent on every hide. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Ask agents to weigh script size against edge cases (#136) * Ask agents to weigh script size against edge cases Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Stop asking agents to commit generated distributions The Dist section says feature work never commits dist/, which item 6 contradicted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Send the embedded script URL with pageviews (#138) * Use the caddy destination in the deploy header test The merge from main renamed the custom destination to caddy, so the header test matched no custom files and typecheck failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Test that automatic link clicks are not cancelled Runs auto-events.js on a same-tab outbound link and checks that it binds a click listener instead of an onclick attribute, leaves the click alone, and asks sa_event for keepalive. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Drop the placeholder callback in automatic link events sendEvent already uses a noop for a missing callback, so 0 is enough to reach the keepalive argument. Saves 11 bytes minified, 1 gzip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Fall back to a pixel when sendBeacon throws Other scripts can replace navigator.sendBeacon with a wrapper that throws "Illegal invocation" (#42). Without the fallback no time on page arrives, the remaining pings stop and every hide throws an error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Limit the Cloudflare unique check to this site's referrers Cloudflare challenges run on the site itself, so a challenge marker in a referrer from another non-unique hostname no longer makes the first pageview unique. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Drop the referrer on Cloudflare challenge arrivals The challenge page replaced the original referrer, so the pageview only sent our own hostname. The queue turns pageviews with our own hostname as referrer non-unique, which undid the unique arrival. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Detect Cloudflare arrivals from the raw referrer host The cleaned referrer has no www. and can carry an overwritten hostname, so www sites kept sending their own hostname as referrer (which the queue turns non-unique) and sites with a matching non-unique hostname sent unique=false. Check the raw referrer first, before sameSite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Compare real hostnames to detect same-site referrers The cleaned referrer has no www. and uses the defined hostname, so on www sites and sites with data-hostname internal page loads and manual pageviews were sent as unique, and SPA pageviews and events on data-hostname sites lost their referrer. Compare the raw referrer host with the location host, and treat later pageviews as same-site. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Mark appends sent by pings Appends from data-pings now include ping: true, so the backend can block them for plans without pings. Appends sent on hide or navigation are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: ironbrands16 <103500025+ironbrands16@users.noreply.github.com> Co-authored-by: Adriaan <1079135+adriaanvanrossum@users.noreply.github.com> Co-authored-by: adriaanvanrossum <adriaanvanrossum@users.noreply.github.com> Co-authored-by: adriaandotcom <adriaandotcom@users.noreply.github.com> Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> Co-authored-by: simple-analytics-ai[bot] <313929673+simple-analytics-ai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Simple Analytics Agent <github-agent@adriaan.simpleanalytics.com> Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Fix problem with solana extension It seems Solana from Phantom has this namespace for their browser extension. I added a check for prevent them being detected as bots. * Move from _phantom to phantom * Run prettier via GitHub Action * Fix bug in checking phantom.solana * Always expose sa_pageview * Check for Cloudflare under attack mode param * Run prettier via GitHub Action * Test for all Cloudflare params * Clean subdomain hostname, fix auto events for links with child elements, run prettier * Add acron and remove trailing comma * Run prettier via GitHub Action * Save local changes [no ci] * Add jsdom unit tests * Fix default test without Browserstack * Add unit test to job * Make sure all node js version are the same * Allow overwriting referrer * Rename testing file * Run prettier in dry mode [no ci] * Add AGENTS guidance * Improve AGENTS.md * Add .cursorrules [no ci] * Add modular unit tests and helpers * Run browserstack not every time, and add linting * Run browserstack not every time, for real * Require prettier for brwoserstack too * Rename prettier to linting * chore: fix eslint errors * feat(auto-events): skip automation when data-simple-event present * Add manual build step * Rename to Testing Suite * fix metadata reload in appendMetadata * Bind sendBeacon calls * Add callback support to sa_pageview * Checkout dist after test:unit * Reuse query param filter for manual pageviews * test: add metadata collector attr test * Run npm run build * Add tel link tracking to auto events * Add unit tests for auto-events * Warn when metadata collector function is not found * Run npm run build * Fix delayed phone link events * fix allowParams regex to be case insensitive * Fix merged BrowserStack test setup * Collect compact query parameter names via ignore metrics * Run BrowserStack tests on Node.js 22.16 * Use numeric BrowserStack test exit codes * Sync v12 conflict files with current main * Use querykeys for query parameter name collection * Fix v12 CI after main sync * Document tracker compatibility and size priorities for agents (#115) * Document tracker compatibility and size priorities for agents * Update AGENTS.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> Co-authored-by: Adriaan <1079135+adriaandotcom@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Support inline events in the main v12 script (#106) * Support inline event attributes in the main v12 tracker Requested: integrate documented inline events without overengineering, keep the script small and website behavior intact, and open a separate PR based on and targeting v12. Use delegated click/submit handlers and keepalive GETs with the existing image fallback. Preserve installed inline helpers and make confirmed 404 detection opt-in. Add focused tests and patch the vulnerable Handlebars build dependency. * Simplify inline events after review Requested: remove compatibility checks for the beta helper, measure repeated attribute strings, clarify the DOM alias, and shorten submit-button metadata extraction. Keep literals because sharing them increases gzip size. Prefer trimmed, capped submitter labels and scan title/body text for 404s. Address the related bot feedback by running the complete unit suite in CI. * Normalize inline submit button label whitespace Requested: address scripts PR #106 review comment 4282258759 so formatting a button across multiple lines does not fragment button_text metadata. Collapse whitespace before trimming and applying the existing 200-character limit. Add a regression for equivalent compact and indented button markup, and regenerate the affected tracker bundles. Verification: regression fails on the previous compiled tracker; all 33 unit tests pass after the fix. Build, formatting, and diff checks pass. --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Preserve distinct manual pageviews in v12 (#108) * Preserve distinct manual pageviews in v12 Requested in the compatibility review: fix query-only manual pageview loss and preserve full path-overwriter input. Keep the filtered outgoing path and review campaign attribution separately. Refs #107 * Preserve ignore-pages and hash routes for manual query paths Address automated review of item 1: normalize the manual query after the path-overwriter callback and before ignore-pages/hash handling, while keeping its query in the duplicate key. Refs #107 * Keep non-string manual paths compatible during query normalization Address review of item 1: only split string path values, preserving numeric manual paths and numeric path-overwriter results without introducing an exception into the customer page. Refs #107 * Preserve pathname-only input for path overwriters Requested during review: keep the existing path-overwriter behavior without query strings, while retaining distinct manual-query pageviews. Restore query splitting before getPath and update the callback and duplicate checks. --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Leave phone click navigation to the website and browser (#111) Requested in item 5: prevent unwanted telephone navigation from analytics callbacks while retaining default outbound, email, download, and phone collection when data-collect is omitted. Refs #107 Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Respect the configured namespace for manual pageviews (#110) * Respect the configured namespace for manual pageviews Requested in item 3: keep namespaced trackers from replacing another tracker manual pageview function. Reuse existing namespace and pageview text variables to reduce minified bytes. Refs #107 * Retain the free legacy manual pageview alias Address review of item 3: older namespaced installations still call sa_pageview. Keep that alias when free, without overwriting another tracker, and cover both function names in the regression test. Refs #107 --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Fix cmd-click for auto events (#78) * feat(auto-events): allow cmd-click to open in new tab * Preserve browser navigation for automatic link events User request: recheck whether PR #78 remains relevant, fix the current issue, and add the commits to that PR. Current v12 still cancels modified clicks and redirects from tracking callbacks. Use listeners without replacing onclick and reuse the existing keepalive transport; retain event names and metadata. Rebuild current bundles while preserving existing SRI files. Validated with 41 unit tests, 12 deployment tests, typecheck, and 48 local click/transport scenarios. --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Count Cloudflare challenge arrivals as unique (#112) * Recognize Cloudflare challenge markers only in query names Requested in the compatibility review: avoid path false positives and inspect raw query-only markers. Reuse the referrer helper without sending raw query values or adding bytes to light builds. Refs #107 * Refresh the Cloudflare compatibility fix on current v12 Requested: make issue #107 mergeable while preserving manual-query overrides, browser-query fallback, and existing filtering. Resolve the older Cloudflare branch against current v12 source and regenerate its bundles, preserving inline events and the merged phone-click fix. All 45 unit tests and 24 additional query payload checks pass. Refs #107 * Use the requested simple Cloudflare marker check on latest v12 User asked to replace the parameter-name regex with a literal ?__cf_ check, omit the extra same-URL guard, and merge current v12 into #112. Preserve the latest modified-click, namespace, manual-query, and phone-click fixes. Rebuild matching tracker bundles while retaining unrelated pinned auto-events artifacts. All 53 unit tests, 33 payload checks, changed JavaScript formatting, and diff checks pass. Manual-query overrides and location.search fallback remain intact. Refs #107 * Keep the simple Cloudflare check working after campaign parameters User requested a simple marker check and current v12 merge. Address review by accepting both ?__cf_ and appended &__cf_ with the short /[?&]__cf_/ expression, retaining the requested broad matching and omitting the declined same-URL guard. Update the existing regression and matching bundles. All 53 unit tests and 36 payload checks pass. Current v12 remains included. Refs #107 --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> Co-authored-by: simple-analytics-ai[bot] <313929673+simple-analytics-ai[bot]@users.noreply.github.com> * Accept current and legacy script deployment headers (#117) * Accept current and legacy script deployment headers Requested: make issue #107 ready to merge. Fix the proven mismatch between compile.js output and deployment header validation while retaining older pinned header support. Add tests against the real deployment manifest, legacy and malformed headers, and run the lightweight deployment suite in CI. All 15 deployment tests, type checking, and diff checks pass. Visitor-facing scripts are unchanged. Refs #107 * Check headers for the current SRI version in deployment tests Requested: make issue #107 mergeable and address review on #117. Reuse latestVersionFromNames with the dist directory so the manifest regression follows the current SRI version rather than only v12. All 15 deployment tests and type checking pass. Refs #107 --------- Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Remove retired Cloudflare app build from v12 (#121) Requested: open a PR into v12 removing Cloudflare app options while keeping GTM settings and a working client-side guard. Preserve sa_settings and data-attribute behavior, guard browser access, and rebuild current tracker artifacts. Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * fix: retain phone metadata with titled events (#122) User requested checking unresolved comments with a focus on CodeRabbit, separate reviewable changes, and minimal shipped bytes. Extract phone metadata before applying the existing title-derived event name and cover the regression. Refs #107 Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * test: require current script version in SRI header checks (#123) User requested verifying unresolved CodeRabbit feedback with separate minimal PRs. Require the discovered SRI version to match latest.js so an obsolete version cannot make deployment validation pass. Refs #107 Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> * Stop ignoring screen size when scrolled is ignored (#127) The screen size check matched the "sc" prefix, which also matches "scrolled". Match "scre" so each metric can be ignored on its own. Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Set the loaded flag for custom event globals (#129) Automated events wait for window[saGlobal + "_loaded"], but the main script only set sa_event_loaded and the namespace flag. With a custom namespace or sa-global (for example ba_event), automated events never fired. Set the flag for the configured event function once it replaces the queue stub, and cover both setups in the unit tests. Rebuild the affected event-enabled distributions (+18 bytes minified, +4 to +9 bytes gzip). light.js and auto-events.js are unchanged. The rebuilt files also include the src change from #127, which had not been rebuilt into dist yet. Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Count label clicks once in inline events (#133) * Run the pageview callback when the pageview is skipped (#132) * Send visible time on page when the page gets hidden (#134) * Send visible time on page when the page gets hidden Count only visible time and send the cumulative value on every hide and on pagehide, so durations survive mobile app switches, screen locks and browser kills, back/forward cache restores no longer send increments, and Firefox tab closes are no longer lost. Every page view, including manual ones, closes the previous one. Optional data-pings sends the same value at visible-time thresholds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Keep invalid scroll readings out of later appends Don't write position() back into the scroll maximum, so a NaN reading on a zero-height layout can't stick for the rest of the page view, and drop the unobservable push branch of the sent watermark. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Send time on page only when the page gets hidden Leaving a page also makes it hidden, so the pagehide listener, the duplicate-send guard, the back/forward cache fallback and the beacon try/catch are no longer needed. Old browsers that don't fire visibilitychange on navigation lose those durations; this keeps the script small. Appends without values are not sent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Ignore huge ping values and hides before the first page view A ping value too large for setTimeout fired immediately and rescheduled itself in a loop, and ignored pages or manual mode sent an append for a page view that was never sent on every hide. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Ask agents to weigh script size against edge cases (#136) * Ask agents to weigh script size against edge cases Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Stop asking agents to commit generated distributions The Dist section says feature work never commits dist/, which item 6 contradicted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Send the embedded script URL with pageviews (#138) * Use the caddy destination in the deploy header test The merge from main renamed the custom destination to caddy, so the header test matched no custom files and typecheck failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Test that automatic link clicks are not cancelled Runs auto-events.js on a same-tab outbound link and checks that it binds a click listener instead of an onclick attribute, leaves the click alone, and asks sa_event for keepalive. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Drop the placeholder callback in automatic link events sendEvent already uses a noop for a missing callback, so 0 is enough to reach the keepalive argument. Saves 11 bytes minified, 1 gzip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Fall back to a pixel when sendBeacon throws Other scripts can replace navigator.sendBeacon with a wrapper that throws "Illegal invocation" (#42). Without the fallback no time on page arrives, the remaining pings stop and every hide throws an error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Limit the Cloudflare unique check to this site's referrers Cloudflare challenges run on the site itself, so a challenge marker in a referrer from another non-unique hostname no longer makes the first pageview unique. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Drop the referrer on Cloudflare challenge arrivals The challenge page replaced the original referrer, so the pageview only sent our own hostname. The queue turns pageviews with our own hostname as referrer non-unique, which undid the unique arrival. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Detect Cloudflare arrivals from the raw referrer host The cleaned referrer has no www. and can carry an overwritten hostname, so www sites kept sending their own hostname as referrer (which the queue turns non-unique) and sites with a matching non-unique hostname sent unique=false. Check the raw referrer first, before sameSite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Compare real hostnames to detect same-site referrers The cleaned referrer has no www. and uses the defined hostname, so on www sites and sites with data-hostname internal page loads and manual pageviews were sent as unique, and SPA pageviews and events on data-hostname sites lost their referrer. Compare the raw referrer host with the location host, and treat later pageviews as same-site. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Release tested script builds and record deployments Stop committing dist/. Bumping VERSION in compile.js on main now publishes GitHub Release vN with the BrowserStack-tested build as scripts-vN.tar.gz. pnpm run deploy picks a release, verifies its digest, shows what each destination runs now, and records a GitHub deployment per destination. Fixes #139 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Record deployments per destination and release only from main - Deploy and record one destination at a time, so a failure on Caddy no longer records the CDN as failed (and the other way around). - Record a release only when latest.js is part of the deployment. - Show the newest successful deployment as what a destination runs, and list newer failed attempts. - Run the release workflow's version job only on main. - Build before the unit and deploy tests, now that dist/ is not committed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Address release and deployment review feedback - Only skip a release when a published release has its archive, so a failed publish after the draft can be retried. - List up to 100 releases, and only those with a recorded digest. - Say how many deployments were searched when none succeeded. - README: only deployments with latest.js are recorded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Reuse an existing draft when publishing a release If an earlier run created the draft but failed to publish it, upload the archive to that draft and publish it at the tested commit, instead of creating a second draft for the same tag. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Treat any published release as released Only drafts are retried, so a retry never attaches a new archive to a published release whose tag points at another commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: ironbrands16 <103500025+ironbrands16@users.noreply.github.com> Co-authored-by: Adriaan <1079135+adriaanvanrossum@users.noreply.github.com> Co-authored-by: adriaanvanrossum <adriaanvanrossum@users.noreply.github.com> Co-authored-by: adriaandotcom <adriaandotcom@users.noreply.github.com> Co-authored-by: Adriaan <1079135+adriaandotcom@users.noreply.github.com> Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid> Co-authored-by: simple-analytics-ai[bot] <313929673+simple-analytics-ai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Conductor Adriaan <conductor@adriaan.simpleanalytics.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

fix: retain phone metadata with titled events

64c2359

User requested checking unresolved comments with a focus on CodeRabbit, separate reviewable changes, and minimal shipped bytes. Extract phone metadata before applying the existing title-derived event name and cover the regression. Refs #107

simple-analytics-ai Bot requested a review from adriaandotcom October 15, 2026 23:05

This was referenced Oct 15, 2026

Require current script version in SRI header validation #123

Merged

Preserve existing script installations when releasing v12 #107

Closed

github-actions Bot reviewed Oct 15, 2026

View reviewed changes

github-actions Bot added the change: routine Changes to internal tools or low-risk changes (e.g., design updates or content modifications) label Oct 15, 2026

adriaandotcom approved these changes Oct 16, 2026

View reviewed changes

adriaandotcom merged commit 5ce3453 into v12 Oct 16, 2026
5 checks passed

adriaandotcom deleted the fix/v12-titled-phone-metadata branch October 16, 2026 12:40

simpleanalytics-agent mentioned this pull request Oct 19, 2026

Add tel: clicks to auto events #52

Closed

Navigation Menu

Repository navigation

Keep phone metadata when titles name automatic events - #122

Keep phone metadata when titles name automatic events#122
adriaandotcom merged 1 commit into
v12from
fix/v12-titled-phone-metadata

simple-analytics-ai Bot commented Oct 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

simple-analytics-ai Bot commented Oct 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Evidence

Security implications

Merge Danger

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 15, 2026

Documentation update

_docs/55_events/05_automated-events.md

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

simple-analytics-ai Bot commented Oct 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

`_docs/55_events/05_automated-events.md`