Skip to content

Commit 061c5cb

Browse files
icecrasher321claude
andcommitted
ci: disable desktop release + e2e in CI for now
The desktop-release reusable-workflow call requested contents: write, which ci.yml's permission grant (contents: read) rejects — invalidating the whole CI workflow. Desktop is tested locally for now; signed builds remain available manually via desktop-release.yml workflow_dispatch, and desktop e2e via its own workflow_dispatch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent fafeaf7 commit 061c5cb

2 files changed

Lines changed: 6 additions & 16 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -531,15 +531,6 @@ jobs:
531531
GH_PAT: ${{ secrets.GITHUB_TOKEN }}
532532
run: bun run scripts/create-single-release.ts ${{ needs.detect-version.outputs.version }}
533533

534-
# Desktop macOS artifacts attach to the release created above. Ordering is
535-
# load-bearing: create-single-release.ts skips creation when the tag already
536-
# exists, so the desktop job must never run before create-release.
537-
desktop-release:
538-
name: Desktop Release
539-
needs: [detect-version, create-release]
540-
if: needs.detect-version.outputs.is_release == 'true'
541-
uses: ./.github/workflows/desktop-release.yml
542-
with:
543-
version: ${{ needs.detect-version.outputs.version }}
544-
publish: true
545-
secrets: inherit
534+
# Desktop release is disabled in CI for now (the app is tested locally).
535+
# Signed macOS artifacts can still be built manually via the
536+
# desktop-release.yml workflow_dispatch when needed.

.github/workflows/desktop-e2e.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@ name: Desktop E2E
33
# Smoke coverage of the real Electron shell, plus an advisory canary leg
44
# against electron@latest so Chromium-cadence breakage surfaces before an
55
# upgrade is attempted (U18/U22).
6+
#
7+
# Manual-only for now: the desktop app is tested locally, so the
8+
# pull_request trigger is disabled until desktop CI is turned back on.
69

710
on:
8-
pull_request:
9-
paths:
10-
- 'apps/desktop/**'
11-
- '.github/workflows/desktop-e2e.yml'
1211
workflow_dispatch:
1312

1413
concurrency:

0 commit comments

Comments
 (0)