fix(files): bound seed reads and preserve browser snapshots

Author: mzxchandra

apps/realtime/src/handlers/file-doc-store.test.ts

@@ -423,10 +423,13 @@ describe('FileDocStore', () => {
       await store.publishAndWait(NAME, Y.encodeStateAsUpdate(source, vector), 'generation-1')
       const snapshot = await store.getStreamSnapshot(NAME, 'generation-1')
       expect(snapshot?.editor).toEqual(actor)
-      Y.applyUpdate(replica, snapshot!.docState)
+      if (!snapshot) throw new Error('Expected accepted snapshot')
+      Y.applyUpdate(replica, snapshot.docState)
       expect(replica.getText('body').toString()).toBe('base-durable-writer-external')
       await store.attachRoom(NAME, replica)
-      storeInternals(store).rooms.get(NAME)!.uncompactedDeltaBytes = 12 * 1024 * 1024
+      const room = storeInternals(store).rooms.get(NAME)
+      if (!room) throw new Error('Expected attached room')
+      room.uncompactedDeltaBytes = 12 * 1024 * 1024
       await storeInternals(store).maybeCompact(NAME)
       expect((await store.getStreamSnapshot(NAME, 'generation-1'))?.editor).toEqual(actor)
       store.detachRoom(NAME)

apps/sim/app/api/internal/project-file-doc/[projectId]/[fileId]/seed/route.ts

@@ -15,7 +15,7 @@ export const POST = defineInternalJsonRoute({
     reason: 'Authenticated realtime relay; socket frame admission bounds collaborative traffic',
   }),
   errorPolicy: internalOrchestrationErrorPolicy,
-  mapInput: ({ params }) => params,
+  mapInput: ({ params }, { request }) => ({ ...params, signal: request.signal }),
   useCase: buildProjectFileDocSeed,
   present: (result) => ({
     update: Buffer.from(result.update).toString('base64'),

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/editor-lifecycle.test.tsx

@@ -111,6 +111,7 @@ const FILE: WorkspaceFileRecord = {
   size: 30,
   uploadedBy: 'user-1',
   uploadedAt: new Date('2026-09-03T20:00:00Z'),
+  updatedAt: new Date('2026-09-03T20:00:00Z'),
 }
 let root: Root
 let container: HTMLDivElement
@@ -378,7 +379,9 @@ describe('loaded rich editor lifecycle', () => {
         )
       }
       await draw()
-      const firstBinding = vi.mocked(useFileDocCollaboration).mock.calls.at(-1)![0]
+      const call = vi.mocked(useFileDocCollaboration).mock.calls.at(-1)
+      if (!call) throw new Error('Expected collaboration binding')
+      const firstBinding = call[0]
       expect(firstBinding.enabled).toBe(true)
       await act(async () => firstBinding.onWriteAccessLost?.())
       editableFileContent.mockReturnValue({
@@ -457,8 +460,9 @@ describe('loaded rich editor lifecycle', () => {
       await act(async () => provider.setSynced(true))
       const editor = getEditor()
       await act(async () => editor.commands.setContent('<p>Original</p>'))
-      const input = container.querySelector<HTMLInputElement>('input[type="file"]')!
-      await act(async () => editor.storage.slashCommand.insertImage(1))
+      const input = container.querySelector<HTMLInputElement>('input[type="file"]')
+      if (!input) throw new Error('Image picker is missing')
+      await act(async () => editor.storage.slashCommand.insertImage?.(1))
       Object.defineProperty(input, 'files', {
         configurable: true,
         value: [
@@ -471,7 +475,7 @@ describe('loaded rich editor lifecycle', () => {
       const signal = uploadFile.mock.calls[0][0].signal as AbortSignal
       expect(signal.aborted).toBe(false)
       expect(container.querySelectorAll('[role="status"]')).toHaveLength(2)
-      await act(async () => editor.storage.slashCommand.insertImage(1))
+      await act(async () => editor.storage.slashCommand.insertImage?.(1))
       collaborationRef.current = { ...collaboration, canWrite: false }
       await render('Original', 'Original', true, { collaborative: true })
       expect(signal.aborted).toBe(true)

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.tsx

@@ -663,14 +663,13 @@ export function LoadedRichMarkdownEditor({
   /** The picker anchor maps through edits while the operating-system file dialog is open. */
   const imageInputRef = useRef<HTMLInputElement>(null)
   const pendingImageAnchorRef = useRef<string | null>(null)
-  const imageUploadBatchesRef = useRef(
-    new Set<{
-      editor: Editor
-      anchors: string[]
-      controller: AbortController
-      toastId?: ReturnType<typeof toast.info>
-    }>()
-  )
+  const imageUploadBatchesRef = useRef<Set<{
+    editor: Editor
+    anchors: string[]
+    controller: AbortController
+    toastId?: ReturnType<typeof toast.info>
+  }> | null>(null)
+  imageUploadBatchesRef.current ??= new Set()
 
   /**
    * Uploads are sequential; every position is anchored before awaiting so queued images also follow
@@ -697,7 +696,7 @@ export function LoadedRichMarkdownEditor({
       controller: new AbortController(),
       toastId: undefined as ReturnType<typeof toast.info> | undefined,
     }
-    imageUploadBatchesRef.current.add(batch)
+    imageUploadBatchesRef.current?.add(batch)
     try {
       for (const [index, image] of images.entries()) {
         if (editor.isDestroyed || !editor.isEditable || batch.controller.signal.aborted) break
@@ -733,7 +732,7 @@ export function LoadedRichMarkdownEditor({
     } finally {
       if (batch.toastId !== undefined) toast.dismiss(batch.toastId)
       for (const anchor of anchors) removeImageUpload(editor, anchor)
-      imageUploadBatchesRef.current.delete(batch)
+      imageUploadBatchesRef.current?.delete(batch)
     }
   }
 
@@ -1037,12 +1036,12 @@ export function LoadedRichMarkdownEditor({
   useEffect(() => {
     if (!editor || !effectiveCanEdit) return
     return () => {
-      for (const batch of imageUploadBatchesRef.current) {
+      for (const batch of imageUploadBatchesRef.current ?? []) {
         batch.controller.abort()
         for (const anchor of batch.anchors) removeImageUpload(batch.editor, anchor)
         if (batch.toastId !== undefined) toast.dismiss(batch.toastId)
       }
-      imageUploadBatchesRef.current.clear()
+      imageUploadBatchesRef.current?.clear()
       const anchor = pendingImageAnchorRef.current
       if (anchor) removeImageUpload(editor, anchor)
       pendingImageAnchorRef.current = null

apps/sim/lib/api/contracts/v2/openapi/project-file-uploads.ts

@@ -56,7 +56,7 @@ export const projectFileUploadOpenApiRoutes = [
       summary: 'Get Project file upload',
       description: `Read the current state of a Project upload, including its file after completion. ${WORKSPACE_API_KEY_DENIED}`,
       tags: ['Files'],
-      errors: [...RESOURCE_CONFLICT_ERRORS, 'PayloadTooLarge', 'UnsupportedMediaType'],
+      errors: RESOURCE_CONFLICT_ERRORS,
       success: { description: 'Get Project File Upload result.', headers: RATE_LIMIT_HEADERS },
     },
     {
@@ -89,7 +89,7 @@ export const projectFileUploadOpenApiRoutes = [
       summary: 'Abort Project file upload',
       description: `Abort a pending Project upload and schedule its unregistered bytes for cleanup. ${WORKSPACE_API_KEY_DENIED}`,
       tags: ['Files'],
-      errors: [...RESOURCE_CONFLICT_ERRORS, 'PayloadTooLarge', 'UnsupportedMediaType'],
+      errors: RESOURCE_CONFLICT_ERRORS,
       success: { description: 'Abort Project File Upload result.', headers: RATE_LIMIT_HEADERS },
     },
     {
@@ -122,7 +122,7 @@ export const projectFileUploadOpenApiRoutes = [
       summary: 'Complete Project file upload',
       description: `Finalize verified bytes and atomically register one Project file. Retrying completion returns the same file without billing twice. Current edit access is checked again. ${WORKSPACE_API_KEY_DENIED}`,
       tags: ['Files'],
-      errors: [...RESOURCE_CONFLICT_ERRORS, 'PayloadTooLarge', 'UnsupportedMediaType'],
+      errors: [...RESOURCE_CONFLICT_ERRORS, 'PayloadTooLarge'],
       success: { description: 'Complete Project File Upload result.', headers: RATE_LIMIT_HEADERS },
     },
     {

apps/sim/lib/api/contracts/v2/project-files.ts

@@ -77,7 +77,9 @@ export const v2CreateProjectFileBodySchema = z
   .object({
     name: v2CreateFileBodySchema.shape.name,
     contentType: v2CreateFileBodySchema.shape.contentType,
-    content: v2CreateFileBodySchema.shape.content,
+    content: v2CreateFileBodySchema.shape.content.describe(
+      'Initial file content. Omit or send an empty string for a zero-byte file. The complete JSON request is capped at 70 MiB, including UTF-8 encoding, escaping, base64, and the envelope. The decoded-file limit is 50 MiB. Use an upload session for larger payloads.'
+    ),
     encoding: v2CreateFileBodySchema.shape.encoding,
     folderPath: v2CreateFileBodySchema.shape.folderPath.describe(
       'Canonical containing-folder path. Omit for the Project root.'
@@ -89,7 +91,9 @@ export type V2CreateProjectFileBody = z.input<typeof v2CreateProjectFileBodySche
 
 export const v2UpdateProjectFileContentBodySchema = z
   .object({
-    content: v2UpdateFileContentBodySchema.shape.content,
+    content: v2UpdateFileContentBodySchema.shape.content.describe(
+      'Complete replacement content for the file. The complete JSON request is capped at 70 MiB, including UTF-8 encoding, escaping, base64, and the envelope. The decoded-file limit is 50 MiB.'
+    ),
     encoding: v2UpdateFileContentBodySchema.shape.encoding,
     expectedRevision: v2UpdateFileContentBodySchema.shape.expectedRevision,
   })

apps/sim/lib/projects/files/__integration__/authorization.integration.ts

@@ -41,6 +41,7 @@ import {
 import { defineAuthorizedProjectFileUseCase } from '@/lib/projects/files/application/authorized-use-case'
 import { projectFileOperations } from '@/lib/projects/files/application/operations'
 import { resolveFileFolderTarget } from '@/lib/uploads/contexts/workspace'
+import { resolveArchivedFileFolderScope } from '@/lib/uploads/contexts/workspace/file-folder-manager'
 import { readWorkspaceFileMetadata } from '@/lib/workspace-files/application/read-workspace-file-metadata'
 
 vi.mock('@/lib/core/config/feature-flags', () => featureFlagsMock)
@@ -589,6 +590,15 @@ describe('Project file authority at the database boundary', () => {
         principal: f.reader,
         input: { ...base, scope: 'archived', folderPath, recursive },
       })
+    expect(
+      await resolveArchivedFileFolderScope(
+        { entityType: 'project', entityId: f.projectId },
+        '/Docs',
+        false,
+        2,
+        db
+      )
+    ).toEqual(expect.arrayContaining([docsId, archivedDocsId]))
     expect((await archivedPage('/Docs')).files.map((file) => file.id)).toEqual([
       fileIds[1],
       archivedIds[0],
@@ -673,6 +683,17 @@ describe('Project file authority at the database boundary', () => {
         expect(result.file.path).toBe(`/api/projects/${f.projectId}/files/${fileId}/content`)
         expect(result.vfsPath).toBe(vfsPath)
       }
+      for (const name of ['content', 'meta.json']) {
+        await db
+          .update(workspaceFiles)
+          .set({ originalName: name })
+          .where(eq(workspaceFiles.id, fileId))
+        expect((await resolve(`files/Q3%2FQ4/${name}`)).file.id).toBe(fileId)
+      }
+      await db
+        .update(workspaceFiles)
+        .set({ originalName: 'Architecture overview.md' })
+        .where(eq(workspaceFiles.id, fileId))
       for (const reference of [
         foreignId,
         archivedId,

apps/sim/lib/projects/files/__integration__/browser.integration.ts

@@ -1,6 +1,6 @@
 import { mkdir, writeFile } from 'node:fs/promises'
 import { dirname } from 'node:path'
-import { db } from '@sim/db'
+import { db, runOutsideTransactionContext } from '@sim/db'
 import { folder, permissions, project, user, workspace, workspaceFiles } from '@sim/db/schema'
 import { deleteWorkspaceFixture, insertWorkspaceFixture } from '@sim/db/testing/workspace-fixtures'
 import { createSessionPrincipal } from '@sim/testing/factories/principal.factory'
@@ -12,6 +12,7 @@ import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 import { listProjectFileItems } from '@/lib/projects/files/application'
 import { deleteUserAccount } from '@/lib/users/account-deletion'
 import type { FileBrowserQuery } from '@/lib/workspace-files/browser-query'
+import * as browserQuery from '@/lib/workspace-files/browser-query'
 
 interface BrowserFixture {
   workspaceId: string
@@ -195,6 +196,33 @@ afterAll(async () => {
 })
 
 describe('Project browser real mixed collection', () => {
+  check('file records preserve page order and snapshot through a concurrent archive', async () => {
+    const f = await fixture()
+    const small = await f.addFile('a-small.txt', 1)
+    const large = await f.addFile('z-large.txt', 20)
+    const original = browserQuery.queryFileBrowserItems
+    const query = vi
+      .spyOn(browserQuery, 'queryFileBrowserItems')
+      .mockImplementationOnce(async (...args) => {
+        const page = await original(...args)
+        await runOutsideTransactionContext(() =>
+          db
+            .update(workspaceFiles)
+            .set({ deletedAt: new Date() })
+            .where(eq(workspaceFiles.id, large))
+        )
+        return page
+      })
+    try {
+      const page = await f.list({ sortBy: 'size', sortOrder: 'desc' })
+      expect(page.items.map((item) => item.id)).toEqual([large, small])
+      expect(page.files.map((file) => file.id)).toEqual([large, small])
+      expect((await f.list()).files.map((file) => file.id)).toEqual([small])
+    } finally {
+      query.mockRestore()
+    }
+  })
+
   check(
     'type, size and creator predicates select the complete collection before pagination',
     async () => {

apps/sim/lib/projects/files/__integration__/content.integration.ts

@@ -1602,7 +1602,7 @@ describe('Project Copilot content admission', () => {
           const execute = () =>
             operation.execute({
               principal,
-              input: { projectId: f.projectId, fileId: file.id, version: 1 },
+              input: { projectId: f.projectId, fileId: file.id },
             })
           await expect(
             gate === 'missing'

apps/sim/lib/projects/files/__integration__/documents.integration.ts

@@ -24,6 +24,7 @@ import { generateId } from '@sim/utils/id'
 import { eq, inArray, sql } from 'drizzle-orm'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 import * as Y from 'yjs'
+import * as storage from '@/lib/uploads/core/storage-service'
 
 vi.mock('@/lib/uploads/core/setup.server', () => uploadsSetupMock)
 
@@ -179,6 +180,36 @@ function documentId(update: Uint8Array) {
 }
 
 describe('Project collaborative documents against current policy and durable storage', () => {
+  check('aborted seeds stop storage reads and do not retry', async () => {
+    const f = await fixture('read')
+    const controller = new AbortController()
+    const reason = new Error('Seed request retired')
+    const read = vi.spyOn(storage, 'downloadFile').mockImplementationOnce(async (options) => {
+      expect(options.signal).toBeDefined()
+      controller.abort(reason)
+      options.signal?.throwIfAborted()
+      throw new Error('Expected aborted storage read')
+    })
+    try {
+      await expect(
+        buildProjectFileDocSeed.execute({
+          principal: f.principal,
+          input: { ...f.target, signal: controller.signal },
+        })
+      ).rejects.toBe(reason)
+      expect(read).toHaveBeenCalledTimes(1)
+      await expect(
+        buildProjectFileDocSeed.execute({
+          principal: f.principal,
+          input: { ...f.target, signal: controller.signal },
+        })
+      ).rejects.toBe(reason)
+      expect(read).toHaveBeenCalledTimes(1)
+    } finally {
+      read.mockRestore()
+    }
+  })
+
   check('readers receive a stable seed but cannot publish durable document edits', async () => {
     const f = await fixture('read')
     expect(