improvement(knip): check entry exports of private packages and delete their dead barrels (#8595)

* improvement(knip): check entry exports of private packages and delete their dead barrels

- knip.jsonc: includeEntryExports on for every private package except db
- delete the bare @sim/utils and @sim/workflow-persistence barrels and their "." exports
- drop unused re-exports from the workflow-renderer and desktop-bridge barrels; un-export symbols only used in-file
- delete 7 unreferenced emcn icons
- baseline the remaining 262 entry-export findings (one-time rule expansion via --update --init)

* improvement(packages): resolve the private-package exports the entry-export check exposed

- Delete exports nothing uses: RadarChart, ChipModalPromptBody, InputOTPSeparator,
  DropdownMenuGroup/Portal, legacy terminal tool names, and dead types and helpers
- Drop `export` from declarations used only in their own file, and remove barrel
  re-exports no consumer imports
- Tag getOAuthClientCapabilityFields and generateRandomBytes `@public`: generate-docs
  loads the first by file path, and check:utils names the second
- Trim the workflow-authz mock to the module's remaining exports
- The unused-exports baseline gains no entries and drops one

* fix(emcn): keep ChipTimePicker in the barrel as documented chip-family API

* chore(emcn): export CVA variants only once another module composes them

* chore(emcn): delete the PillsRing icon, unused since the generic resource panel lost its entry list

* chore(knip): shrink the unused-exports baseline after rebasing onto staging

Author: waleedlatif1

.claude/rules/emcn-components.md

@@ -12,7 +12,7 @@ Import components, `cn`, and tokens from the `@sim/emcn` barrel; icons come from
 
 Never hand-roll the chip pill from raw class strings (they go stale). Compose from the canonical sources:
 
-- **Surface, typography + content tokens:** `chip/chip-chrome.ts` — `chipFilledSurfaceTokens`, `chipFieldSurfaceClass`, `chipFieldTextClass` (text fields and the dropdown search box build on these), plus the chip-content chrome `chipContentGap`, `chipGeometryClass`, `chipContentIconClass`, `chipContentLabelClass`, `cellIconNodeClass` (non-chip surfaces that must visually match chip content, e.g. resource table cells), and the row-state pair `chipHoverSurfaceClass` / `chipActiveSurfaceClass` (hover vs. selected — mutually exclusive, so a selected row holds its surface through hover; every hand-rolled row imports these rather than restating the literals). All are re-exported from the `@sim/emcn` barrel — no subpath import needed.
+- **Surface, typography + content tokens:** `chip/chip-chrome.ts` — `chipFieldSurfaceClass`, `chipFieldTextClass` (text fields and the dropdown search box build on these), plus the chip-content chrome `chipContentGap`, `chipGeometryClass`, `chipContentIconClass`, `chipContentLabelClass`, `cellIconNodeClass` (non-chip surfaces that must visually match chip content, e.g. resource table cells), and the row-state pair `chipHoverSurfaceClass` / `chipActiveSurfaceClass` (hover vs. selected — mutually exclusive, so a selected row holds its surface through hover; every hand-rolled row imports these rather than restating the literals). All are re-exported from the `@sim/emcn` barrel — no subpath import needed.
 - **Pill geometry:** `chip/chip.tsx` — `chipVariants` (30px tall, `rounded-lg`, `px-2`, icon↔text `gap-1.5`). Every pill-shaped trigger (`ChipDropdown`, `ChipSelect`, `ChipSwitch`) reuses it for visual parity.
 
 Canonical look: normal font-weight (never `font-medium`/`font-semibold`), value text `--text-body`, icons `--text-icon` at `size-[14px]`, placeholder `--text-muted`, `transition-colors`, **no focus ring** (the caret marks focus). Filled surface is `--surface-5` light / `--surface-4` dark with a `--border` border (`chip-chrome.ts` still spells it through the legacy alias `--border-1`; new code writes `--border`).
@@ -54,6 +54,6 @@ Declare keyboard intent on the action-owning primitive; never add document-level
 - **Discriminated-union props for modes** (e.g. `multiple`, the modal field `type`) instead of near-duplicate components.
 - **Delete legacy variants after migration** — leave no dead paths.
 - **Verify CSS vars exist.** An undefined var resolves to `currentColor`, which draws black borders. Align to the canonical tokens: normal weight, `--text-body`, `--text-icon`.
-- Use Radix UI primitives for accessibility. Export the component and its `variants` (when using CVA). Document with TSDoc + a usage example.
+- Use Radix UI primitives for accessibility. Export the component; export its CVA `variants` once another module composes them (`check:unused-exports` flags an export nothing imports). Document with TSDoc + a usage example.
 
 Color tokens and icon-size conventions are canonical in `.claude/rules/sim-styling.md` — follow it rather than restating.

.cursor/rules/emcn-components.mdc

@@ -13,7 +13,7 @@ Import components, `cn`, and tokens from the `@sim/emcn` barrel; icons come from
 
 Never hand-roll the chip pill from raw class strings (they go stale). Compose from the canonical sources:
 
-- **Surface, typography + content tokens:** `chip/chip-chrome.ts` — `chipFilledSurfaceTokens`, `chipFieldSurfaceClass`, `chipFieldTextClass` (text fields and the dropdown search box build on these), plus the chip-content chrome `chipContentGap`, `chipGeometryClass`, `chipContentIconClass`, `chipContentLabelClass`, `cellIconNodeClass` (non-chip surfaces that must visually match chip content, e.g. resource table cells), and the row-state pair `chipHoverSurfaceClass` / `chipActiveSurfaceClass` (hover vs. selected — mutually exclusive, so a selected row holds its surface through hover; every hand-rolled row imports these rather than restating the literals). All are re-exported from the `@sim/emcn` barrel — no subpath import needed.
+- **Surface, typography + content tokens:** `chip/chip-chrome.ts` — `chipFieldSurfaceClass`, `chipFieldTextClass` (text fields and the dropdown search box build on these), plus the chip-content chrome `chipContentGap`, `chipGeometryClass`, `chipContentIconClass`, `chipContentLabelClass`, `cellIconNodeClass` (non-chip surfaces that must visually match chip content, e.g. resource table cells), and the row-state pair `chipHoverSurfaceClass` / `chipActiveSurfaceClass` (hover vs. selected — mutually exclusive, so a selected row holds its surface through hover; every hand-rolled row imports these rather than restating the literals). All are re-exported from the `@sim/emcn` barrel — no subpath import needed.
 - **Pill geometry:** `chip/chip.tsx` — `chipVariants` (30px tall, `rounded-lg`, `px-2`, icon↔text `gap-1.5`). Every pill-shaped trigger (`ChipDropdown`, `ChipSelect`, `ChipSwitch`) reuses it for visual parity.
 
 Canonical look: normal font-weight (never `font-medium`/`font-semibold`), value text `--text-body`, icons `--text-icon` at `size-[14px]`, placeholder `--text-muted`, `transition-colors`, **no focus ring** (the caret marks focus). Filled surface is `--surface-5` light / `--surface-4` dark with a `--border` border (`chip-chrome.ts` still spells it through the legacy alias `--border-1`; new code writes `--border`).
@@ -55,6 +55,6 @@ Declare keyboard intent on the action-owning primitive; never add document-level
 - **Discriminated-union props for modes** (e.g. `multiple`, the modal field `type`) instead of near-duplicate components.
 - **Delete legacy variants after migration** — leave no dead paths.
 - **Verify CSS vars exist.** An undefined var resolves to `currentColor`, which draws black borders. Align to the canonical tokens: normal weight, `--text-body`, `--text-icon`.
-- Use Radix UI primitives for accessibility. Export the component and its `variants` (when using CVA). Document with TSDoc + a usage example.
+- Use Radix UI primitives for accessibility. Export the component; export its CVA `variants` once another module composes them (`check:unused-exports` flags an export nothing imports). Document with TSDoc + a usage example.
 
 Color tokens and icon-size conventions are canonical in `.claude/rules/sim-styling.md` — follow it rather than restating.

CLAUDE.md

@@ -8,7 +8,7 @@ This file (also `AGENTS.md`) holds the repo-wide rules. Area detail lives in `.c
 - **Logging**: `createLogger` from `@sim/logger`; `logger.info` / `logger.warn` / `logger.error`, never `console.log`. Inside `withRouteHandler` the logger already carries the request ID — no manual `withMetadata({ requestId })`.
 - **Comments**: name things so the code explains itself. TSDoc documents exported APIs and non-obvious modules. An inline `//` is only for a terse, non-obvious *why*, or for a script-enforced `// <tag>: <reason>` annotation (`boundary-raw-fetch`, `double-cast-allowed`, `boundary-raw-json`, `untyped-response`, `rq-lint-allow`, `client-boundary-allow`, `utils-lint-allow`, …). History belongs in the commit message. No `====` separators or commented-out code (`check:comment-hygiene` enforces this). The `/you-might-not-need-a-comment` skill applies this to a diff.
 - **ID generation**: `generateId()` (UUID v4, the default) or `generateShortId(size?)` (URL-safe, 21 chars by default) from `@sim/utils/id` — never `crypto.randomUUID()`, `nanoid`, or `uuid`. Both use `crypto.getRandomValues()`, so they also work in non-secure (HTTP) browsers. For other randomness, `@sim/utils/random` (`randomInt`, `randomFloat`, `randomItem`, `generateRandomBytes`, `generateRandomHex`) — never `Math.random()` or `crypto.randomBytes()`.
-- **Common utilities**: use the shared helpers from `@sim/utils` instead of inline implementations (`check:utils` bans most of the inline forms below):
+- **Common utilities**: use the shared helpers from the `@sim/utils/<module>` subpaths instead of inline implementations (`check:utils` bans most of the inline forms below):
   - `sleep(ms)` from `@sim/utils/helpers` — never `new Promise(resolve => setTimeout(resolve, ms))`
   - `toError(e)` from `@sim/utils/errors` — normalize caught values to `Error`; never `e instanceof Error ? e : new Error(String(e))`
   - `getErrorMessage(e, fallback?)` from `@sim/utils/errors` — never `e instanceof Error ? e.message : 'fallback'`

apps/sim/lib/credentials/application/discover-managed-mcp-tools.test.ts

@@ -42,7 +42,7 @@ vi.mock('@/lib/mcp/application/use-cases', () => mcpUseCasesMock)
 vi.mock('@/lib/workspaces/application/workspace-context', () => workspaceContextMock)
 vi.mock('@/lib/permission-groups/config-scope.server', () => permissionGroupScopeMock)
 vi.mock('@/lib/workflows/application/context', () => workflowContextMock)
-vi.mock('@sim/workflow-persistence', () => ({
+vi.mock('@sim/workflow-persistence/load', () => ({
   loadWorkflowFromNormalizedTablesRaw: hoisted.loadWorkflow,
 }))
 

apps/sim/lib/mcp/application/execute-managed-tool.test.ts

@@ -18,7 +18,7 @@ const hoisted = vi.hoisted(() => ({
   saveToolSnapshot: vi.fn(),
 }))
 
-vi.mock('@sim/workflow-persistence', () => ({
+vi.mock('@sim/workflow-persistence/load', () => ({
   loadWorkflowFromNormalizedTablesRaw: hoisted.loadWorkflow,
 }))
 

apps/sim/lib/mcp/application/execute-tool.test.ts

@@ -25,7 +25,7 @@ const hoisted = vi.hoisted(() => ({
   getServer: vi.fn(),
 }))
 
-vi.mock('@sim/workflow-persistence', () => ({
+vi.mock('@sim/workflow-persistence/load', () => ({
   loadWorkflowFromNormalizedTablesRaw: hoisted.loadWorkflow,
 }))
 

apps/sim/lib/mcp/application/operation-access.test.ts

@@ -3,7 +3,9 @@ import { queueTableRows, resetDbChainMock, schemaMock } from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { loadWorkflow } = vi.hoisted(() => ({ loadWorkflow: vi.fn() }))
-vi.mock('@sim/workflow-persistence', () => ({ loadWorkflowFromNormalizedTablesRaw: loadWorkflow }))
+vi.mock('@sim/workflow-persistence/load', () => ({
+  loadWorkflowFromNormalizedTablesRaw: loadWorkflow,
+}))
 
 import {
   loadMcpOperationAccess,

apps/sim/lib/mcp/application/operation-access.ts

@@ -2,7 +2,7 @@ import type { Principal } from '@sim/auth/principal'
 import { db } from '@sim/db'
 import { workflowDeploymentVersion } from '@sim/db/schema'
 import { isPlainRecord } from '@sim/utils/object'
-import { loadWorkflowFromNormalizedTablesRaw } from '@sim/workflow-persistence'
+import { loadWorkflowFromNormalizedTablesRaw } from '@sim/workflow-persistence/load'
 import { and, eq } from 'drizzle-orm'
 import { OrchestrationError } from '@/lib/core/orchestration/types'
 import {

apps/sim/stores/workflows/workflow/types.ts

@@ -38,7 +38,7 @@ export type {
   Variable,
   WorkflowState,
 }
-export { isValidSubflowType, SUBFLOW_TYPES } from '@sim/workflow-types/workflow'
+export { SUBFLOW_TYPES } from '@sim/workflow-types/workflow'
 
 export interface WorkflowActions {
   updateNodeDimensions: (id: string, dimensions: { width: number; height: number }) => void

knip.jsonc

@@ -4,19 +4,22 @@
   // Unused exports, types, and duplicates are ratcheted by check:unused-exports,
   // which reuses this config in the same knip pass.
   "include": ["files", "dependencies", "unlisted", "unresolved"],
-  // knip's default, stated so it is a decision: no entry file's exports are reported.
-  // That keeps package `exports`/`main`/`bin` contracts (ts-sdk, emcn, cli, …) and framework
-  // entries (Next routes, Trigger tasks) public, and also exempts the other configured entries
-  // (scripts, `*.integration.ts`, `background/**`, desktop and SDK examples).
-  "includeEntryExports": false,
+  // On by default: every workspace's `exports` map serves only this monorepo, so an entry export
+  // no workspace imports is dead. The workspaces below turn it off because their entries are
+  // public or standalone: the apps (framework entries such as Next routes and Trigger tasks), the
+  // published packages (cli, sim-cli, sim-setup, ts-sdk), db (standalone scripts), and the root
+  // (scripts). A new private package is checked without opting in.
+  "includeEntryExports": true,
   "workspaces": {
     ".": {
+      "includeEntryExports": false,
       "entry": ["scripts/**/*.{ts,tsx}", "vitest.shared.ts"],
       "paths": { "@/*": ["./apps/sim/*"] },
       // This alias selects the native tsc binary; see check-native-typecheck.ts.
       "ignoreDependencies": ["@typescript/native"]
     },
     "apps/sim": {
+      "includeEntryExports": false,
       "entry": [
         // Container bootstrap and Trigger's directory-discovered task graph.
         "bootstrap.ts",
@@ -69,8 +72,9 @@
       // Live test spawns this path with cwd=MSHIP_WORKER_ROOT (a sibling repo).
       "ignoreUnresolved": ["tools/probes/src/controller-run-read.ts"]
     },
-    "apps/realtime": { "entry": ["src/bootstrap.ts"] },
+    "apps/realtime": { "includeEntryExports": false, "entry": ["src/bootstrap.ts"] },
     "apps/desktop": {
+      "includeEntryExports": false,
       // scripts/build.ts and e2e/updater.spec.ts supply these to esbuild by path.
       "entry": [
         "src/main/index.ts",
@@ -83,24 +87,30 @@
       // ensure-pty-prebuilds.ts assembles these package names for universal builds.
       "ignoreDependencies": ["@lydell/node-pty-darwin-arm64", "@lydell/node-pty-darwin-x64"]
     },
+    "apps/docs": { "includeEntryExports": false },
+    "apps/pii": { "includeEntryExports": false },
+    "packages/cli": { "includeEntryExports": false },
     "packages/db": {
+      "includeEntryExports": false,
       "entry": [
         "scripts/*.ts",
         "script-migrations/*.ts",
         "**/*.integration.ts",
         "vitest.integration.setup.ts"
       ]
     },
-    "packages/sim-cli": {
-      "entry": ["src/index.ts", "src/runtime.ts", "scripts/*.ts"]
-    },
-    "packages/ts-sdk": { "entry": ["examples/*.ts"] },
     // The contract audit reads this snapshot by filename.
     // Generated, so its export surface is not ratcheted either.
     "packages/desktop-bridge": {
       "entry": ["contract-snapshot.ts"],
       "ignoreIssues": { "contract-snapshot.ts": ["exports", "types", "duplicates"] }
     },
+    "packages/sim-cli": {
+      "includeEntryExports": false,
+      "entry": ["src/index.ts", "src/runtime.ts", "scripts/*.ts"]
+    },
+    "packages/sim-setup": { "includeEntryExports": false },
+    "packages/ts-sdk": { "includeEntryExports": false, "entry": ["examples/*.ts"] },
     // This shared config is consumed by apps that own the Next dependency.
     "packages/tsconfig": { "ignoreUnresolved": ["next"] }
   }