fix(audits): close review bypasses in source-conventions and record-coercion checks

Author: waleedlatif1

apps/sim/lib/billing/webhooks/enterprise.ts

@@ -3,7 +3,7 @@ import { db } from '@sim/db'
 import { foldedEmail, organization, outboxEvent, session, subscription, user } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { generateId } from '@sim/utils/id'
-import { isRecordLike, toRecord } from '@sim/utils/object'
+import { toRecord } from '@sim/utils/object'
 import { normalizeEmail } from '@sim/utils/string'
 import { and, eq, inArray, sql } from 'drizzle-orm'
 import type Stripe from 'stripe'
@@ -330,7 +330,7 @@ async function reconcileManualEnterpriseSubscription(
     }
 
     const configOperationId = metadata.simConfigOperationId
-    const existingMetadata = isRecordLike(existing?.metadata) ? existing.metadata : {}
+    const existingMetadata = toRecord(existing?.metadata)
     const configurationAlreadyApplied =
       typeof configOperationId === 'string' &&
       configOperationId.length > 0 &&

apps/sim/lib/webhooks/providers/emailbison.ts

@@ -190,7 +190,7 @@ export const emailBisonHandler: WebhookProviderHandler = {
       )
     }
 
-    const data = isRecordLike(responseBody?.data) ? responseBody.data : null
+    const data = toRecordOrNull(responseBody?.data)
     const externalId = data?.id
     if (externalId === undefined || externalId === null || externalId === '') {
       throw new Error('Email Bison webhook was created but the API response did not include an ID.')

apps/sim/lib/webhooks/providers/slack.ts

@@ -5,7 +5,7 @@ import { safeCompare } from '@sim/security/compare'
 import { hmacSha256Hex } from '@sim/security/hmac'
 import { toStringOrNull } from '@sim/utils/coerce'
 import { toError } from '@sim/utils/errors'
-import { isRecordLike, toRecord } from '@sim/utils/object'
+import { isRecordLike, toRecord, toRecordOrNull } from '@sim/utils/object'
 import { eq } from 'drizzle-orm'
 import { LRUCache } from 'lru-cache'
 import { NextResponse } from 'next/server'
@@ -1053,11 +1053,7 @@ export const slackHandler: WebhookProviderHandler = {
     event.title = asString(rawEvent?.title)
     event.previous_title = asString(rawEvent?.previous_title)
     event.tab = asString(rawEvent?.tab)
-    event.context = isRecordLike(rawEvent?.context)
-      ? rawEvent.context
-      : isRecordLike(rawEvent?.app_context)
-        ? rawEvent.app_context
-        : null
+    event.context = toRecordOrNull(rawEvent?.context) ?? toRecordOrNull(rawEvent?.app_context)
     event.team_id =
       asString(b?.team_id) ||
       asString(rawEvent?.team_id) ||

scripts/check-source-conventions.baseline.json

@@ -215,6 +215,7 @@
     "apps/sim/lib/mothership/request/go/inline-images.test.ts": 1,
     "apps/sim/lib/mothership/request/handlers/complete.ts": 2,
     "apps/sim/lib/mothership/request/handlers/error.ts": 2,
+    "apps/sim/lib/mothership/request/handlers/index.ts": 9,
     "apps/sim/lib/mothership/request/handlers/resource.ts": 1,
     "apps/sim/lib/mothership/request/handlers/run.ts": 2,
     "apps/sim/lib/mothership/request/handlers/session.ts": 1,
@@ -307,6 +308,7 @@
     "apps/sim/providers/gemini/core.ts": 1,
     "apps/sim/providers/gemini/streaming-tool-loop.ts": 2,
     "apps/sim/providers/openai/core.ts": 1,
+    "apps/sim/providers/openai/index.ts": 1,
     "apps/sim/proxy.ts": 5,
     "apps/sim/scripts/copilot-messages-reconcile.ts": 1,
     "apps/sim/scripts/export-workflow.ts": 4,
@@ -521,7 +523,7 @@
     "apps/sim/app/(landing)/integrations/(shell)/page.tsx": 1,
     "apps/sim/app/(landing)/integrations/components/integration-card.tsx": 3,
     "apps/sim/app/(landing)/integrations/components/integration-grid.tsx": 1,
-    "apps/sim/app/(landing)/integrations/components/integration-icon.tsx": 2,
+    "apps/sim/app/(landing)/integrations/components/integration-icon.tsx": 1,
     "apps/sim/app/(landing)/integrations/components/request-integration-modal.tsx": 1,
     "apps/sim/app/(landing)/knowledge/components/feature-graphics/connector-sync-graphic.tsx": 3,
     "apps/sim/app/(landing)/knowledge/components/knowledge-product-previews/knowledge-product-previews.tsx": 1,
@@ -573,7 +575,7 @@
     "apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-editor.tsx": 1,
     "apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/block/block.tsx": 2,
     "apps/sim/components/icons.tsx": 9,
-    "apps/sim/content/blog/agent-as-yjs-peer/components/agent-peer-demo.tsx": 8,
+    "apps/sim/content/blog/agent-as-yjs-peer/components/agent-peer-demo.tsx": 9,
     "apps/sim/content/blog/enterprise/components.tsx": 3,
     "apps/sim/content/blog/v0-5/components/diff-controls-demo.tsx": 5,
     "apps/sim/lib/content/mdx.tsx": 7