test(desktop): ring the doorbell until heard, and time claim and completion separately in the E2E

Author: waleedlatif1

apps/sim/lib/desktop/application/executor.integration.ts

@@ -718,11 +718,19 @@ describe.runIf(Boolean(redisUrl))('desktop background executor protocol', () =>
       const close = stream.subscribe((event, data) => heard.push({ event, data }))
       try {
         await expect.poll(() => isDesktopPresent(desktop.deviceId)).toBe(true)
-        ringDesktopInbox(generateId(), 'call')
-        ringDesktopInbox(desktop.deviceId, 'cancel')
+        /**
+         * A Redis subscription is acknowledged asynchronously, so each poll rings both devices
+         * until this one hears it; the other device's doorbell must never reach this stream.
+         */
         await expect
-          .poll(() => heard)
-          .toEqual([{ event: 'inbox_changed', data: { reason: 'cancel' } }])
+          .poll(() => {
+            ringDesktopInbox(generateId(), 'call')
+            ringDesktopInbox(desktop.deviceId, 'cancel')
+            return heard.length
+          })
+          .toBeGreaterThan(0)
+        expect(heard.every(({ data }) => data.reason === 'cancel')).toBe(true)
+        expect(heard[0]).toEqual({ event: 'inbox_changed', data: { reason: 'cancel' } })
       } finally {
         close()
       }

apps/sim/scripts/test-desktop-inbox-e2e.ts

@@ -472,11 +472,16 @@ async function run() {
         { silent: true }
       )
       await waitFor(
-        () => executor.completed.has(toolCallId),
+        () => executor.ran.has(toolCallId),
         PICKUP_GRACE_SECONDS * 1000,
-        'the reconcile pull'
+        'the reconcile pull to claim the call'
       )
       assert(Date.now() - issuedAt < PICKUP_GRACE_SECONDS * 1000)
+      await waitFor(
+        () => executor.completed.has(toolCallId),
+        10_000,
+        'the claimed call to complete'
+      )
       const [row] = await callRows([toolCallId])
       assert.equal(row.status, 'completed')
     })