fix(issues): type errors from CI

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/issues/components/issue-activity.tsx

@@ -141,7 +141,7 @@ interface IssueCommentProps {
 function IssueComment({ workspaceId, issueKey, event, author }: IssueCommentProps) {
   const { data: session } = useSession()
   const deleteComment = useDeleteIssueComment()
-  const isOwn = Boolean(event.actor?.userId && event.actor.userId === session?.user.id)
+  const isOwn = Boolean(event.actor?.userId && event.actor.userId === session?.user?.id)
   const name = author?.name ?? 'Someone'
   return (
     <li className='my-2 flex flex-col gap-1.5 rounded-lg border border-[var(--border)] px-3 py-2.5'>

apps/sim/app/workspace/[workspaceId]/issues/components/issue-properties.tsx

@@ -1,14 +1,13 @@
 'use client'
 
 import type { ComponentType } from 'react'
-import { Avatar, ChipDropdown, type ChipDropdownOption } from '@sim/emcn'
+import { Avatar, AvatarFallback, ChipDropdown, type ChipDropdownOption } from '@sim/emcn'
 import {
   Dashboard,
   Database,
   File as FileIcon,
   Link as LinkIcon,
   Table as TableIcon,
-  User,
   Workflow,
 } from '@sim/emcn/icons'
 import { JiraIcon, LinearIcon } from '@/components/icons'
@@ -76,7 +75,15 @@ function OwnerProperty({ workspaceId, issue, canEdit }: PropertyProps) {
   const members = useWorkspaceMembersQuery(workspaceId)
   const updateIssue = useUpdateIssue()
   const options = [
-    { value: UNASSIGNED, label: 'Unassigned', icon: User },
+    {
+      value: UNASSIGNED,
+      label: 'Unassigned',
+      iconElement: (
+        <Avatar size='xs' aria-hidden>
+          <AvatarFallback />
+        </Avatar>
+      ),
+    },
     ...(members.data ?? []).map((member) => ({
       value: member.userId,
       label: member.name,

apps/sim/lib/api/contracts/v2/openapi/resources.ts

@@ -545,6 +545,7 @@ type ResourceTag =
   | 'Credentials'
   | 'Secrets'
   | 'Catalog'
+  | 'Issues'
 
 function resourceOperation(
   tag: ResourceTag,

apps/sim/lib/data-drains/sources/copilot-chats.ts

@@ -45,6 +45,7 @@ const chatColumns = {
   lastSeenAt: copilotChats.lastSeenAt,
   autoAllowedTools: copilotChats.autoAllowedTools,
   pinned: copilotChats.pinned,
+  issueId: copilotChats.issueId,
   deletedAt: copilotChats.deletedAt,
   createdAt: copilotChats.createdAt,
   updatedAt: copilotChats.updatedAt,

apps/sim/lib/issues/application/issues.ts

@@ -88,7 +88,8 @@ async function resolveIssueContext({ input }: { input: IssueInput }): Promise<Is
   return { ...workspace, issue: row }
 }
 
-const authorizeIssues = ({ context }: { context: ActiveWorkspaceApplicationContext }) =>
+/** Called from an unannotated `authorizeResource` arrow, so it never narrows the inferred context. */
+const authorizeIssues = (context: { workspaceOrganizationId: string | null }) =>
   requireIssuesEnabled(context.workspaceOrganizationId)
 
 function validateTitle(title: string): string {
@@ -169,7 +170,7 @@ export const listIssues = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: { workspaceId: string } }) =>
     resolveActiveWorkspaceApplicationContext(input.workspaceId),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ context }) {
     const rows = await listWorkspaceIssues(context.workspaceId)
     return { issues: await presentRows(rows) }
@@ -180,7 +181,7 @@ export const getIssueDetail = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.read,
   resolveContext: resolveIssueContext,
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ context }) {
     const issueId = context.issue.id
     const [issue, events, chats, resources, tickets] = await Promise.all([
@@ -219,7 +220,7 @@ export const createIssue = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: CreateIssueInput }) =>
     resolveActiveWorkspaceApplicationContext(input.workspaceId),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const title = validateTitle(input.title)
     if (Buffer.byteLength(input.body, 'utf-8') > MAX_BODY_BYTES)
@@ -283,7 +284,7 @@ export const updateIssue = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.update,
   resolveContext: ({ input }: { input: UpdateIssueInput }) => resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const current = context.issue
     const values: Partial<IssueRow> = {}
@@ -330,7 +331,7 @@ export const startIssue = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { chatId: string } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const userId = requirePrincipalSubjectUserId(principal)
     const chat = await getUserWorkspaceChat(db, input.chatId, context.workspaceId, userId)
@@ -363,7 +364,7 @@ export const requestIssueReview = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { summary: string } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const summary = input.summary.trim()
     if (!summary) throw new OrchestrationError('validation', 'Say what changed for the reviewer')
@@ -388,7 +389,7 @@ export const approveIssue = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.review,
   resolveContext: resolveIssueContext,
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ context, principal }) {
     await transition(
       context.issue.id,
@@ -408,7 +409,7 @@ export const requestIssueChanges = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { note?: string } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const note = input.note?.trim() || null
     await transition(
@@ -433,7 +434,7 @@ export const closeIssue = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.close,
   resolveContext: ({ input }: { input: CloseIssueInput }) => resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     let duplicateOf: IssueRow | null = null
     if (input.reason === 'duplicate') {
@@ -474,7 +475,7 @@ export const reopenIssue = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.close,
   resolveContext: resolveIssueContext,
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ context, principal }) {
     await transition(
       context.issue.id,
@@ -504,7 +505,7 @@ export const addIssueResource = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.update,
   resolveContext: ({ input }: { input: IssueResourceInput }) => resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     await db.transaction(async (tx) => {
       const added = await insertIssueResourceInTx(
@@ -528,7 +529,7 @@ export const removeIssueResource = defineAuthorizedWorkspaceUseCase({
   operation: issueOperations.update,
   resolveContext: ({ input }: { input: IssueResourceInput }) => resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     await db.transaction(async (tx) => {
       const removed = await deleteIssueResourceInTx(
@@ -553,7 +554,7 @@ export const linkIssueTicket = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { ticket: IssueTicketInsert } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     await db.transaction(async (tx) => {
       const linked = await insertIssueTicketInTx(tx, context.issue.id, input.ticket)
@@ -573,7 +574,7 @@ export const unlinkIssueTicket = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { ticketId: string } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     await db.transaction(async (tx) => {
       const unlinked = await deleteIssueTicketInTx(tx, context.issue.id, input.ticketId)
@@ -596,7 +597,7 @@ export const addIssueComment = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { body: string } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const body = input.body.trim()
     if (!body) throw new OrchestrationError('validation', 'A comment cannot be empty')
@@ -620,7 +621,7 @@ export const deleteIssueComment = defineAuthorizedWorkspaceUseCase({
   resolveContext: ({ input }: { input: IssueInput & { commentId: string } }) =>
     resolveIssueContext({ input }),
   authorizationOptions,
-  authorizeResource: authorizeIssues,
+  authorizeResource: ({ context }) => authorizeIssues(context),
   async execute({ input, context, principal }) {
     const userId = requirePrincipalSubjectUserId(principal)
     const deleted = await db.transaction((tx) =>

apps/sim/lib/issues/repository.integration.ts

@@ -1,13 +1,16 @@
-import { readFileSync } from 'node:fs'
+import { readdirSync, readFileSync } from 'node:fs'
 import { join } from 'node:path'
+import type * as schema from '@sim/db/schema'
 import { readTestDatabaseUrl } from '@sim/db/testing/test-infrastructure'
 import { withUtcTimestamps } from '@sim/db/timestamps'
 import { generateId } from '@sim/utils/id'
 import { drizzle, type PostgresJsDatabase } from 'drizzle-orm/postgres-js'
 import postgres from 'postgres'
 import { afterAll, beforeAll, describe, expect, it, vi } from 'vitest'
 
-const database = vi.hoisted(() => ({ current: undefined as PostgresJsDatabase | undefined }))
+const database = vi.hoisted(() => ({
+  current: undefined as PostgresJsDatabase<typeof schema> | undefined,
+}))
 vi.mock('@sim/db', () => ({
   get db() {
     if (!database.current) throw new Error('Test database not initialized')
@@ -17,11 +20,20 @@ vi.mock('@sim/db', () => ({
 
 import { allocateIssueNumber, updateIssueInTx } from '@/lib/issues/repository'
 
-const MIGRATION = join(__dirname, '../../../../packages/db/migrations/0393_issue.sql')
+const MIGRATIONS_DIR = join(__dirname, '../../../../packages/db/migrations')
+
+/** Found by name, so renumbering on a rebase never strands the test on a missing file. */
+function issueMigrationPath(): string {
+  const [file, ...rest] = readdirSync(MIGRATIONS_DIR).filter((name) =>
+    /^\d+_issue\.sql$/.test(name)
+  )
+  if (!file || rest.length > 0) throw new Error('Expected exactly one *_issue.sql migration')
+  return join(MIGRATIONS_DIR, file)
+}
 
 /** The migration's own statements for the issue tables, checks, partial indexes and trigger. */
 function issueStatements(): string[] {
-  return readFileSync(MIGRATION, 'utf-8')
+  return readFileSync(issueMigrationPath(), 'utf-8')
     .split('--> statement-breakpoint')
     .map((statement) => statement.trim())
     .filter(
@@ -45,7 +57,7 @@ describe('issue state in PostgreSQL', () => {
     await connection`CREATE TABLE copilot_chats (id uuid PRIMARY KEY)`
     for (const statement of issueStatements()) await connection.unsafe(statement)
     await connection`ALTER TABLE issue ADD FOREIGN KEY (working_chat_id) REFERENCES copilot_chats(id) ON DELETE SET NULL`
-    database.current = drizzle(connection)
+    database.current = drizzle(connection, { schema })
   })
 
   afterAll(async () => {
@@ -73,7 +85,8 @@ describe('issue state in PostgreSQL', () => {
   }
 
   async function read(id: string) {
-    const [row] = await connection`SELECT status, working_chat_id FROM issue WHERE id = ${id}`
+    const [row] = await connection<{ status: string; working_chat_id: string | null }[]>`
+      SELECT status, working_chat_id FROM issue WHERE id = ${id}`
     const events = await connection`SELECT kind, payload FROM issue_event WHERE issue_id = ${id}`
     return { ...row, events }
   }

apps/sim/lib/mothership/chat/post.ts

@@ -130,6 +130,7 @@ const GENERIC_RESOURCE_TITLE: Record<z.infer<typeof ResourceAttachmentSchema>['t
   integration: 'Integration',
   file: 'File',
   dashboard: 'Dashboard',
+  issue: 'Issue',
   knowledgebase: 'Knowledge Base',
   folder: 'Folder',
   filefolder: 'File Folder',