improvement(tools): delete unreferenced tool response types and the dead generic resource data path (#8596)

* improvement(tools): delete unreferenced tool response types and the dead generic resource data path

- delete 168 exported tool *Response types nothing references (mostly umbrella unions) and the 24 local types only they used
- add-integration and add-tools templates declare one response type per tool and no umbrella union
- drop the never-set genericResourceData chat field; the generic resource panel renders its empty state directly

* chore(skills): name InternalToolConfig beside ToolConfig in the response-type guidance

Author: waleedlatif1

.agents/skills/add-integration/SKILL.md

@@ -85,13 +85,15 @@ export interface {Service}{Action}Params {
   optionalParam?: string
 }
 
-export interface {Service}Response extends ToolResponse {
+export interface {Service}{Action}Response extends ToolResponse {
   output: {
     // Define output structure
   }
 }
 ```
 
+Declare one response interface per tool, imported by that tool's `ToolConfig<Params, Response>` (or `InternalToolConfig` for in-process work). Never add an umbrella `{Service}Response` union: nothing imports it.
+
 **Tool file pattern:** an external provider API uses `ToolConfig` with `request` (absolute `https://` URL, headers, body, `transformResponse`); same-process Sim work uses `InternalToolConfig` with `operation`. Both full templates, param visibility rules, and output typing live in `.agents/skills/add-tools/SKILL.md` — read it before writing the first tool.
 
 ### Critical Rules

.agents/skills/add-tools/SKILL.md

@@ -423,6 +423,8 @@ export interface {Service}{Action}Response extends ToolResponse {
 }
 ```
 
+Each response interface is imported by its tool's config: `ToolConfig<Params, Response>` for an external API, `InternalToolConfig<Params, Response>` for in-process work. Never add an umbrella `{Service}Response` union of them: nothing imports it.
+
 ## Index.ts Barrel Export Pattern
 
 ```typescript

apps/sim/app/workspace/[workspaceId]/home/components/chat-resource-panel.tsx

@@ -47,7 +47,6 @@ export function ChatResourcePanel({
     setTableViewContext,
     previewSession,
     isSending,
-    genericResourceData,
   } = chat
   const {
     isResourceCollapsed,
@@ -102,7 +101,6 @@ export function ChatResourcePanel({
               isCollapsed={isResourceCollapsed}
               previewSession={previewSession}
               isAgentResponding={isSending}
-              genericResourceData={genericResourceData ?? undefined}
               onSummarize={summarize}
               onUserInteraction={handleResourceInteraction}
               className={skipResourceTransition ? 'transition-none!' : undefined}

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/generic-resource-content/generic-resource-content.tsx

@@ -1,73 +1,8 @@
-'use client'
-
-import { useEffect, useRef } from 'react'
-import { PillsRing } from '@sim/emcn'
-import { getToolStatusDisplayTitle } from '@/lib/mothership/tools/tool-display'
-import type { GenericResourceData } from '@/app/workspace/[workspaceId]/home/types'
-
-interface GenericResourceContentProps {
-  data: GenericResourceData
-}
-
-// TODO: Emir — replace with rich UI (status icons, collapsible result cards, copy-to-clipboard, etc.)
-export function GenericResourceContent({ data }: GenericResourceContentProps) {
-  const bottomRef = useRef<HTMLDivElement>(null)
-
-  useEffect(() => {
-    const el = bottomRef.current
-    const container = el?.parentElement
-    if (container) {
-      container.scrollTop = container.scrollHeight
-    }
-  }, [data.entries.length])
-
-  if (data.entries.length === 0) {
-    return (
-      <div className='flex h-full items-center justify-center'>
-        <p className='text-[var(--text-muted)] text-small'>No results yet</p>
-      </div>
-    )
-  }
-
+/** The panel for a `generic` resource, which carries no content of its own. */
+export function GenericResourceContent() {
   return (
-    <div className='flex h-full flex-col divide-y divide-[var(--border)] overflow-y-auto [scrollbar-gutter:stable]'>
-      {data.entries.map((entry) => (
-        <div key={entry.toolCallId} className='flex flex-col gap-2 px-4 py-3'>
-          <div className='flex items-center gap-2'>
-            {entry.status === 'executing' && (
-              <PillsRing className='size-[14px] shrink-0 text-[var(--text-tertiary)]' animate />
-            )}
-            <span className='text-[var(--text-primary)] text-small'>
-              {getToolStatusDisplayTitle(entry.displayTitle, entry.status, entry.toolName)}
-            </span>
-            {entry.status === 'error' && (
-              <span className='ml-auto text-[var(--text-error)] text-caption'>Error</span>
-            )}
-            {entry.status === 'skipped' && (
-              <span className='ml-auto text-[var(--text-muted)] text-caption'>Skipped</span>
-            )}
-            {entry.status === 'rejected' && (
-              <span className='ml-auto text-[var(--text-muted)] text-caption'>Rejected</span>
-            )}
-          </div>
-          {entry.streamingArgs && (
-            <pre className='overflow-x-auto whitespace-pre-wrap break-words font-mono text-[var(--text-body)] text-caption'>
-              {entry.streamingArgs}
-            </pre>
-          )}
-          {!entry.streamingArgs && entry.result?.output != null && (
-            <pre className='overflow-x-auto whitespace-pre-wrap break-words font-mono text-[var(--text-body)] text-caption'>
-              {typeof entry.result.output === 'string'
-                ? entry.result.output
-                : JSON.stringify(entry.result.output, null, 2)}
-            </pre>
-          )}
-          {entry.result?.error && (
-            <p className='text-[var(--text-error)] text-caption'>{entry.result.error}</p>
-          )}
-        </div>
-      ))}
-      <div ref={bottomRef} />
+    <div className='flex h-full items-center justify-center'>
+      <p className='text-[var(--text-muted)] text-small'>No results yet</p>
     </div>
   )
 }

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/resource-content.tsx

@@ -45,10 +45,7 @@ import { GenericResourceContent } from '@/app/workspace/[workspaceId]/home/compo
 import { TerminalSession } from '@/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/terminal-session/terminal-session'
 import { RESOURCE_TAB_ICON_CLASS } from '@/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-tabs/resource-tab-controls'
 import { hasRenderableFilePreviewContent } from '@/app/workspace/[workspaceId]/home/hooks/preview'
-import type {
-  GenericResourceData,
-  MothershipResource,
-} from '@/app/workspace/[workspaceId]/home/types'
+import type { MothershipResource } from '@/app/workspace/[workspaceId]/home/types'
 import { KnowledgeBase } from '@/app/workspace/[workspaceId]/knowledge/[id]/base'
 import { LogDetailsContent } from '@/app/workspace/[workspaceId]/logs/components'
 import { useFeatureFlag } from '@/app/workspace/[workspaceId]/providers/feature-flags-provider'
@@ -113,7 +110,6 @@ interface ResourceContentProps {
   previewMode?: PreviewMode
   previewSession?: FilePreviewSession | null
   isAgentResponding?: boolean
-  genericResourceData?: GenericResourceData
   previewContextKey?: string
   onNotFound?: (resourceId: string) => void
   /**
@@ -187,7 +183,6 @@ export const ResourceContent = memo(function ResourceContent({
   previewMode,
   previewSession,
   isAgentResponding,
-  genericResourceData,
   previewContextKey,
   onNotFound,
   visible = true,
@@ -351,9 +346,7 @@ export const ResourceContent = memo(function ResourceContent({
       )
 
     case 'generic':
-      return (
-        <GenericResourceContent key={resource.id} data={genericResourceData ?? { entries: [] }} />
-      )
+      return <GenericResourceContent key={resource.id} />
 
     case 'browser':
       // One panel serves every browser tab of the chat: the desktop app

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/mothership-view.tsx

@@ -27,7 +27,6 @@ import { TerminalSession } from '@/app/workspace/[workspaceId]/home/components/m
 import { ResourceWorkspaceHost } from '@/app/workspace/[workspaceId]/home/components/resource-workspace-host'
 import { hasRenderableFilePreviewContent } from '@/app/workspace/[workspaceId]/home/hooks/preview'
 import type {
-  GenericResourceData,
   MothershipResource,
   MothershipResourceType,
 } from '@/app/workspace/[workspaceId]/home/types'
@@ -105,7 +104,6 @@ interface MothershipViewProps {
   previewSession?: FilePreviewSession | null
   isAgentResponding?: boolean
   onSummarize: (message: string, filters: WorkspaceSearchFilters) => void
-  genericResourceData?: GenericResourceData
   /** Claims the current resource selection after direct panel interaction. */
   onUserInteraction?: () => void
 }
@@ -126,7 +124,6 @@ export const MothershipView = memo(
       className,
       previewSession,
       isAgentResponding,
-      genericResourceData,
       onSummarize,
       onUserInteraction,
     }: MothershipViewProps,
@@ -316,7 +313,6 @@ export const MothershipView = memo(
                 previewMode={isActivePreviewable ? previewMode : undefined}
                 previewSession={previewForActive}
                 isAgentResponding={isAgentResponding}
-                genericResourceData={active.type === 'generic' ? genericResourceData : undefined}
                 previewContextKey={chatId}
                 onNotFound={(resourceId) => removeResource('log', resourceId, active.workspaceId)}
               />
@@ -348,8 +344,7 @@ function ScopedResourceContent({
   if (props.resource.type === 'search')
     return <SearchResourceContent resource={props.resource} onSummarize={onSummarize} />
   if (!workspaceId) {
-    if (props.resource.type === 'generic')
-      return <GenericResourceContent data={props.genericResourceData ?? { entries: [] }} />
+    if (props.resource.type === 'generic') return <GenericResourceContent />
     if (props.resource.type === 'browser')
       return (
         <BrowserSession

apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts

@@ -142,7 +142,6 @@ import type {
   ChatRequestMode,
   ContentBlock,
   FileAttachmentForApi,
-  GenericResourceData,
   MothershipResource,
   MothershipResourceType,
   QueuedMessage,
@@ -281,7 +280,6 @@ export interface UseChatReturn {
   editingQueuedId: string | null
   dispatchingHeadId: string | null
   previewSession: FilePreviewSession | null
-  genericResourceData: GenericResourceData | null
   getCurrentRequestId: () => string | undefined
 }
 
@@ -4981,7 +4979,6 @@ export function useChat(
     editingQueuedId,
     dispatchingHeadId,
     previewSession,
-    genericResourceData: null,
     getCurrentRequestId,
   }
 }

apps/sim/app/workspace/[workspaceId]/home/types.ts

@@ -55,20 +55,6 @@ interface ToolCallResult {
   error?: string
 }
 
-interface GenericResourceEntry {
-  toolCallId: string
-  toolName: string
-  displayTitle: string
-  status: ToolCallStatus
-  params?: Record<string, unknown>
-  streamingArgs?: string
-  result?: ToolCallResult
-}
-
-export interface GenericResourceData {
-  entries: GenericResourceEntry[]
-}
-
 export interface ToolCallData {
   id: string
   toolName: string

apps/sim/blocks/blocks/airtable.ts

@@ -457,7 +457,6 @@ Return ONLY the valid JSON array of record ID strings - no explanations, no mark
     typecast: { type: 'boolean', description: 'Auto-convert string values to field types' },
     recordIds: { type: 'json', description: 'Record IDs to delete' }, // Required for delete
   },
-  // Output structure depends on the operation, covered by AirtableResponse union type
   outputs: {
     bases: { type: 'json', description: 'List of accessible Airtable bases' },
     tables: { type: 'json', description: 'Table schemas with fields and views' },

apps/sim/tools/ahrefs/types.ts

@@ -569,28 +569,3 @@ export interface AhrefsPaidPagesResponse extends ToolResponse {
     paidPages: AhrefsPaidPage[]
   }
 }
-
-export type AhrefsResponse =
-  | AhrefsDomainRatingResponse
-  | AhrefsBacklinksResponse
-  | AhrefsBacklinksStatsResponse
-  | AhrefsReferringDomainsResponse
-  | AhrefsOrganicKeywordsResponse
-  | AhrefsTopPagesResponse
-  | AhrefsKeywordOverviewResponse
-  | AhrefsBrokenBacklinksResponse
-  | AhrefsMetricsResponse
-  | AhrefsOrganicCompetitorsResponse
-  | AhrefsRankTrackerOverviewResponse
-  | AhrefsRankTrackerSerpOverviewResponse
-  | AhrefsRankTrackerCompetitorsOverviewResponse
-  | AhrefsRankTrackerCompetitorsStatsResponse
-  | AhrefsBatchAnalysisResponse
-  | AhrefsSiteAuditPageExplorerResponse
-  | AhrefsDomainRatingHistoryResponse
-  | AhrefsMetricsHistoryResponse
-  | AhrefsRefdomainsHistoryResponse
-  | AhrefsKeywordsHistoryResponse
-  | AhrefsRelatedTermsResponse
-  | AhrefsAnchorsResponse
-  | AhrefsPaidPagesResponse