fix(desktop): keep a recovered result's mark while it is parked

Author: waleedlatif1

apps/desktop/src/main/desktop-executor/executor.test.ts

@@ -568,6 +568,23 @@ describe('restarting', () => {
     expect(notDelivered).toEqual([])
   })
 
+  it('still leaves a recovered result open when Sim held one, after parking it', async () => {
+    const { sim, journal, executor, onUnregistered, delivered, notDelivered } = setup()
+    sim.completeErrors = [new DeviceRequestError(401, 'unregistered')]
+    sim.completionOutcome = 'duplicate'
+    await journal.put({ toolCallId: 'started-1', state: 'started', executionToken: 't-started' })
+    await executor.recover()
+    await vi.waitFor(() => expect(onUnregistered).toHaveBeenCalledTimes(1))
+
+    // Registered again.
+    executor.resumeParked()
+
+    await vi.waitFor(() => expect(sim.completions).toHaveLength(1))
+    await vi.waitFor(() => expect(journal.entries.size).toBe(0))
+    expect(delivered).toEqual([])
+    expect(notDelivered).toEqual([])
+  })
+
   it('reports a recovered result too large to send, then held as a duplicate, as never reaching the model', async () => {
     const { sim, journal, executor, delivered, notDelivered } = setup()
     // No run could have sent this result: it is too large every time.

apps/desktop/src/main/desktop-executor/executor.ts

@@ -129,6 +129,11 @@ export class DesktopExecutor {
   private recovering: Promise<void> | null = null
   /** Results a previous app run left, still on their way to Sim. */
   private readonly recoveringIds = new Set<string>()
+  /**
+   * Results a previous app run left, until Sim answers for them, parked ones included: that run's
+   * send of the real result may already have landed.
+   */
+  private readonly recoveredResults = new Set<string>()
   /** Results that have failed to reach Sim for longer than {@link DELIVERY_AWAKE_LIMIT_MS}. */
   private readonly stalledDeliveries = new Set<string>()
   /** Results Sim refused because it no longer recognized this device; sent once it registers again. */
@@ -190,6 +195,7 @@ export class DesktopExecutor {
       })
       // Held awake like a running call: the result exists only on this machine until Sim has it.
       this.recoveringIds.add(entry.toolCallId)
+      this.recoveredResults.add(entry.toolCallId)
       this.updateBusy()
       void this.deliver(entry.toolCallId, entry.executionToken, completion).finally(() => {
         this.recoveringIds.delete(entry.toolCallId)
@@ -434,7 +440,7 @@ export class DesktopExecutor {
         // A duplicate holds what this app run sent, unless the result was recovered unchanged from
         // an earlier run, whose send of the real result may have landed before the restart.
         const takenEarlier =
-          outcome === 'duplicate' && pending === completion && this.recoveringIds.has(toolCallId)
+          outcome === 'duplicate' && pending === completion && this.recoveredResults.has(toolCallId)
         notDelivered = !delivered && !takenEarlier
         break
       } catch (error) {
@@ -492,6 +498,7 @@ export class DesktopExecutor {
         )
       }
     }
+    this.recoveredResults.delete(toolCallId)
     if (this.disposed) return
     if (notDelivered) this.options.onResultNotDelivered?.(toolCallId)
     await this.forget(toolCallId)