fix(knowledge): report only the admission wait still left at the deadline

The bucket's stated wait is stored as an absolute instant so a deadline hit
after a sleep carries the remainder, not the original duration. A test pins
the knowledge admission wait below the retry budget the processing deadline
reserves for each request.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/lib/core/rate-limiter/provider-admission.ts

@@ -86,11 +86,17 @@ export async function waitForProviderAdmission(input: ProviderAdmissionInput): P
     },
   })
 
-  /** The bucket's last stated wait, so a deadline hit between polls still reports when capacity returns. */
-  let lastRetryAfterMs: number | undefined
+  /** When the bucket last said capacity returns, so a deadline hit after a sleep reports the wait still left. */
+  let capacityAvailableAt: number | undefined
   for (;;) {
     input.signal?.throwIfAborted()
-    if (Date.now() >= deadlineAt) throw new ProviderAdmissionTimeoutError(lastRetryAfterMs)
+    if (Date.now() >= deadlineAt) {
+      const remainingMs =
+        capacityAvailableAt === undefined ? undefined : capacityAvailableAt - Date.now()
+      throw new ProviderAdmissionTimeoutError(
+        remainingMs !== undefined && remainingMs > 0 ? remainingMs : undefined
+      )
+    }
     if (await isProviderQuotaExhausted(input))
       throw new ProviderQuotaExhaustedError(input.providerId)
     let result: AtomicAdmissionResult
@@ -112,7 +118,7 @@ export async function waitForProviderAdmission(input: ProviderAdmissionInput): P
     }
     if (result.allowed) return
     const waitMs = Math.max(1, result.retryAfterMs)
-    if (Number.isFinite(waitMs)) lastRetryAfterMs = waitMs
+    if (Number.isFinite(waitMs)) capacityAvailableAt = Date.now() + waitMs
     if (!Number.isFinite(waitMs) || waitMs >= deadlineAt - Date.now()) {
       if (await isProviderQuotaExhausted(input))
         throw new ProviderQuotaExhaustedError(input.providerId)

apps/sim/lib/embeddings/client.test.ts

@@ -10,6 +10,7 @@ import {
   assertKnowledgeEmbeddingCapacityForDeployment,
   clampEmbeddingConcurrency,
   EMBEDDING_MAX_RETRIES,
+  EMBEDDING_RETRY_BUDGET_MS,
   EmbeddingAPIError,
   EmbeddingOutputLimitError,
   EmbeddingQuotaExhaustedError,
@@ -1802,6 +1803,10 @@ describe('durable embedding batches', () => {
     expect(fetchMock).not.toHaveBeenCalled()
   })
 
+  it('keeps the checkpointed admission wait inside the retry budget the processing deadline reserves', () => {
+    expect(KNOWLEDGE_EMBEDDING_ADMISSION_WAIT_MS).toBeLessThan(EMBEDDING_RETRY_BUDGET_MS)
+  })
+
   it('limits checkpointed admission waits while retaining the interactive request budget', async () => {
     fetchMock.mockImplementation(() => Promise.resolve(jsonResponse(openAIBody([[1]], 7))))
     await embed(['text'], { apiKey: 'fixture-key', checkpoints: memoryCheckpoints() })