fix(files): await delivery observers and track private CLI downloads

Author: mzxchandra

apps/sim/app/api/files/serve/[...path]/route.test.ts

@@ -338,7 +338,10 @@ describe('File Serve API Route', () => {
       },
     })
 
-    async function serveVersionedDoc(dependsOnReferencedFiles: boolean) {
+    async function serveVersionedDoc(
+      dependsOnReferencedFiles: boolean,
+      method: 'GET' | 'HEAD' = 'GET'
+    ) {
       mockResolveStoredFileContext.mockResolvedValue('workspace')
       mockParseWorkspaceFileKey.mockReturnValue('test-workspace-id')
       mockAuthenticateWorkspaceFile.mockResolvedValue(principal)
@@ -349,6 +352,7 @@ describe('File Serve API Route', () => {
       })
 
       const req = createMockRequest({
+        method,
         url: 'http://localhost:3000/api/files/serve/workspace/test-workspace-id/report.pdf?v=1756684800000',
       })
       const response = await GET(
@@ -359,6 +363,15 @@ describe('File Serve API Route', () => {
       return response
     }
 
+    it('authorizes HEAD without compiling a representation or inventing its length', async () => {
+      const response = await serveVersionedDoc(true, 'HEAD')
+      expect(await response.text()).toBe('')
+      expect(response.headers.get('Content-Length')).toBeNull()
+      expect(response.headers.get('Cache-Control')).toBe('private, no-store')
+      expect(mockReadWorkspaceFileRecordByKey).toHaveBeenCalled()
+      expect(fileUtilsServerMockFns.mockDownloadServableFileFromStorage).not.toHaveBeenCalled()
+    })
+
     it('caches a versioned document immutably when its bytes derive from the stored source alone', async () => {
       const response = await serveVersionedDoc(false)
       expect(response.headers.get('Cache-Control')).toBe('private, max-age=31536000, immutable')

apps/sim/lib/mothership/agent-cli/file-read-transport.ts

@@ -105,6 +105,7 @@ export function createFileReadTransport(context: {
           workspaceId: parsed.data.query.workspaceId,
           actorUserId: context.invocation.userId,
           unknown: 'taint',
+          destination: 'workbench',
         }),
         () =>
           downloadWorkspaceFileStream.execute({

apps/sim/lib/mothership/content-delivery/registry-gate.test.ts

@@ -135,6 +135,23 @@ describe('createRegistryContentGate', () => {
     expect(await gate.admit([item('config', exact(SECRET))])).toEqual([false])
   })
 
+  it('tracks opaque workbench downloads without relaxing model or excerpt admission', async () => {
+    const registry = newRegistry()
+    const gate = createRegistryContentGate({
+      registry,
+      actorUserId: 'user-1',
+      destination: 'workbench',
+    })
+    expect(await gate.admit([item('download', exact(SECRET), 'opaque')])).toEqual([true])
+    expect(modelView(SECRET, registry)).not.toContain(SECRET)
+    expect(await gate.admit([item('snippet', exact(SECRET), 'excerpt')])).toEqual([false])
+    expect(
+      await createRegistryContentGate({ actorUserId: 'user-1', destination: 'workbench' }).admit([
+        item('download', exact(SECRET), 'opaque'),
+      ])
+    ).toEqual([false])
+  })
+
   it('refuses an unknown item without latching the registry', async () => {
     const registry = newRegistry()
     const gate = createRegistryContentGate({ registry, actorUserId: 'user-1' })

apps/sim/lib/mothership/content-delivery/registry-gate.ts

@@ -23,6 +23,8 @@ export interface RegistryContentGateScope {
    * anything persisted from it stays unknown. Only a direct single-file download takes it (D7).
    */
   unknown?: 'refuse' | 'taint'
+  /** Private workbench downloads persist imported provenance; opaque bytes never go directly to the model. */
+  destination?: 'model' | 'workbench'
 }
 
 /**
@@ -56,7 +58,11 @@ export function createRegistryContentGate(scope: RegistryContentGateScope): Cont
       return true
     }
     if (provenance.entries.length === 0) return true
-    if (source.view === 'opaque' || source.view === 'excerpt') return refuse(source, 'opaque')
+    if (
+      source.view === 'excerpt' ||
+      (source.view === 'opaque' && scope.destination !== 'workbench')
+    )
+      return refuse(source, 'opaque')
     const registry = scope.registry
     if (!registry) return refuse(source, 'registry')
     /** A derived view that shows nothing needs no entry; `undefined` would mean the whole item. */

apps/sim/lib/projects/files/__integration__/content-rendered.integration.ts

@@ -48,6 +48,7 @@ import * as storageCleanup from '@/lib/uploads/contexts/workspace/file-storage-c
 import * as storage from '@/lib/uploads/core/storage-service'
 import { storeCompiledDoc } from '@/lib/uploads/documents/compiled-store'
 import * as heic from '@/lib/uploads/server/heic'
+import { observeWorkspaceFileDelivery } from '@/lib/workspace-files/application/file-delivery-observer'
 import * as searchDelivery from '@/lib/workspace-files/search/delivery'
 import * as searchRepository from '@/lib/workspace-files/search/repository'
 
@@ -233,6 +234,41 @@ describe('Project delivery admission', () => {
       })
     }
   }
+  for (const kind of ['inline', 'csv', 'artifact'] as const) {
+    check(`${kind} awaits an asynchronous transport observer refusal`, async () => {
+      const f = await fixture()
+      const created = await createProjectFile.execute({
+        principal: f.principal,
+        input: {
+          ...createInput(f.projectId, 'name,value\nrow,secret'),
+          name: 'rows.csv',
+          contentType: 'text/csv',
+        },
+      })
+      const error = new Error('Transport observer refused delivery')
+      const input = { projectId: f.projectId, fileId: created.file.id, key: created.file.key }
+      await expect(
+        observeWorkspaceFileDelivery(
+          async () => {
+            throw error
+          },
+          () =>
+            kind === 'inline'
+              ? readProjectInlineFile.execute({
+                  principal: f.principal,
+                  input: { projectId: f.projectId, referenceFileId: created.file.id },
+                })
+              : kind === 'csv'
+                ? readProjectFileCsvPreview.execute({ principal: f.principal, input })
+                : readProjectFileArtifact.execute({
+                    principal: f.principal,
+                    input: { ...input, maxBytes: 1024 },
+                  })
+        )
+      ).rejects.toBe(error)
+    })
+  }
+
   check('Project search withholds stale previews and removes moved-out results', async () => {
     const f = await fixture()
     const created = await createProjectFile.execute({

apps/sim/lib/projects/files/application/artifacts.ts

@@ -356,6 +356,6 @@ export const readProjectFileArtifact = defineAuthorizedProjectFileUseCase<
       provenance: result.secretProvenance,
       view: 'opaque',
     })
-    reportWorkspaceFileDelivery(result.secretProvenance, result.file.id)
+    await reportWorkspaceFileDelivery(result.secretProvenance, result.file.id)
   },
 })

apps/sim/lib/projects/files/application/previews.ts

@@ -123,7 +123,7 @@ const readInlineFile = defineAuthorizedProjectFileUseCase({
       provenance: result.secretProvenance ?? { status: 'unknown' },
       view: 'opaque',
     })
-    reportWorkspaceFileDelivery(result.secretProvenance, result.file.id)
+    await reportWorkspaceFileDelivery(result.secretProvenance, result.file.id)
   },
 })
 
@@ -184,6 +184,6 @@ export const readProjectFileCsvPreview = defineAuthorizedProjectFileUseCase({
       provenance: result.secretProvenance ?? { status: 'unknown' },
       view: 'excerpt',
     })
-    reportWorkspaceFileDelivery(result.secretProvenance, input.fileId)
+    await reportWorkspaceFileDelivery(result.secretProvenance, input.fileId)
   },
 })