fix(files): align PDF export with repository audits

Author: Bill Leoutsakos

apps/sim/app/api/files/export/[id]/markdown-pdf.tsx

@@ -68,47 +68,26 @@ function resolveBrandFont(filename: string): string {
   return font
 }
 
-function resolveDependencyFont(packageName: string, filename: string): string {
-  const relativePath = join(packageName, 'files', filename)
-  const candidates = [
-    join(process.cwd(), 'node_modules', relativePath),
-    join(process.cwd(), '..', '..', 'node_modules', relativePath),
-    join(process.cwd(), 'apps', 'sim', 'node_modules', relativePath),
-  ]
-  const font = candidates.find(existsSync)
-  if (!font) throw new Error(`PDF dependency font not found: ${filename}`)
-  return font
-}
-
 const GEIST_REGULAR = resolveBrandFont('Geist-Regular.ttf')
 const GEIST_MEDIUM = resolveBrandFont('Geist-Medium.ttf')
-const UNIFONT_REGULAR = resolveDependencyFont(
-  '@fontsource/unifont',
-  'unifont-latin-400-normal.woff'
-)
-const NOTO_ARABIC = resolveDependencyFont(
-  '@fontsource/noto-sans-arabic',
-  'noto-sans-arabic-arabic-400-normal.woff'
+const UNIFONT_REGULAR = require.resolve('@fontsource/unifont/files/unifont-latin-400-normal.woff')
+const NOTO_ARABIC = require.resolve(
+  '@fontsource/noto-sans-arabic/files/noto-sans-arabic-arabic-400-normal.woff'
 )
-const NOTO_ARABIC_BOLD = resolveDependencyFont(
-  '@fontsource/noto-sans-arabic',
-  'noto-sans-arabic-arabic-700-normal.woff'
+const NOTO_ARABIC_BOLD = require.resolve(
+  '@fontsource/noto-sans-arabic/files/noto-sans-arabic-arabic-700-normal.woff'
 )
-const NOTO_DEVANAGARI = resolveDependencyFont(
-  '@fontsource/noto-sans-devanagari',
-  'noto-sans-devanagari-devanagari-400-normal.woff'
+const NOTO_DEVANAGARI = require.resolve(
+  '@fontsource/noto-sans-devanagari/files/noto-sans-devanagari-devanagari-400-normal.woff'
 )
-const NOTO_DEVANAGARI_BOLD = resolveDependencyFont(
-  '@fontsource/noto-sans-devanagari',
-  'noto-sans-devanagari-devanagari-700-normal.woff'
+const NOTO_DEVANAGARI_BOLD = require.resolve(
+  '@fontsource/noto-sans-devanagari/files/noto-sans-devanagari-devanagari-700-normal.woff'
 )
-const NOTO_HEBREW = resolveDependencyFont(
-  '@fontsource/noto-sans-hebrew',
-  'noto-sans-hebrew-hebrew-400-normal.woff'
+const NOTO_HEBREW = require.resolve(
+  '@fontsource/noto-sans-hebrew/files/noto-sans-hebrew-hebrew-400-normal.woff'
 )
-const NOTO_HEBREW_BOLD = resolveDependencyFont(
-  '@fontsource/noto-sans-hebrew',
-  'noto-sans-hebrew-hebrew-700-normal.woff'
+const NOTO_HEBREW_BOLD = require.resolve(
+  '@fontsource/noto-sans-hebrew/files/noto-sans-hebrew-hebrew-700-normal.woff'
 )
 
 /**

apps/sim/app/api/files/export/[id]/route.test.ts

@@ -7,6 +7,7 @@ import {
 } from '@sim/testing/mocks/files-authorization.mock'
 import { hybridAuthMockFns } from '@sim/testing/mocks/hybrid-auth.mock'
 import { posthogServerMock, posthogServerMockFns } from '@sim/testing/mocks/posthog-server.mock'
+import { rateLimiterMock, rateLimiterMockFns } from '@sim/testing/mocks/rate-limiter.mock'
 import { storageServiceMock, storageServiceMockFns } from '@sim/testing/mocks/storage-service.mock'
 import {
   uploadsMetadataMock,
@@ -20,13 +21,11 @@ import { getServeStoragePrefix } from '@/lib/uploads/config'
 const {
   mockExtractEmbeddedFileRefs,
   mockResolveWorkspaceInlineImage,
-  mockEnforceUserRateLimit,
   mockRenderMarkdownPdf,
   MockMarkdownPdfLimitError,
 } = vi.hoisted(() => ({
   mockExtractEmbeddedFileRefs: vi.fn(),
   mockResolveWorkspaceInlineImage: vi.fn(),
-  mockEnforceUserRateLimit: vi.fn(),
   mockRenderMarkdownPdf: vi.fn(),
   MockMarkdownPdfLimitError: class extends Error {},
 }))
@@ -45,9 +44,7 @@ vi.mock('@/lib/uploads/server/embedded-image-refs', () => ({
 vi.mock('@/lib/uploads/server/inline-image', () => ({
   resolveWorkspaceInlineImage: mockResolveWorkspaceInlineImage,
 }))
-vi.mock('@/lib/core/rate-limiter/route-helpers', () => ({
-  enforceUserRateLimit: mockEnforceUserRateLimit,
-}))
+vi.mock('@/lib/core/rate-limiter/route-helpers', () => rateLimiterMock)
 vi.mock('@/app/api/files/export/[id]/markdown-pdf', () => ({
   MarkdownPdfLimitError: MockMarkdownPdfLimitError,
   markdownPdfImageKey: (ref: { key?: string; fileId?: string }) =>
@@ -65,6 +62,7 @@ const mockVerifyFileAccess = filesAuthorizationMockFns.mockVerifyFileAccess
 const mockCheckAuth = hybridAuthMockFns.mockCheckSessionOrInternalAuth
 const mockRecordAudit = auditMockFns.mockRecordAudit
 const mockCaptureServerEvent = posthogServerMockFns.mockCaptureServerEvent
+const mockEnforceUserRateLimit = rateLimiterMockFns.mockEnforceUserRateLimit
 
 const MB = 1024 * 1024
 const DOC_ID = 'doc-1'

apps/sim/lib/api/contracts/storage-transfer.ts

@@ -200,7 +200,7 @@ export const fileExportParamsSchema = z.object({
   id: workspaceFileIdSchema,
 })
 
-export const fileExportQuerySchema = z.object({
+const fileExportQuerySchema = z.object({
   format: z.literal('pdf').optional(),
 })
 

apps/sim/lib/uploads/client/download.ts

@@ -1,6 +1,6 @@
 import { PASTE_LIMITS, utf8ByteLength } from '@sim/utils/paste'
 import { requestRaw } from '@/lib/api/client/request'
-import { fileExportContract } from '@/lib/api/contracts/storage-transfer'
+import { fileExportContract, type FileExportQuery } from '@/lib/api/contracts/storage-transfer'
 import { downloadWorkspaceFileItemsContract } from '@/lib/api/contracts/workspace-file-folders'
 import { exportWorkspaceFileSnapshotContract } from '@/lib/api/contracts/workspace-files'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
@@ -43,7 +43,7 @@ function fileNameFromDisposition(response: Response, fallback: string): string {
 export async function triggerFileDownload(
   record: WorkspaceFileRecord,
   source?: FileDownloadSource | null,
-  options?: { format?: 'pdf' }
+  options?: FileExportQuery
 ): Promise<void> {
   const isMarkdown =
     record.type === 'text/markdown' ||