You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9420a65
Browse filesBrowse the repository at this point in the historyBrowse files
polish(resources): stop the tables grid reappearing past its fade
The grid is authored larger than the box it fades inside — 358x160 drawn into
320x148, deliberately, so it runs off two edges. But a mask tile is sized to
the element box and `mask-repeat` starts at `repeat`, so the overflow landed in
the *next* tile at the opaque head of the gradient: a solid strip of cells
reappeared just past where the fade had finished dissolving. The frame now
clips, and every fade in the set pins `no-repeat` rather than relying on its
subject happening to fit.
Also:
- `--border-1` is a legacy alias; the new files use the canonical `--border`,
which `resource.tsx` was already using two lines above them.
- `createIsoLineProps` returns `SVGAttributes<SVGElement>`. It never returns a
`ref`, and `ref` was the only member forcing an element type — which had made
the knowledge mark reach for an `SVGPathElement & SVGCircleElement`
intersection to spread onto both. `className` moves last so no caller passes
`undefined` positionally to skip it.
- `isResourceListEmpty` is exported from the components barrel its four callers
already import `Resource` from, instead of being reached past it.
- `emptyState` sits after `rows` on all four tables; three had it leading.
- Two TSDoc blocks claimed things the code stopped doing: the folder graphic
does not have three fill tiers, and the empty-state wrapper grows the slot
but does not centre it.
Adds the predicate's unit test — it is a pure eight-clause function that
decides whether a page tells someone they have nothing, and it had none.
Verified it fails when the placeholder and folder guards are removed.
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-empty-state/files-empty-state.tsx
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-empty-state/knowledge-iso.tsx
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-empty-state/logs-empty-state.tsx
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-empty-state/tables-empty-state.tsx
0 commit comments